bit more help please Access Denied?? "FINALLY RESOLVED" THANKS ALL!!

[robvr6]

Hi I've been working on a small app that updates xml playlist through a batch file. I've been struggling to understand why it wont run from vb. I used this code tonight and in the dos output I got the message Access Denied - any suggestions/explanations???

Shell "C:\Program Files\mgamerz\my_mp3s\Update.bat", vbNormalFocus

cheers Rob

[RhinoBull]

Your XML file might have been be set as Read Only so check properties first.

[robvr6]

I already checked that and if I run the batch not from vb it works fine - Just when I thought I was gettin somewhere lol

[dglienna]

post what's in your batch file. is there a file open in VB that you are writing to?

[|2eM!x]

do this:

Public Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" _
    (ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, _
    ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd _
    As Long) As Long

Public Sub RunProgram(strProgram As String)
    Dim lRet As Long
    lRet = ShellExecute(vbNull, "", strProgram, "", "", SW_SHOWNORMAL)
End Sub

in a module

and in your form put:

RunProgram "C:\Program Files\mgamerz\my_mp3s\Update.bat"

[Armbruster]

I have a feeling this is a "Start in" problem . . .

|2eM!x (that is a wierd forum name), had the right idea, but he (or she) still left the lpDirectory parameter blank, so I suspect it would fail.

Put a pause in your batch file, then run it by itself. The pause will cause the cmd window to display. Look in the window at the path.

Now run your vb app. (Make sure you leave the pause in the batch file). Look in the cmd window this time. Notice the path? This time the path was the application path, not the batch files path.

Windows 2000 and XP, by default, start batch files in directory they were run from, not the directory they are located in. When you double-click on the batch file you are starting the batch file in the directory it is located in. When you shell out to the batch file from your vb app, you are starting the batch file in your application path.

That having been said, shell is very, very ugly at best. I would (and alway do) use the shellexecute api. Just be sure to specify the lpDirectory parameter so the batch file starts in that directory

[|2eM!x]

can you explain the lpDirectory to me? would it be like ipdirectory = (dir) or what?

thanks

oh and its remix

[robvr6]

could you explain how I would add that please? Any chance of a bit of an example thanks Rob

[robvr6]

Hi I have tried adding the module and changing the code on my command button but nothing happens. I add a pause in my batch file but cannot see the path. The most confusing aspect of this is that the batch file works perfectly when ran by itself.


thanks

Rob

[robvr6]

In Reply to dglienna here is my batch file

@echo off
pause
SET filein=mp3.txt
SET fileout=audiolist.xml
SET filedir="%my_mp3s%"

if NOT %filedir%=="" goto continue

cd > %filein%

for /f "tokens=*" %%i in ( %filein% ) do (
SET filedir="%%i"
)

:continue

dir %filedir%\*.mp3 /b > %filein%

echo ^<?xml version="1.0"?^> > %fileout%
echo ^<songs^> >> %fileout%

for /f "tokens=*" %%i in ( %filein% ) do (
echo ^<song path=%filedir\%"my_mp3s/%%i" title="%%i"/^> >> %fileout%
)

echo ^</songs^> >> %fileout%




call c:

cd PROGRA~1

cd mgamerz

cd my_mp3s

copy audiolist.xml c:\PROGRA~1\mgamerz


echo file: audiolist.xml is ready


as Ive said this works fine when just double clicked but as soon as I call it from VB It aint having it

ROb