whats wrong with my functions? [resolved]

[ice_531]

Okay, im not going to go into every aspect of the program but here goes:

I've written 2 functions on my serverside which checks a username list for a match n if it finds it then it goes to the 2nd function which then checks if the password in the other listbox matches whats in the database aswell.

now on my client end , its waiting to receive a "failed" , "1" ,or "2" string back... i know the problem lies in my loginCheck1 function. but say that the login fails due to incorrect username it sends failed twice and then a 1 because maybe the password matches..no clue how this happens seeing as how it shouldn't even go to loginCheck2 if check1 doesnt succeed.

Private Function loginCheck1()
Dim i As Integer
Dim userName As String
Dim IntList As Integer
userName = Text1 'the username attempting to login
For i = 0 To List2.ListCount - 1
If InStr(userName, List2.List(i)) Then ' check database list for username
'do whatever you need here.....if it finds the name
IntList = i
List3.Text = List3.List(IntList) 'get corresponding pass next to username
loginCheck2 ' send to logincheck2 function to check if password matches too
Exit For 'exit for if found
Else
'send back message saying incorrect username/password
server.senddata "failed" 
End If
Next
End Function
 
Private Function loginCheck2()
Dim strLogin As String
Dim userPass As String
userPass = Text2
'check to see if the password matches whats in the database under that username
If List3.Text = userPass Then
'it matches, do stuff here
strLogin = "1"
server.SendData strLogin
List1.AddItem server.RemoteHostIP & " has logged in successfully! at: " & Now
Else
strLogin = "2"
server.SendData strLogin
End If
End Function

and heres the client end

Private Sub client_DataArrival(ByVal bytesTotal As Long)
Dim strLogin As String
' do stuff to verify if login was successful
client.GetData strLogin
Text1.Text = strLogin
If strLogin = "1" Then
MsgBox "You have logged in successfully! Welcome to the Valeo Chat System...", vbInformation, "Valeo System"
budlist.Show 'since they've logged in correctly, load buddylist lol =D
ElseIf strLogin = "2" Then
MsgBox "Sorry, but your login attempt has failed due to an incorrect username/password!", vbCritical, "Login Failed"
client.Close ' close connection to server
End If
End Sub

im sure im just not seeing something obvious though,

[westconn1]

can't get it to go into function 2 while username dosen't match, but your server.senddata should be outside your for loop and sent only if the loop completes without match, (if it matches on last list item of 600 you'd get 599 failed messages first, then a 1

Private Function loginCheck1()
Dim i As Integer
Dim userName As String
Dim IntList As Integer
userName = Text1 'the username attempting to login
For i = 0 To List2.ListCount - 1
    If InStr(userName, List2.List(i)) Then ' check database list for username
        'do whatever you need here.....if it finds the name
        IntList = i
        List3.Text = List3.List(IntList) 'get corresponding pass next to username
        loginCheck2 ' send to logincheck2 function to check if password matches too
        Exit For 'exit for if found
'        Else
''send back message saying incorrect username/password
''server.senddata "failed" End If
    End If
 Next
   MsgBox "failed"
End Function

[ice_531]

I've moved stuff around so many times...
When the senddata is outside of the loop it does fix part of the problem also i added an exitfor with the senddata with it inside the loop...both of these return the same type of results

when the username and password indeed do match with username and password in lists then it sends a 2 for some reason and nothing else...so i do at least get a msgbox, just the wrong msgbox.

when i login with a name and pwd which isnt in the db it sends nothing back.

where shall i move stuff around in the check1 function?

[jeroen79]

Indeed.
Your loop sends a "failed" every time it finds no match.
Then, if it finds a match, it will start logincheck2.

What you could do is declare a boolean and let the loop make it true if it finds a match.
Then, outside the loop, you make another if-then that sends a "failed" if the boolean is false.

If it did find a match then logincheck2 would have sent something else before exiting the loop.

[ice_531]

Indeed.
Your loop sends a "failed" every time it finds no match.
Then, if it finds a match, it will start logincheck2.

What you could do is declare a boolean and let the loop make it true if it finds a match.
Then, outside the loop, you make another if-then that sends a "failed" if the boolean is false.

If it did find a match then logincheck2 would have sent something else before exiting the loop.

ahh im such an idiot , i remember doing that in the past for a similiar type function to function method.
let me try then ill post

[ice_531]

Private Function loginCheck1()
Dim i As Integer
Dim userName As String
Dim bFound As Boolean
Dim IntList As Integer
userName = Text1 'the username attempting to login
For i = 0 To List2.ListCount - 1
If InStr(userName, List2.List(i)) Then ' check database list for username
'do whatever you need here.....if it finds the name
bFound = True
IntList = i
List3.Text = List3.List(IntList) 'get corresponding pass next to username
loginCheck2 ' send to logincheck2 function to check if password matches too
Exit For 'exit for if found
End If
Next
If Not bFound Then
    server.SendData "2" 'send the failed attempt
End If
End Function

working so far on all of my test attempts.

Thanks for everyones input

[westconn1]

instead of the boolean you can replace exit for , with exit sub as you are finised ther anyway

p.



oops exit function