Run Files [Resolved]

[iori85z]

Hi,
I am having problems running a file. What I have now is a textbox which shows some batch commands. I want to run the commands in the textbox upon pressing a run button. So how do I program the run button to make it capture the text from the textbox and run it? I couldn't even seem to cature the text within the textbox. Is some1 familiar with this?

[Deepak Sakpal]

u access textbox's text like this;

'put this code in Run button click

Msgbox Text1.Text


Batch commands ? u mean dos commands ? want to execute dos commands from vb ?

[iori85z]

Actually, the text the user input into the textbox will be first saved to .vbs (vb script) format using a save button, and i have already got tat working. When the user press the run button, it will run the vbs file. I think i post wrongly juz now, it should be tat the run button will run the vbs file which has been saved. So is it possible?

[Deepak Sakpal]

Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" _
(ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, _
ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
 
Private Const SW_HIDE = 0
Private Const SW_SHOWNORMAL = 1
 
Private Sub Command1_Click()
    ShellExecute vbNull, vbNullString, "c:\SayHello.vbs", vbNullString, vbNullString, SW_HIDE
End Sub

SayHello.vbs:

MsgBox "Hello"

[iori85z]

I tried your code, when I press the run button, there is no error msg, however, the vbs file did not run. I tried different path and even replaced it to try open a txt file but nothing opened or run as well?? Muz I declare more variables or I mus add some more code to it?

[Deepak Sakpal]

bcoz it runs in hidden mode. use this

ShellExecute vbNull, vbNullString, "c:\SayHello.vbs", vbNullString, vbNullString, SW_SHOWNORMAL

[iori85z]

Ok. I get wat u mean. What if I don't want to set the file to be open to be always the same? Can it like when I press the run button, it will open out a selection window to let me select from several vbs files and let me choose 1 to run? It uses the common dialog rite? How do I modify the code?

[Deepak Sakpal]

Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" _
(ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, _
ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
 
Private Const SW_HIDE = 0
Private Const SW_SHOWNORMAL = 1
 
Private Sub Form_Load()
    cdlOpen.Flags = cdlOFNFileMustExist
    cdlOpen.CancelError = False
    cdlOpen.Filter = "Text (*.vbs)|*.vbs"
    cdlOpen.ShowOpen
    If Len(cdlOpen.FileName) = 0 Then Exit Sub
    ShellExecute vbNull, vbNullString, cdlOpen.FileName, vbNullString, vbNullString, SW_SHOWNORMAL
End Sub

[iori85z]

Thanks man, ur code works but now I have another problem. While the vbs file is running, the codes will pop up with the common dialog screen and display the commands on the common dialog textfield. I tried to open a textfile by modifying the extension and it works fine, seems like it will have such error when running vbs file because of the sleep time and the multiple commands. Is there a way to let the commands show in a console window while it is running then close automatically when it finish?

[Deepak Sakpal]

i don't get it

[iori85z]

I mean tat for example, if i use ur code to run a textfile, it will open it in a notepad and everything is smooth. But if I try to run a vbs file, a vbs file has alot of commands which is suppose to be input in DOS or telnet mode, therefore cannot run smoothly and will generate many error messages. The error messages will keep on popping out with the common dialog window.

[RobDog888]

This will run your vbs file in DOS.

Option Explicit
 
Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" _
(ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, _
ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
 
Private Const SW_HIDE = 0
Private Const SW_SHOWNORMAL = 1
 
Private Sub Command1_Click()
    On Error GoTo No_Bugs
    With cdlRun
        .Flags = cdlOFNFileMustExist Or cdlOFNHideReadOnly Or cdlOFNPathMustExist
        .CancelError = True
        .Filter = "VB Script files only (*.vbs)|*.vbs"
        .DialogTitle = "Select a script to run"
        .ShowOpen
    End With
    ShellExecute Me.hwnd, "OPEN", "C:\Winnt\System32\cmd.exe", " /C " & cdlRun.FileName, "C:\", SW_SHOWNORMAL
    Exit Sub
No_Bugs:
    MsgBox "Operation canceled by user!',vbokonly+vbexclamation"
End Sub

If you change the /C to /K then it will keep the command window
open until you close it. /K closes the command window.

You can change the program so it will work on different os
version because XP's location of the cmd.exe is in Windows\system32.

VB/Outlook Guru

[iori85z]

Hi RobDog888, i tried to run the code u gave me, I changed the cd1 to the name of my Common Dialog name and run it, but it generate a error at the
.Flags = dlgCommonDialogOFNFileMustExist
line.

The compile error is variable not define. Why is it so? Is it because of the OFN? Btw wat does OFN do and wat is it?

[RobDog888]

Its an error from copying the code. The flags code line should
read...

.Flags = cdlOFNFileMustExist Or cdlOFNHideReadOnly Or cdlOFNPathMustExist

[iori85z]

OK, but my Common Dialog's Name is dlgCommonDialog not cd1, if I change it back to cd1 it also got the same compile error. The other codes are all left unchange. I onli change the name of the common dialog tats all.

Or do i have to change my common dialog's name to cd1 because the code for the flag must have a cd1 name?

[RobDog888]

I think we are not on the same page so here is the code modified
for your app. Just change the Command1_Click event to the same
name as your button. Do NOT change anything in the .Flags line.
Those are vb constants and not commondialog names.

Option Explicit
 
Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" _
(ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, _
ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
 
Private Const SW_HIDE = 0
Private Const SW_SHOWNORMAL = 1
 
Private Sub Command1_Click()
    On Error GoTo No_Bugs
    With dlgCommonDialog
        .Flags = cdlOFNFileMustExist Or cdlOFNHideReadOnly Or cdlOFNPathMustExist
        .CancelError = True
        .Filter = "VB Script files only (*.vbs)|*.vbs"
        .DialogTitle = "Select a script to run"
        .ShowOpen
    End With
    ShellExecute Me.hwnd, "OPEN", "C:\Winnt\System32\cmd.exe", " /C " & dlgCommonDialog.FileName, "C:\", SW_SHOWNORMAL
    Exit Sub
No_Bugs:
    MsgBox "Operation canceled by user!',vbokonly+vbexclamation"
End Sub

[iori85z]

Thanks man, I manage to get it working but everytime I cancel it, I figured tat it goes to the On_bug and start a msgbox to show operation canceled. I tried commentin out the On Error Code but it will generate another error. Is there a way tat when I cancel it, it will just cancel away and show no msgbox or error msg?

[chemicalNova]

All you must do is comment out the MsgBox line, or delete it all together:

'Solution A
Option Explicit
 
Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" _
(ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, _
ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
 
Private Const SW_HIDE = 0
Private Const SW_SHOWNORMAL = 1
 
Private Sub Command1_Click()
    On Error GoTo No_Bugs
    With dlgCommonDialog
        .Flags = cdlOFNFileMustExist Or cdlOFNHideReadOnly Or cdlOFNPathMustExist
        .CancelError = True
        .Filter = "VB Script files only (*.vbs)|*.vbs"
        .DialogTitle = "Select a script to run"
        .ShowOpen
    End With
    ShellExecute Me.hwnd, "OPEN", "C:\Winnt\System32\cmd.exe", " /C " & dlgCommonDialog.FileName, "C:\", SW_SHOWNORMAL
    Exit Sub
No_Bugs:
    'MsgBox "Operation canceled by user!',vbokonly+vbexclamation"
End Sub

'Solution B
Option Explicit
 
Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" _
(ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, _
ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
 
Private Const SW_HIDE = 0
Private Const SW_SHOWNORMAL = 1
 
Private Sub Command1_Click()
    On Error [b]Resume Next[/b]
    With dlgCommonDialog
        .Flags = cdlOFNFileMustExist Or cdlOFNHideReadOnly Or cdlOFNPathMustExist
        .CancelError = True
        .Filter = "VB Script files only (*.vbs)|*.vbs"
        .DialogTitle = "Select a script to run"
        .ShowOpen
    End With
    ShellExecute Me.hwnd, "OPEN", "C:\Winnt\System32\cmd.exe", " /C " & dlgCommonDialog.FileName, "C:\", SW_SHOWNORMAL
End Sub

Phreak

[iori85z]

Alrite, thanks man, i got it up and working. Thanks for all ur help and time debuggin wif me, I realli appreciate it alot.

[iori85z]

Oh, now tat the code works, the exit button which I have programmed begin to hav an error. It works fine b4 tat but didn't noe y now it give an error when pressed. It says variable not define. The code is:

'Exits program
Private Sub cmdExit_Click()

'Prompt to quit
exitResponse = MsgBox("Quit program?", vbYesNo, "Exit program")

'Check to see if response was a yes
If exitResponse = 6 Then

'Close program
End

End If

End Sub

Is there any problems wif the code but I run it b4 and it works fine. Don't noe y now it generate an error. Is there any problems or bugs? Or is there another way to quit the program in this way (have a msgbox to confirm quiting b4 realli exiting) w/o any error?

[Deepak Sakpal]

'Exits program
Private Sub cmdExit_Click()
    'Prompt to quit
    Dim exitResponse As Integer
    exitResponse = MsgBox("Quit program?", vbYesNo, "Exit program")
    
    'Check to see if response was a yes
    If exitResponse = 6 Then
        'Close program
        End
    End If
End Sub

[Deepak Sakpal]

use this:

Dim iCtr As Integer
For iCtr = 0 To Forms.Count - 1
    Unload Forms(iCtr)
Next

[chemicalNova]

This is easier than knowing the values off by heart:

'Check to see if response was a yes
If exitResponse = vbYes Then

Just so you know, check the Object Browser.

Phreak

[Jacob Roman]

Correct me if I'm wrong, but I thought batch commands were for batch files with the .bat extention. The .vbs extention is for VBScript.

[Deepak Sakpal]

yeh..the .vbs extention is for VBScript.

[iori85z]

Alritey, thanks every1, i got it working.