Why wont this work.....

[Help]

Hello

Here is my code......

Public Const HKEY_CLASSES_ROOT = &H80000000
Public Const HKEY_CURRENT_USER = &H80000001
Public Const HKEY_LOCAL_MACHINE = &H80000002
Public Const HKEY_USERS = &H80000003
Public Const HKEY_PERFORMANCE_DATA = &H80000004

Declare Function RegCloseKey Lib "advapi32.dll" (ByVal hkey As Long) As Long
Declare Function RegCreateKey Lib "advapi32.dll" Alias "RegCreateKeyA" (ByVal hkey As Long, ByVal lpSubKey As String, phkResult As Long) As Long
Declare Function RegOpenKey Lib "advapi32.dll" Alias "RegOpenKeyA" (ByVal hkey As Long, ByVal lpSubKey As String, phkResult As Long) As Long
Declare Function RegQueryValueEx Lib "advapi32.dll" Alias "RegQueryValueExA" (ByVal hkey As Long, ByVal lpValueName As String, ByVal lpReserved As Long, lpType As Long, lpData As Any, lpcbData As Long) As Long
Declare Function RegSetValueEx Lib "advapi32.dll" Alias "RegSetValueExA" (ByVal hkey As Long, ByVal lpValueName As String, ByVal Reserved As Long, ByVal dwType As Long, lpData As Any, ByVal cbData As Long) As Long


Function RegQueryStringValue(ByVal hkey As Long, ByVal strValueName As String)

    Dim lResult As Long
    Dim lValueType As Long
    Dim strBuf As String
    Dim lDataBufSize As Long

    On Error GoTo 0
    lResult = RegQueryValueEx(hkey, strValueName, 0&, lValueType, ByVal 0&, lDataBufSize)
    If lResult = ERROR_SUCCESS Then
        If lValueType = REG_SZ Then
            strBuf = String(lDataBufSize, " ")
            lResult = RegQueryValueEx(hkey, strValueName, 0&, 0&, ByVal strBuf, lDataBufSize)
            If lResult = ERROR_SUCCESS Then
                RegQueryStringValue = StripTerminator(strBuf)
            End If
        End If
    End If

End Function

Public Function GetString(hkey As Long, strpath As String, strvalue As String)

    Dim keyhand&
    Dim datatype&
    r = RegOpenKey(hkey, strpath, keyhand&)
    GetString = RegQueryStringValue(keyhand&, strvalue)
    r = RegCloseKey(keyhand&)

End Function

Function StripTerminator(ByVal strString As String) As String
    Dim intZeroPos As Integer

    intZeroPos = InStr(strString, Chr$(0))
    If intZeroPos > 0 Then
        StripTerminator = Left$(strString, intZeroPos - 1)
    Else
        StripTerminator = strString
    End If
End Function


Public Sub savestring(hkey As Long, strpath As String, strvalue As String, strdata As String)
    
    Dim keyhand&
    r = RegCreateKey(hkey, strpath, keyhand&)
    r = RegSetValueEx(keyhand&, strvalue, 0, REG_SZ, ByVal strdata, Len(strdata))
    r = RegCloseKey(keyhand&)

End Sub

Now here is what i have in the form load to see if it works.

Private Sub Form_Load()
savestring _
HKEY_LOCAL_MACHINE, "Software\Microsoft\Windows\CurrentVersion\Run", "test", "C:\test.exe"
Dim a
For a = 1 To 4
MsgBox "test"
Next
End Sub

IT creates a key in the registry but it does not load my form on boot up. The registry value also is not the same as the others. When I look at it in the registry files, it has a blue icon instead of a brown one.
Any ideas.

Thanks in advance..

[xmin]

There don¡¯t seem to be any problems in your code except that you have quoted too much redundant stuff that only helps confuse the reader while on the contrary something necessary seems missing to enable a full analysis of it. From you code I can¡¯t see any specific values assigned to ERROR_SUCCESS and REG_SZ, and that is exactly where your problem cropped up. I don¡¯t know whether or not you have assigned a value to them in some other place, but I can see from your report that the actual value was perhaps 3, for as you said your key icon was blue I can tell that you got a binary type (usually in blue) for that key. The default value or Microsoft set value for REG_SZ is 1 and not any other! This is a constant you can get from the API TextViewer. You shouldn¡¯t have changed its value and you should have quoted it from the Viewer in the Declare portion of your code (and the same with ERROR_SUCCESS which is the constant 0). Note: You can one of the set three types of value to a key in the registry. While REG_SZ (1) means a string ending in Null, the other two, REG_DWORD (4) refers to a double word and REG_BINARY (3) a binary.