Format("$#####0.00) FIGURED OUT

[twisted]

I am trying to get my grpTotalSales.Text and grpAverageSales.Text to display a dollar sign and then a money value. It works for my gross pay but it doesn't work for the others. Here is the code:

Private Sub btnGross_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnGross.Click
        ' name abbreviations
        SA = Val(nudSales.Text)
        SP = Val(grpSalespersons.Text)
        TS = Val(grpTotalSales.Text)
        ' Compute value and display in Gross Pay
        GP = BP + SA * CM
        txtGross.Text = Format(GP, "$#####0.00")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP + 1).ToString
        ' Compute value and display in Total Sales
        grpTotalSales.Text = (SA + TS).ToString
        grpTotalSales.Text = Format(TS, "$#####0.00")
        ' Compute value and display in Average Sales
        grpAverageSales.Text = Format("$#####0.00")
        If SP = 0 Then
            grpAverageSales.Text = (SA).ToString
        Else
            grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString
 
        End If
 
        
    End Sub

[taxes]

Hi,

Try, for example;

TextGross.Text = FormatCurrency(GP, 2)



By the way, if you are not previously updating SP at any time, your code:

If SP = 0 Then
grpAverageSales.Text = (SA).ToString
Else
grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString

End If

is unnecessary, as you can simply use

grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString

[techgnome]

grpTotalSales.Text = (SA + TS).ToString
grpTotalSales.Text = Format(TS, "$#####0.00")

You do realize line 2 will overwrite tesults from line 1?

TG

[twisted]

Originally posted by taxes
Hi,

Try, for example;

TextGross.Text = FormatCurrency(GP, 2)



By the way, if you are not previously updating SP at any time, your code:

If SP = 0 Then
grpAverageSales.Text = (SA).ToString
Else
grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString

End If

is unnecessary, as you can simply use

grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString

Nope didn't work!
I also tried this, but then it messes up my math.

grpTotalSales.Text = FormatCurrency((SA + TS), 2)

[twisted]

Originally posted by techgnome
grpTotalSales.Text = (SA + TS).ToString
grpTotalSales.Text = Format(TS, "$#####0.00")

You do realize line 2 will overwrite tesults from line 1?

TG

Actually NO I didn't because I am the true definition of a VB newb, but thanks for clarifying this to me. How would I get it to display the $ with my value. Say Format to look like this $567.65??

[Pirate]

Did you try something like this . This part (ToString("c")) converts the number to the default currency profile on the user system .

Dim int As Integer = 20 + 30
        Me.TextBox1.Text = int.ToString("c")

[techgnome]

so that would be like so:
grpTotalSales.Text = (SA + TS).ToString("c")

TG

[Pirate]

Originally posted by techgnome
so that would be like so:
grpTotalSales.Text = (SA + TS).ToString("c")

TG

hope it works ....

[twisted]

As soon as I add the ("c") to the end it doesn't add SA + TS anymore. It just displays the SA. I had exactly what your code looks like without the ("c") and it works, but as soon as I add the ("c") it doesn't.

[twisted]

This might help seeing my code:

Private Sub btnGross_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnGross.Click
        ' name abbreviations
        SA = Val(nudSales.Text)
        SP = Val(grpSalespersons.Text)
        TS = Val(grpTotalSales.Text)
        ' Compute value and display in Gross Pay
        GP = BP + SA * CM
        txtGross.Text = Format(GP, "$#####0.00")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP + 1).ToString
        ' Compute value and display in Total Sales
        grpTotalSales.Text = (SA + TS).ToString
 
        ' Compute value and display in Average Sales
        If SP = 0 Then
            grpAverageSales.Text = (SA).ToString
        Else
            grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString
 
        End If
 
        
    End Sub

[Pirate]

Originally posted by twisted
As soon as I add the ("c") to the end it doesn't add SA + TS anymore. It just displays the SA. I had exactly what your code looks like without the ("c") and it works, but as soon as I add the ("c") it doesn't.

Add the two numbers in an integer or decimal type depends on the number format you'll get . Then use the ToString like shown before .

[twisted]

Originally posted by Pirate
Add the two numbers in an integer or decimal type depends on the number format you'll get . Then use the ToString like shown before .

You lost me! I did however add the ("c") behind my AverageSales and it worked fine, just won't work with my TotalSales:

If SP = 0 Then
            grpAverageSales.Text = (SA).ToString("c")
        Else
            grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString("c")
 
        End If

[Pirate]

We both posted at the same time .

ToString("c") should be the last step and alone before assinging the total to the TextBox . So ,

If SP = 0 Then
            grpAverageSales.Text = (SA).ToString("c")
        Else
Dim T As Integer =((SA + TS) / (SP + 1))
            grpAverageSales.Text = T.ToString("c")
 
        End If

Try this

[twisted]

Now do you know why this doesn't work with this:

grpTotalSales.Text = (SA + TS).ToString("c")

It doesn't add for me if I add the "c"

[Pirate]

Originally posted by twisted
Now do you know why this doesn't work with this:

grpTotalSales.Text = (SA + TS).ToString("c")

It doesn't add for me if I add the "c"

It must be something wrong with your logic . It does work fine for me . Try to set breakpoints to see the values of SA and TS .

[taxes]

Hi twisted,

When you say

TextGross.Text = FormatCurrency(GP, 2)

does not work, what result do you get? I have tried it with various combinations of decimal places and it works fine every time.

From your other threads I assume that you declared GP as a Double.

I suppose the $ is your default currency?

You are using the 2003 version of .NET arn't you?

[taxes]

Originally posted by Pirate
It must be something wrong with your logic . It does work fine for me . Try to set breakpoints to see the values of SA and TS .

Works OK for me also.


twisted.

Just a thought. Did you begin this project in VB6 and then convert it to VB.NET?

[twisted]

Originally posted by taxes
Hi twisted,

When you say

TextGross.Text = FormatCurrency(GP, 2)

does not work, what result do you get?

I already got my txtGross.Text to work. I'm trying to get grpTotalSales.Text to do the same, but it won't.
It just doesn't do anything. My total sales still calculates fine, but it doesn't give me a $ sign or the money decimal places. For example: it shows up 800 instead of how I want it $800.00. Here is how my code looks:

Private Sub btnGross_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnGross.Click
        ' name abbreviations
        SA = Val(nudSales.Text)
        SP = Val(grpSalespersons.Text)
        TS = Val(grpTotalSales.Text)
        ' Compute value and display in Gross Pay
        GP = BP + SA * CM
        txtGross.Text = Format(GP, "c")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP + 1).ToString
        ' Compute value and display in Total Sales
        grpTotalSales.Text = FormatCurrency(TS, 2)
        grpTotalSales.Text = (SA + TS).ToString
        ' Compute value and display in Average Sales
        If SP = 0 Then
            grpAverageSales.Text = (SA).ToString("c")
        Else
            grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString("c")
 
        End If
 
        
    End Sub

[taxes]

Hi,

OK. What you are doing wrong in this case is

" grpTotalSales.Text = FormatCurrency(TS, 2)
grpTotalSales.Text = (SA + TS).ToString

"

The second line overwrites the first. What you want is the single line


grpTotalSales.Text=FormatCurrency(SA+TS, 2)


or

grpTotalSales.Text=(SA+TS).ToString("c")

or

grpTotalSales.Text = Format(SA+TS, "c")


For the future, I suggest you pick one method and stick to it.

[twisted]

Weird! As soon as I try either one of those my SA doesn't add to TS. It just simply display SA. When I leave it like this;

grpTotalSales.Text = (SA + TS).ToString

it works fine. But I can't have no currency and can't figure out why only the Total Sales won't allow me to do this:

grpTotalSales.Text = (SA + TS).ToString("c")

All the others work in my code, just not TotalSales:

Private Sub btnGross_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnGross.Click
        ' name abbreviations
        SA = Val(nudSales.Text)
        SP = Val(grpSalespersons.Text)
        TS = Val(grpTotalSales.Text)
        ' Compute value and display in Gross Pay
        GP = BP + SA * CM
        txtGross.Text = Format(GP, "c")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP + 1).ToString
        ' Compute value and display in Total Sales
        grpTotalSales.Text = (SA + TS).ToString
        ' Compute value and display in Average Sales
        If SP = 0 Then
            grpAverageSales.Text = (SA).ToString("c")
        Else
            grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString("c")
 
        End If
 
        
    End Sub

[techgnome]

grpTotalSales.Text = FormatCurrency(TS, 2)
grpTotalSales.Text = (SA + TS).ToString

You're duplicating the code again.....
grpTotalSales.Text = FormatCurrency(SA + TS)
One line that's it... what was happening was you were setting it right, then overwriting it....

TG

EDIT: Whoopse, never mind taxes beat me to it.

[twisted]

I know you guys are right and my code even looks right, but everytime I format TotalSales to show currency it doesn't add SA + TS anymore. It does display currency correct but only SA. Say if I enter 800.00 in SA then TS will display $800.00. Which is perfect, but when I enter a new value in SA, say 200.00 then I should get TS to be $1,000.00 but I'm getting the value of SA spit back at me $200.00. Before when I just have:

grpTotalSales.Text = (SA + TS).ToString

then it calculates fine, just doesn't have currency. WHICH I NEED!

It has to be something wrong somewhere in my code that is causing this to not work. I know I should be able to just add the "c" and be fine, like I did with the others. Here is my code and I will put in red where my problem is.

Option Strict On
Public Class frmGrossPayCalculator
    Inherits System.Windows.Forms.Form
    ' Assignment 2:     Gross Pay Calculator
    ' Programmer:       Brad von Oven
    ' Date:             June 11, 2004
    ' Purpose:          Create an application to display 
    '                   a salesperson’s gross pay with base 
    '                   and commission based on the following:  
    '                   Base pay is $500; commission is 6% of 
    '                   sales (use constants to represent these).  
    '                   The user enters the salesperson’s total sales; 
    '                   keep track of each salesperson’s sales and the 
    '                   number of salespersons.  Display the current 
    '                   person’s gross pay and the summary of:  
    '                   total salespersons, total amount of all sales, 
    '                   and average sales per salesperson.
 
    ' Set up constants for Base pay(BP) = $500 and commission(CM) is 6%
    Const BP As Double = 500.0
    Const CM As Double = 0.06
    ' Set up variables for sales, gross pay, salespersons, total sales, 
    ' and average sales.
    Dim SA, GP, SP, TS, AV As Double
 
    Private Sub btnExit_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnExit.Click
        End
    End Sub
 
    Private Sub btnGross_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnGross.Click
        ' name abbreviations
        SA = Val(nudSales.Text)
        SP = Val(grpSalespersons.Text)
        TS = Val(grpTotalSales.Text)
        ' Compute value and display in Gross Pay
        GP = BP + SA * CM
        txtGross.Text = Format(GP, "c")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP + 1).ToString
        ' Compute value and display in Total Sales
        [COLOR=red]grpTotalSales.Text = (SA + TS).ToString("c")[/COLOR]
        ' Compute value and display in Average Sales
        If SP = 0 Then
            grpAverageSales.Text = (SA).ToString("c")
        Else
            grpAverageSales.Text = ((SA + TS) / (SP + 1)).ToString("c")
 
        End If
 
        
    End Sub
 
    Private Sub btnReset_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnReset.Click
        nudSales.Text = "1.0"
        txtGross.Text = ""
        nudSales.Focus()
 
    End Sub
 
    Private Sub btnResetAll_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnResetAll.Click
        SA = 1.0
        txtGross.Text = ""
        grpSalespersons.Text = ""
        grpTotalSales.Text = ""
        grpAverageSales.Text = ""
        nudSales.Focus()
    End Sub
 
    Private Sub nudSales_LostFocus(ByVal sender As Object, ByVal e As System.EventArgs) Handles nudSales.LostFocus
        nudSales.Text = Format(nudSales.Value, "#,###.##")
 
    End Sub
End Class

Thanks for all the help guys!

[taxes]

HI,

OK. I've got it!!!!!


When you set the grpTotalSales.Text to include a currence sign, that means the result of val(grpTotalSales.Text will always be 0, because this expression gives the numerical value of all characters BEFORE the first non numerical character.


I am working on a way round this and will come back to you

[taxes]

Hi,

If you want to maintain the currency sign then you will have to us two form scope variables.

The following works:

In the General Section of the form

Dim SP, TS As Double

Then amend your code to

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        ' name abbreviations
        Dim CM As Double = 0.05
        Dim BP As Double = 3000
        Dim SA, GP As Double
        SP = SP + 1
        SA = Val(nudSales.Text)
        TS = TS + SA
        ' Compute value and display in Gross Pay
        GP = BP + TS * CM
        txtGross.Text = Format(GP, "c")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP).ToString
        ' Compute value and display in Total Sales
        grpTotalSales.Text = (TS).ToString("c")
        ' Compute value and display in Average Sales
        grpAverageSales.Text = (TS / SP).ToString("c")
 
 
 
    End Sub

That should get you there, but other people may have other solutions.

[twisted]

Worked awesome! But now I ran into a new problem with this. My Reset All value will reset everything blank which is good, but when I try to type new values in nudSales it retains all the old values and calculates using them. How do I get my Reset all to wipe out all the old values and start from scratch again! Here is what I did with my code:

Dim SA, GP, SP, TS As Double
 
 
    Private Sub btnExit_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnExit.Click
        End
    End Sub
 
    Private Sub btnGross_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnGross.Click
        ' name abbreviations
        SP = SP + 1
        SA = Val(nudSales.Text)
        TS = TS + SA
        ' Compute value and display in Gross Pay
        GP = BP + TS * CM
        txtGross.Text = Format(GP, "c")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP).ToString
        ' Compute value and display in Total Sales
        grpTotalSales.Text = (TS).ToString("c")
        ' Compute value and display in Average Sales
        grpAverageSales.Text = (TS / SP).ToString("c")
 
 
        
    End Sub
 
    Private Sub btnReset_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnReset.Click
        nudSales.Text = "1.0"
        txtGross.Text = ""
        nudSales.Focus()
 
    End Sub
 
    Private Sub btnResetAll_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnResetAll.Click
        SA = 1.0
        txtGross.Text = ""
        grpSalespersons.Text = ""
        grpTotalSales.Text = ""
        grpAverageSales.Text = ""
        nudSales.Focus()
    End Sub
 
    Private Sub nudSales_LostFocus(ByVal sender As Object, ByVal e As System.EventArgs) Handles nudSales.LostFocus
        nudSales.Text = Format(nudSales.Value, "#,###.##")
 
    End Sub
End Class

[techgnome]

You need to clear out the variable too, not just the text boxes.

TG

[twisted]

That's what I thought, so I tried to use:

SP = ""

but Option Strict is On so how would I write that??

[techgnome]

Since SP is a number, set it to 0.

SP = 0


TG

[twisted]

Originally posted by taxes
Hi,

If you want to maintain the currency sign then you will have to us two form scope variables.

The following works:

In the General Section of the form

Dim SP, TS As Double

Then amend your code to

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        ' name abbreviations
        Dim CM As Double = 0.05
        Dim BP As Double = 3000
        Dim SA, GP As Double
        SP = SP + 1
        SA = Val(nudSales.Text)
        TS = TS + SA
        ' Compute value and display in Gross Pay
        GP = BP + TS * CM
        txtGross.Text = Format(GP, "c")
        ' Compute value and display in Salespersons
        grpSalespersons.Text = (SP).ToString
        ' Compute value and display in Total Sales
        grpTotalSales.Text = (TS).ToString("c")
        ' Compute value and display in Average Sales
        grpAverageSales.Text = (TS / SP).ToString("c")
 
 
 
    End Sub

That should get you there, but other people may have other solutions.

You changed my GP formula! I was fliping out, thinking what Now? Anyway, I changed it back to GP = BP + SA * CM

Everything is absolutely perfect! This thread is finally closed. Thanks for all the help guys. More projects to come

[taxes]

Hi,

Sorry, I've taken a few hours off to play tennis.

"You changed my GP formula! I was fliping out, thinking what Now? Anyway, I changed it back to GP = BP + SA * CM"



Surely if you use SA instead of TS you are calculating your commission on your last sales entry only and not on your total sales.

I wonder if you have done something to upset it in your reset code.

your reset codes should be

Private Sub btnReset_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnReset.Click
        nudSales.Text = ""
        txtGross.Text = ""
        nudSales.Focus()
 
    End Sub
 
    Private Sub btnResetAll_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnResetAll.Click
        SP = 0
        TS = 0
        grpSalespersons.Text = ""
        grpTotalSales.Text = ""
        grpAverageSales.Text = ""
        btnReset.PerformClick()
    End Sub

You do not need to reset SA as that is done automatically in the Button_Click event.


Now you have got this far, note that the only box in which entries are made by the operator is the nudSales textbox. Therefore, All THE OTHER textboxes SHOULD be Labels. Otherwise the operator might make erroneous entries and defeat the program