Help me!!!!!!!!!

[xunxm]

I have a ComboBox control, I get the data from database and add it to the ComboBox like this:

With cboEmployee
    Do Until rs.EOF
        .AddItem rs.Fields("EmployeeName")
        .ItemData(.NewIndex) = rs.Fields("EmployeeID")
        rs.MoveNext
    Loop
End With

Now, I get one employee id from the database,I want to the cboEmployee display the name relating the id. I write the code like this(so foolish)

For intCount = 0 To cboEmployee.ListCount - 1
    If cboComboBox.ItemData(intCount) = intItemData Then
        cboComboBox.ListIndex = intCount
        Exit For
    End if
Next intCount

Who can help me improve the code, thanks in advance!!!

[mendhak]

Originally posted by xunxm
I have a ComboBox control, I get the data from database and add it to the ComboBox like this:

With cboEmployee
    Do Until rs.EOF
        .AddItem rs.Fields("EmployeeName")
        .ItemData(.NewIndex) = rs.Fields("EmployeeID")
        rs.MoveNext
    Loop
End With

Now, I get one employee id from the database,I want to the cboEmployee display the name relating the id. I write the code like this(so foolish)

For intCount = 0 To cboEmployee.ListCount - 1
    If cboComboBox.ItemData(intCount) = intItemData Then
        cboComboBox.ListIndex = intCount
        Exit For
    End if
Next intCount

Who can help me improve the code, thanks in advance!!!

I can't understand, what are you trying to accomplish with the second piece of code? Why are you assigning Indexes twice, or what is your aim here?

[Shaggy Hiker]

Mendhak is having a bad frog day.

You want to improve that code? In what way? Is it too slow? Does it offend your sensibilities? Does it work?

It seems pretty straightforward, you are manually filling a combobox, then setting the selected item. There may be some bound control solution that would save a step, but it wouldn't be better in my opinion. It might be simpler, and take less code, but I prefer to keep the control to myself.

[mendhak]

Originally posted by Shaggy Hiker
Mendhak is having a bad frog day.

I hope so

[chemicalNova]

Originally posted by Shaggy Hiker
Does it offend your sensibilities?[/B]

Larf


Phreak

[Shaggy Hiker]

That's legit. Sometimes code just doesn't feel right. That's when I start looking around for a different way to write it.

[xunxm]

Sorry, My english is poor, so.......
For Example:
Employees(Table)
ID Employee
1 Mike
2 John
6 Bob
8 Sue
...............
I use The first code to add data to ComboBox. In ItemData, I add the ID value, the List I add the EmployeeName value. When I choose a Employee in the ComboBox, I can get his ID.

But, I get a Employee's ID by another produre, when I get the ID, I want to the ComboBox can show the EmployeeName, So I have to use the second code. But I think it's so foolish, so I want to have another way to improve it. thanks!

[Shaggy Hiker]

See, it offends your sensibilities.

There may be a different way to do this, but I'm not sure that there is a better way. If it works, and it is fast enough for you, you might as well leave it alone. On the other hand, if it doesn't behave quite the way you want it to, that's a good reason to fix it, but it sounds like it is working fine for you.