it was working great till i tried to compile...

[fenster]

hi guys ..

this little bit of code worked great till i tried to compile it - now it bugs out on variable not defined...can any one help?

Private Sub CmdWriteCDGDIR_Click()
 
Set gorsgetkaraoke = New ADODB.Recordset
Set gorsgetkaraoke = goEnv.getkaraoke(goEnv.Cnn, CLng(songnum), Trim(singer), Trim(song), Trim(Path))
 
Open "C:\directory.txt" For Output As #1
gorsgetkaraoke.MoveFirst
While Not gorsgetkaraoke.EOF
    Print #1, gorsgetkaraoke!ID & Chr$(44) & Chr$(34) & gorsgetkaraoke!singer & Chr$(34) & Chr$(44) & Chr$(34) & gorsgetkaraoke!song&; Chr$(34) & Chr$(44) & Chr$(34) & 0 & Chr$(34) & Chr$(44) & Chr$(34) & gorsgetkaraoke!Path & Chr$(34) ' & Chr$(44) & Chr$(34) & "K" & Chr$(34)
    
    gorsgetkaraoke.MoveNext
Wend
Close
 
End Sub

bugs out on the below line at the clng (songnum) which is an autonumber..

goEnv.getkaraoke(goEnv.Cnn, CLng(songnum), Trim(singer), Trim(song), Trim(Path))

heres the sql statement :

Public Function getkaraoke(ByRef oCnn As ADODB.Connection, ByVal songnum As Long, ByVal singer As String, ByVal song As String, ByVal Path As String) As ADODB.Recordset
 
   On Error GoTo No_Bugs
    
    Dim oRs As ADODB.Recordset
    Dim ssql As String
    
    ssql = "SELECT *"
    ssql = ssql & " FROM"
    ssql = ssql & " sunfly"
   
 
    Set oRs = New ADODB.Recordset
    oRs.Open ssql, goEnv.Cnn, adOpenKeyset, adLockOptimistic, adCmdText
    Set getkaraoke = oRs
    Set oRs = Nothing
    Exit Function
 
    
No_Bugs:
    
    MsgBox Err.Number & " - " & Err.Description, vbOKOnly + vbInformation
 
End Function

this is total pants - it takes me all my time to write code that works then the compiler wastes it for me!

davie.

(i know its my fault somehow , but its nice to lay the blame somewhere else for a short while)

[Shawn N]

I'm guessing that an "autonumber" is a control. Use the control's value property, whatever that might be.

Like in a textbox, the value property is "Text". Try using that instead of an implicit variable.

[fenster]

shawn how do i find the controls value property?

[MartinLiss]

You should also always use Option Explicit.

[Shawn N]

fenster - what control are you using? Someone here would probably be able to tell you. I don't have access to VB so I'm not of much help in that area.

Martin - I'm assuming he is using OE since he's getting an error regarding a variable not being dimensioned. If he wasn't using OE the app would compile but not function.

[fenster]

i have this line in the modstartup.bas

Public gorsgetkaraoke As ADODB.Recordset

is this what u mean martin?

I also have sp5 - on windows xp - im sure my references i need are all enabled.


is there even a way to return it to its working state before i tried to compile it ?- that would be a decent solution for me

[Shawn N]

What is songnum? A control? A public variable?

Option Explicit is a command given to VB to not let you use any variables that have not been declared. This stops variable name typos when you're coding.

[fenster]

its an autonumber field in the db i changed it from ID just in case it was reserved..

it is a long integer (field size)

the code retrieves songnumber,singer,song and path of file then the next bit formats it the way i want and dumps to txt file.

[Shawn N]

There is no way this coding ever worked the way it is written.

First of all, Function getkaraoke asks for a list of parameters but they're never used. So you could change the protocall for Function getkaraoke from

Public Function getkaraoke(ByRef oCnn As ADODB.Connection, ByVal songnum As Long, ByVal singer As String, ByVal song As String, ByVal Path As String) As ADODB.Recordset

to

Public Function getkaraoke As ADODB.Recordset

THEN, since getkaraoke does not accept any parameters, you can change the way you call it from

Set gorsgetkaraoke = goEnv.getkaraoke(goEnv.Cnn, CLng(songnum), Trim(singer), Trim(song), Trim(Path))

to

Set gorsgetkaraoke = goEnv.getkaraoke

Try that.

[fenster]

shawn , ill try ur suggestions - maybe then it will compile..

i cant begin to understand ur knowledge of VB , and as i clearly state (check avatar for proof) im a total newbie.

but the code DID work.

and its working again.

i simply started a new project and copied/pasted all code into a new form/module and class module - basically replicating the project.

i can zip it up and stick it here if u want to see.

it would be good to have it an .exe but if not i can alter the code and run it across LAN (the folder i want is on another PC.)

Thanks for ur time - u 2 martin....

davie.

[Shawn N]

So you got your coding working without making any changes? That's different. I wouldn't mind looking at the project as a whole if it's not an issue. Just to see where I slipped up.

[fenster]

the code always worked - it stopped working after i tried to compile it.

i clearly stated that in my post.


v1. after compile - with the variable error

v2 after made new project ,copied code in,but no attempt to compile - so it works fine.


same code in both.



davie.

[fenster]

and the other.......

[MartinLiss]

projectv2 is missing mdStartup.bas and clsEnv.cls

[fenster]

sorry martin - u into this also

[fenster]

these files i alredy used for another project - there may be some dead code lying in them - the karaoke thing was a util to use once only - so it may be a bit messy ...