Why like this??

[MrNorth]

Im managing an application written by a consultant and I have come across a strange thing... on each class he is writing

Public Sub New()
       myDb = New clsDb
End Sub

where db is a database access layer class written by him
and when he is using the class objects he is using

dim db as clsDb

just creating a reference, not instanciating a new object


Can anyone give a decent explaination? I can't understand why?

why not just write

dim db as new clsDb

A class which anyway is refrerenced this often should have shared methods I think, don't you agree?????

kind regards
Henrik - strange things are happening....

[Edneeis]

I see no reason to initialize the variable in the constructor especially since New shouldn't be fired until the variable is in fact initialized anyway. Maybe its just some personal quirk.

As for it being shared or not I don't think that the frequency of use should determine whether or not it's shared. I think the determining factor for a shared method should be whether or not it relates to or needs an instance of the object in question to work or not. So if the method constantly refers to instance members or requires instance related resource (to check state) then it shouldn't be Shared. Although if you wanted it to then you could just pass in the instance in question. I guess it just depends on preference.

[MrNorth]

Thanks..

You are absolutly right about shared.. a thought glitch on my account...

I noticed that in the code I am working on (about 15 classes) that option strict was set to off, I turned it on(company policy) and looked at about 5 hours of extra work to correct things

* variables declared without type

* functions which doesn't return something (should be type)

* all different crazy types of cast errors object->string etc etc

* global variables that isn't needed

* References to Me where it doesn't make sense at all

* I checked how much this dude was payed, and it was a lot more than they pay me each month...


Henrik - hate digging into other peoples code when it looks like this

[taxes]

HI,

I thought that outside of instancing, referencing an object through a variable was used in subs which were accessed from several different locations, which required the same sequence of code, but relating to different instances of the same class( or even different classes in some circumstances). The same effect is, of course, achieved through passing parameters to a sub, but if several properties are involved, a reference is simpler.

Perhaps that is what the original programmer was thinking about.

[MrNorth]

I understand what you mean, but it doesn't make sense in this case... or

perhaps you are thinking about the Singleton GoF pattern. where you set the default contructor to private and write your own, like

GetInstance()

But for that to work (and be professional) you must first check if there already is an instance created (is the object nothing?) and the make it thread save by using a mutex object...

The author of the code Im working on has done nothing like that...

If you are thinking about any other programming technique im not aware of, perhaps some other forum member can response to this?


kind regards
Henrik

[VBCrazyCoder]

I don't think that I would have that consultant do any future work for your company.

[VBCrazyCoder]

Just a thought - maybe he was attempting to make it difficult to maintain so that your company would have to hire him / her back for any changes . Although I would hope that this is not the case, as it makes all consultants and programmers look bad.

[Merrion]

Public Shared Sub New()
       myDb = New clsDb
End Sub

This is a singleton constructor - it will be run only once for each class, not once for each instance as per a non-shared "new()".

Presumably all instances of the class share the same db connection object to reduce resource usage.

[MrNorth]

I had no idea about that... in every book I have read about patterns, the have never implemented it like that... okies


/henrik

[Edneeis]

Although the code he posted was not shared but an Instance method.

[MrNorth]

Oops, didn't notice that he had written a shared... then it might work as a singleton constructor, but in my example it should not...

kind regards
Henrik