how to format textbox?

[sillylady]

hi

i am having problem in formating textbox. i have set textbox dataformat to NUMBER. i add number entered in 3 textvoxes and display the total in 4th textbox. if the input in the textboxes are.....12,345,12,345,12,345 (addtion is done in textbox lost focus events). it displays the total in 4th textbox as only 36 instead of 37,035.

how can i solve the problem?

thanks

[Danial]

Post your code then we can understand you better. Did my solution here (http://www.vbforums.com/showthread.p...ghlight=danial) helped or you are looking for something different.

Danial

[MartinLiss]

I assume you are using Val. That won't work since it will truncate everything after the first non-number and in considers "," to be a non-number. Do this instead.

CDbl(Text1.Text) + CDbl(Text2.Text) + CDbl(Text2.Text)

[sillylady]

hi danial i have almost 100 textboxes and that was a tedious job to write the replace code for each n every textbox, that's why i removed the dataformat. but i know i think i should do it for end user. Any other easy way u can suggest me?


hi Martin

i had tried this before and i tried it again now, but i got an error (type mismatch) the moment i leave the 1st textbox. below are 2 codes which i tried.:

Private Sub totSHF()
txtFields(16).Text = CDbl(txtFields(5)) + CDbl(txtFields(6)) + CDbl(txtFields(7)) + CDbl(txtFields(8)) + CDbl(txtFields(9)) + CDbl(txtFields(10)) + CDbl(txtFields(11)) + CDbl(txtFields(12)) + CDbl(txtFields(13)) + CDbl(txtFields(14)) + CDbl(txtFields(15))
End Sub
------------------------------------------------------------------------
Private Sub totSHF()
CDBL(txtFields(16).Text) = CDbl(txtFields(5)) + CDbl(txtFields(6)) + CDbl(txtFields(7)) + CDbl(txtFields(8)) + CDbl(txtFields(9)) + CDbl(txtFields(10)) + CDbl(txtFields(11)) + CDbl(txtFields(12)) + CDbl(txtFields(13)) + CDbl(txtFields(14)) + CDbl(txtFields(15))
End Sub

[leinad31]

Type mismatch, one of your textboxes probably has invalid data (zero length string or non numeric)

Before you use those equations, validate your textbox.text replacing "" with zero.

[MartinLiss]

Originally posted by leinad31
Type mismatch, one of your textboxes probably has invalid data (zero length string or non numeric)

Before you use those equations, validate your textbox.text replacing "" with zero.

SillyLady: Did leinad31's suggestion work for you? It should work if you use the first of the two totSHF subs above. BTW, do you know about line continuations.

Private Sub totSHF()
txtFields(16).Text = CDbl(txtFields(5)) + CDbl(txtFields(6)) + CDbl(txtFields(7)) _
                   + CDbl(txtFields(8)) + CDbl(txtFields(9)) + CDbl(txtFields(10)) _
                   + CDbl(txtFields(11)) + CDbl(txtFields(12)) + CDbl(txtFields(13)) _
                   + CDbl(txtFields(14)) + CDbl(txtFields(15))
End Sub

[sillylady]

ok guys your suggestions seems to be working. my code add the numbers the moment each textbox loses the focus. problem is when i 1st textbox loses the focus the addition function called and it's taking the other blank textboxes also that's why it shows mismatch error. there may be a situation where user did not enter anything not even Zero in a textbox.
I tried the code to check if the user has input anything, if not then code will put Zero in a textbox. even this is not working. i am pasting code here:

Private Sub txtFields_LostFocus(Index As Integer)
 
If txtFields(Index).Text = "" Then
txtFields(Index).Text = 0
Exit Sub
Else
txtChange (Index)        ' This is the function to add numbers
End If
 
End Sub

[MartinLiss]

One way to fix the problem would be to set the value of each textbox to 0 in the form's Load event. It would be better however if you posted the txtChange sub (a very bad name BTW) so that I can see what you are doing.

[sillylady]

here is the code.

Private Sub txtChange(Index1 As Integer)
Select Case Index1
Case 5
    totSHF 
Case 6
    totSHF
Case 7
    totSHF
Case 8
    totSHF
Case 9
    totSHF
Case 10
    totSHF
Case 11
    totSHF
Case 12
    totSHF
Case 13
    totSHF
Case 14
    totSHF
Case 15
    totSHF
End Select
End Sub
 
Private Sub totSHF()
txtFields(16).Text = CDbl(txtFields(5)) + CDbl(txtFields(6)) + CDbl(txtFields(7)) + CDbl(txtFields(8)) + CDbl(txtFields(9)) + CDbl(txtFields(10)) + CDbl(txtFields(11)) + CDbl(txtFields(12)) + CDbl(txtFields(13)) + CDbl(txtFields(14)) + CDbl(txtFields(15))
End Sub

Martin i am very new to VB and silly also.

[veryjonny]

Private Sub totSHF()
txtFields(16).Text = 0 'Just added this line
    For i = 5 To 15
        If txtFields(i).Text <> "" Then
            txtFields(16).Text = CDbl(txtFields(16).Text + CDbl(txtFields(i).Text)) ' Change this line
        End If
    Next
End Sub
 
Private Sub Form_Load()
    For i = 5 To 15
        txtFields(i).Text = 0
    Next
End Sub
 
Private Sub txtFields_LostFocus(Index As Integer)
    Select Case Index
        Case 5 To 15
            totSHF
    End Select
 
End Sub

This helps?

[edit]See comments above[/edit]

[sillylady]

hi all thanks for the all the suggestions. i took the cue from johny example and made a simple change in my code. i displayed the Zero in all the text box when user click add and this is working so far, hope there will be no error any more.

thank u guys for all ur help.

[MartinLiss]

Let's talk about this sub for a minute.

Private Sub txtChange(Index1 As Integer)
Select Case Index1
Case 5
    totSHF 
Case 6
    totSHF
Case 7
    totSHF
Case 8
    totSHF
Case 9
    totSHF
Case 10
    totSHF
Case 11
    totSHF
Case 12
    totSHF
Case 13
    totSHF
Case 14
    totSHF
Case 15
    totSHF
End Select
End Sub

The reason I said it was a bad name is that you named it just like you would name a textbox and someone looking at your code would be very confused by your txtChange (Index) line. You did a good thing when you added the comment to that line. It would have been better however if you gave the sub some more standard name such as maybe GatherData.

The code in that sub is also unnecessarily long and you could change it to

Private Sub txtChange(Index1 As Integer)
Select Case Index1
Case 5 To 15
    totSHF 
End Select
End Sub

Having said all that, I need to point out that the sub really does nothing and is unnecessary. What you are currently doing is passing the index number of your txtFields control array to the txtChange sub. (You are not passing the data that in the particular txtFields, just the index to the txtFields field). Then no matter what the index number is, you are always doing the same thing and that is calling totSHF. So why not just call totSHF directly with this code.

Private Sub txtFields_LostFocus(Index As Integer)
 
    If txtFields(Index).Text = "" Then
        txtFields(Index).Text = 0
    Else
        totSHF
    End If
 
End Sub

Note the indentation and the removal of the unnecessary Exit Sub.

[veryjonny]

Then no matter what the index number is, you are always doing the same thing and that is calling totSHF. So why not just call totSHF directly with this code.

No Martin, shes checking if the Index No falls between 5 and 15 then shes calling that sub.

[MartinLiss]

Originally posted by veryjonny
No Martin, shes checking if the Index No falls between 5 and 15 then shes calling that sub.

Well her totSHF sub only adds textboxes 5 to 15, so if the index was less than 5 or more than 15 it would do nothing anyhow.

[sillylady]

hi all

Martin as i told you i am very new to VB that's why u see some silly mistakes. You are right to say that I should call the totSHF the way you have suggested. Actually there are many more function to be called at different textbox.

Anyways you guys have really help me alot in clearing my concept.

Thanks

[veryjonny]

Everyone makes mistake, no matter how experienced he/she is.

The best part is that we shd learn from our mistakes.

[biswajitdas]

simple codin in two line


Join all the textbox store in a string



then

textbox4.text = format(value,"@@,@@@,@@@@@")



simple slove in two line


hahahahahahahahahahhahahahahahhah