Filenames, Pathnames, Filenames.....

Whenever I am working with FileBoxes, I always have to use this bit of code. It makes sense but surely there is a quicker way or less code is required.

Private Sub cmdOpen_Click()
Dim Slash As String

Slash = "\"
If Right(fil.Path, 1) = "\" Then Slash = ""

ShellExecute Me.hwnd, "open", fil.Path & Slash & fil.FileName, "", fil.Path & Slash, 0
End Sub

The reason why I need to put this in (for those who are still wondering) is because fil.Path always gives the path without a '\' on the end, UNLESS it is the root directory (i.e. 'C:\'). So is there anyway to put a slash or dash or whatever on the end of a path and not put one there if there is already on there?

[kedaman]

Sub SetSlash(Text as string)
  if right$(Text,1)<>"\" then text = text & "\"
End sub

Oh, I didn't think of that (obviously).

Another thing, looking at your code I saw right$(). What does this do? And the following things...

Text1.Text = Right("asdfasdf", 1)
Text1.Text = Right$("asdfasdf", 1)

'And these ones:

Text1.Text = Chr(65)
Text1.Text = Chr$(65)

'And a lot of people are doing this:

Dim r As Long
r& = 20 * 2

I'm not that good at VB so I don't know what this does.

[HarryW]

Right returns a variant.
Right$ returns a string.

Same goes for Chr and Chr$.

I think you can write:

Dim r&

and it will declare r& as Long. I think it's called postfix notation or something like that. Variables ending in $ are strings, and ending in % are integers I think. I don't use it myself because it looks messy.

The Right function takes in a variant, whereas the Right$ takes in a string.

This means that Right$ is slightly faster as it doesn't have to cast the variant "String" parameter to a string data type before the requested string is returned.

This holds true for all functions where there is a $ and non-$ version (Left, Trim, Chr, Right etc.)

- gaffa

[Edited by gaffa on 11-08-2000 at 02:20 AM]