Function to ensure variables have same value or null

[Shaitan00]

Given 3 variables [var1, var2, var3], which represent the version [i.e.: 1, 2, 3, etc.] of each station.

I need a method/function to ensure that the version is the same in all stations that are reporting. So if the value [varX] is blank/null then do not count it in the comparisons, otherwise ensure all filled variables are the same.

I am looking for a way to check this without going threw case/select statements [first thing that comes to mind] for each possible case [when a variable is null].
Of course in reality there are 22 variables, which explains why I cannot do the trivial Case/Select for all possibilities of null variables.

Anyone have a better idea on how to code the pseudo-code above in VC#?

[Memnoch1207]

If there are 22 variables why not just use an array? And pass that array to a method and check if null or "" exists in the array subscripts.

[Shaitan00]

How would that help?

The goal is to confirm (boolean) if all reporting values are the same, I already have the 22 variables [i.e.: they cannot be replaced by an array].

So you suggest I populate an Array with the results from my 22 variable. Then how do I perform my checking function?

I need to ensure that all 22 Reporting variables are the same, if they are not reporting then they would be null.

[PT Exorcist]

if (var1 & var2 & var3 & ...... & var22 == true) {
TODO if TRUTH
} else
{
TODO if ELSE
}

[Lethal]

Try this:

static void Main(string[] args)
{
    string var1 = "1.1", var2 = null, var3 = "1.1", var4 = "";
    if (EnsureStations(new string[] {var1, var2, var3, var4}))
        Console.WriteLine("All stations are in sync");
    else
        Console.WriteLine("All stations are not in sync");
}

static bool EnsureStations(string[] versions) {
    string currentVersion = null;		
    foreach (string v in versions) {
        if (v != null && v != String.Empty) {
            if (currentVersion != null) {
	        if (v != currentVersion)
	            return false;
	    }
	    else {
	        currentVersion = v;
	    }
        }
    }
    return true;
}

[Shaitan00]

PT Exorcist:
That would not work, first of all the variables are int or strings, not boolean. And what about if one was null?


Lethal:
Great function, problem is I already have the 22 variables [as variables, not an array].

So is my best bet to populate an array from the string variables that already exists or is there a quicker way without the steps and memory required to create the temporary array?

[Lethal]

In my example, I am not storing my values in an array, just your typical variables. However, when I invoke the method, i create an array on the fly, which should be exactly what you need. This way, your code is much more maintainable, since you dont have a method receiving 20+ paramaters, not to mention, if you need to add another station in the future, you would not have to break your interface.

[sunburnt]

Lethal's method is good -- you could go one step further and have the function create the array for you by creating a function like:

bool IsGoodData(params string[] myStrings)
{
    for(int i = 0; i < myStrings.Length; i++)
         if (myStrings[i] == null) /* or whatever */ return false;

    return true;
}



if  (IsGoodData(string1, string2, somestring, strX)) ...

[Lethal]

Originally posted by sunburnt
Lethal's method is good -- you could go one step further and have the function create the array for you by creating a function like:

bool IsGoodData(params string[] myStrings)
{
    for(int i = 0; i < myStrings.Length; i++)
         if (myStrings[i] == null) /* or whatever */ return false;

    return true;
}



if  (IsGoodData(string1, string2, somestring, strX)) ...

Yeah, I thought about doing it that way, but figured either way will work fine.