What's wrong with this code? [Resolved]

[joe_h_31028]

Dim intPress As Integer, strPass As String, x As Boolean

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck() = True Then
intPress = MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
intPress = MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

Private Function PassCheck(strPass As String) As Boolean
PassCheck = False
If strPass = "loser" Then
PassCheck = True
End Function

[Cander]

Why dont you tell us what happens?

[CyberJar]

You're not passing anything (namely a string) to SUB PassCheck().

[joe_h_31028]

I get a compile error when the code gets to the PassCheck() function, it says "Argument not optional". I am practicing with functions, still learning of course, and I can't figure out why its not working.

[Cander]

CyberJar got it. But you will have another error too unless you close that If block with an End If in PassCheck

[joe_h_31028]

strPass is being passed to PassCheck as an argument, the the value of PassCheck is returned in the form of a boolean to be used in the click procedure.

At least thats what I thought I coded, what do you think?

[Cander]

no, its not what you coded

If PassCheck() = True Then

you didnt put in the arguement

[joe_h_31028]

So I have to have it like this :

PassCheck(strPass as string)

in both the calling and called procedures?

[RudyL]

You are getting that error because you are not filling the required vailables. note that you have declared this..

Private Function PassCheck(strPass As String) As Boolean
PassCheck = False
If strPass = "loser" Then
PassCheck = True
End Function

But only pass this..

if pass check() = true then

You need to either change you function to this

Private Function PassCheck(optional strPass As String) As Boolean

to allow for not using a variable when you call it or you need to supply a value to strPass then you call the function..

if PassCheck(X) = true then

Rudy

[Cander]

No. just strPass

[joe_h_31028]

Thanks guys, I believe I have it now.

I fixed the code as per your instructions, but for learning sake, is this the best way to code this? I just want to be sure I am coding the right way.
---------------------------------------------------------------------------------
Dim intPress As Integer, strPass As String, x As Boolean

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck(strPass) = True Then
intPress = MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
intPress = MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

Private Function PassCheck(strPass As String) As Boolean
PassCheck = False
If strPass = "loser" Then
PassCheck = True
End If
End Function
--------------------------------------------------------------------------------

[RudyL]

It looks ok from here. I would make one suggestion though..

If you are not going to do anything with the response from the message box I would change this:

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck(strPass) = True Then
intPress = MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
intPress = MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

to this:

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck(strPass) = True Then
call MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
call MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

No need to handle a variable if not necesary.. Understand?

Rudy

[Eras3r]

u were forgetting to pass the pw argument, and u forgot an 'end if' in ur passcheck func.

[joe_h_31028]

Got it guys, special thanks to RudyL and Cander for your help and advice. I guess now I can finally move to hour 14 lol