SQL / C# Question! *Resolved*

[toto]

Hello,

This is a snippet from my code, I do this several times! I was just wondering if anyone had a suggestion for a simpler way to do the following:

     case "address_map":
		RS = DB.Execute(myData.pService.SQL_ADDRESS_MAP_CHECK.Replace("%1", A[1]), out ob, -1);
		if (!RS.EOF)
		{
			Out_Data += "error ";
		}
		else
		{
			DB.Execute("insert into address_maps (Mail_Box_ID, Email, Status, Misc) Values('" + A[2] + "','" + A[3] + "','" + A[4] + "','" + A[5] + "')", out ob, -1);
			Out_Data += "good ";
		}
		Send(Out_Data + Environment.NewLine);
		break;

	case "domain":
		RS = DB.Execute("select domains.Domain_ID, domains.Domain, domains.Post_Office_ID, domains.Status, domains.Misc from domains where domains.Domain = '" + A[2] + "'", out ob, -1);
		if (!RS.EOF)
		{
			Out_Data += "error ";
		}
		else
		{
			DB.Execute(myData.pService.SQL_DOMAIN_CHECK.Replace("%1", A[2]).Replace("%2", A[3]).Replace("%3", A[4]).Replace("%4", A[5]), out ob, -1);
			Out_Data += "good ";
		}
		Send(Out_Data + Environment.NewLine);
		break;

Thank YOU!!!
Mitchel

[transio]

switch (Whatever) {
	case "address_map":
		RS = DB.Execute(myData.pService.SQL_ADDRESS_MAP_CHECK.Replace("%1", A[1]), out ob, -1);
		break;
	case "domain":
		RS = DB.Execute("select domains.Domain_ID, domains.Domain, domains.Post_Office_ID, domains.Status, domains.Misc from domains where domains.Domain = '" + A[2] + "'", out ob, -1);
		break;
}
if (!RS.EOF) {
	Out_Data += "error ";
} else {
	switch (Whatever) {
		case "address_map":
			DB.Execute("insert into address_maps (Mail_Box_ID, Email, Status, Misc) Values('" + A[2] + "','" + A[3] + "','" + A[4] + "','" + A[5] + "')", out ob, -1);
			break;
		case "domain":
			DB.Execute(myData.pService.SQL_DOMAIN_CHECK.Replace("%1", A[2]).Replace("%2", A[3]).Replace("%3", A[4]).Replace("%4", A[5]), out ob, -1);
			break;
	}
	Out_Data += "good ";
	Send(Out_Data + Environment.NewLine);
}

[transio]

Better yet, try something like this:

switch (Whatever) {
	case "address_map":
		selectCmd = myData.pService.SQL_ADDRESS_MAP_CHECK.Replace("%1", A[1]);
		insertCmd = "insert into address_maps (Mail_Box_ID, Email, Status, Misc) Values('" + A[2] + "','" + A[3] + "','" + A[4] + "','" + A[5] + "')";
		break;
	case "domain":
		selectCmd = "select domains.Domain_ID, domains.Domain, domains.Post_Office_ID, domains.Status, domains.Misc from domains where domains.Domain = '" + A[2] + "'";
		insertCmd = myData.pService.SQL_DOMAIN_CHECK.Replace("%1", A[2]).Replace("%2", A[3]).Replace("%3", A[4]).Replace("%4", A[5]);
		break;
}

RS = DB.Execute(selectCmd, out ob, -1);
if (!RS.EOF) {
	Out_Data += "error ";
} else {
	DB.Execute(selectCmd, out ob, -1);
	Out_Data += "good ";
}
Send(Out_Data + Environment.NewLine);

[toto]

Very cool, I like the second method, both are better though then mine. Thanks transio.

Thanks a lot,
Mitchel