Error checking

[brianh]

Does anybody see why this script would not work?

<script language="JavaScript">
function calc(form)
{
var perc;
perc = Number(perc);
perc = 0;
var inputFields = document.all.tags("INPUT");
for(i=0; i < inputFields.length; i++)
  {
	if(inputFields[i].value != "")
	{
		if(inputFields[i].name != 'locID')
		{}
		if(inputFields[i].name != 'locCode')
		{}
		if(inputFields[i].name != 'org')
		{}
		if(inputFields[i].name != 'region')
		{}
		if(inputFields[i].name != 'percVal')
		{}
		if(inputFields[i].name != 'addIT')
		{}
			if(isNaN(inputFields[i].value) == true)
				{
				alert("You have input something other than a number, please input numbers only!");
				return false;
				}
			else
				{
				var num;
				alert("HI");
				num = inpurFields[i].value;
				num = Number(num);
				perc = perc + num;
				}
		}
	}
	
if(perc < 100)
{
alert("The percentages are less than 100, please check your numbers and re-submit")
return false;
}
else if(perc > 100)
{
alert("The percentages are more than 100, please check your numbers and re-submit")
return false;
}
}

</script>

[CornedBee]

In what way does it not work?

var perc;
perc = Number(perc);
perc = 0;

is nonsense.

[brianh]

It does nothing at all. Why is that syntax nonsense?

[Travis G]

<script language="JavaScript">
    Function calc(form) {
        var perc;
        perc = Number(perc);
        perc = 0;
        var inputFields = document.all.tags("INPUT");
        for(i=0; i < inputFields.length; i++) {
            if(inputFields[i].value != "") {
                if(isNaN(inputFields[i].value) == true) {
                    alert("You have input something other than a number, please input numbers only!");
                    return false;
                }
                Else {
                    var num;
                    alert("HI");
                    num = inpurFields[i].value;
                    num = Number(num);
                    perc = perc + num;
                }
            }
        }
            
        if(perc < 100) {
            alert ("The percentages are less than 100, please check your numbers and re-submit")
            return false;
        }
        else if(perc > 100) {
            alert ("The percentages are more than 100, please check your numbers and re-submit")
            return false;
        }
    }
    
</script>

This code makes little sense. I highlighted a typo I found.

But it will step through each member of the inputFields array. For each inputField, it will throw an alert is the value is not a number. If the value is a number, it will add it to perc. I think JavaScript supports the =+ operator, by the way. Double check the documentation.

If perc is less than or greater than 100, then you get another alert after it has stepped through each member of inputField. Since perc is a local variable, it dies when the function ends.

There were a lot of if clauses that did absolutely nothing, so I deleted them.

So, what is this code not doing?

[CornedBee]

Originally posted by brianh
It does nothing at all. Why is that syntax nonsense?

1) It does something on three lines that would be more meaningful and easier to understand on one line.

2) The middle line is completly redundant. It really does nothing. You set a variable to the Number equivalent of its uninitialized (random) value. On the next line you set it to a number, changing the type to Number anyway.