Error opening/reading file??

[Guv]

The following code attempted to open and read a nonexistent file, but did not act the way I thought it would. The intent is to generate the file if it does not already exist. I expected the On Error to direct Control Flow to FileError, but the bolded MsgBox Statement executed.

On Error GoTo FileError
 
SuitFileNumber = FreeFile
Open File_Name For Binary Access Read Lock Write As SuitFileNumber
Get SuitFileNumber, 1, InputStamp
 
If InputStamp.ProjectName = FileStamp.ProjectName _
        And InputStamp.AuthorFirst = FileStamp.AuthorFirst _
        And InputStamp.AuthorLast = FileStamp.AuthorLast _
        And InputStamp.RecordCount = 512 Then
        'Fall through and read file'
    Else
        [b]Junk = MsgBox("File corrupted or not Suit Data File")[/b]
        Close SuitFileNumber
        ThereIsSuitData = False
        Exit Function
  End If
[b]. . . [/b]
FileError:
[b]. . .[/b]

The above code is in a Function. I have included only the code which seems pertinent. File_Name is passed to the Function as parameter and seems to be syntactically correct.

App.Path & "SuitData.qqq" was used, and Debug analysis indicated that it became the name of a nonexistent file.

I expected the Open to fail, causing Control Flow to go to FileError. The input area looks like uninitialized data, indicating that no I/O actually occurred.

Why did neither the Open nor the Get cause control flow to go to FileError?

BTW: Due to the way some mainframes react, I always supply a place for values returned from Functions. Hence: Junk = MsgBox.

[McGenius]

App.Path & "SuitData.qqq"
If that's what you use then change it to App.Path & "\SuitData.qqq"

[Guv]

McGenius: The BackSlash (\) was supplied as part of App.Path.

My problem is not the syntax. I do not understand why the On Error does not seem to function as expected. I expected it to cause control Flow to go to FileError due to the attempt to Open & Get from a nonexistent file.

[McGenius]

Hmm ...
First: App.Path does not supply last backslash unless you did
Second: what exactly are you expecting to fail ??? Error hanlder won't be triggered just because InputStamp.ProjectName <> FileStamp.ProjectName - it must be a real time error such "Invalid file name ..." or so to occur, otherwise it's an errorless flow.

[Mc Brain]

Originally posted by McGenius
Hmm ...
First: App.Path does not supply last backslash unless you did
Second: what exactly are you expecting to fail ??? Error hanlder won't be triggered just because InputStamp.ProjectName <> FileStamp.ProjectName - it must be a real time error such "Invalid file name ..." or so to occur, otherwise it's an errorless flow.

App.Path supplies the backslash if your app is loaded from the root of a drive.... and if it's loaded from a net folder ("\\computername\folder\")

[Mc Brain]

Here's some backup:

http://www.vbforums.com/showthread.p...hlight=apppath
http://www.vbforums.com/showthread.p...hlight=apppath

[crptcblade]

Guv...

Open File_Name For Binary Access Read Lock Write As SuitFileNumber

When a file is opened as Binary, Random, Append, or Output, the file is created if it doesn't already exist. An Open will only fail if the file is opened for Input. Since it is now a zero byte file, the Get attempt will have zero bytes to read, hence the uninitialized data area.

[McGenius]

Originally posted by Mc Brain
App.Path supplies the backslash if your app is loaded from the root of a drive.... and if it's loaded from a net folder ("\\computername\folder\")

That isn't always true.

[Mc Brain]

Save your project to the root of your hardrive and ask for the App.Path.

[McGenius]

For some reason, Mc Brain you're always looking at immediate result HOWEVER if you read my previous post one more time you'll see 2 words: isn't always ... VB's App object is very problematic and is known for years as very unstable one.

[Mc Brain]

I'm not saying you were wrong. But, if you try to run your app from a CD Drive (let's say D:), the App.Path would return the backslash. You have to code your app so that this slash won't "hurt" you.

Edit: f***n' smiles

[McGenius]

Originally posted by Mc Brain
... You have to code your app so that this slash won't "hurt" you.

Oh, that's outta question ...

[Guv]

CrptcBlade:Thanx!! You were correct: Open Binary created an empty file. The Get could read no data, but did not fail since the file existed.

This forum has yet to fail me.

BTW: It seems strange that Open for input would create a file instead of complaining about it being nonexistent.