Reading data from files [RESOLVED]

[Jareware]

I have a textfile a bit over 2 MB of size, and it takes painfully long to open it (almost 60 seconds). I'm using the following code to input the data:

Open App.path & "\index" For Input As #FF
        Do
            Line Input #FF, inputString ' Read a line
            wholeLog = wholeLog & inputString & vbNewLine ' Append newly read line
        Loop Until EOF(FF)
    Close #FF

Is there some faster method of reading the data from the file?


-JR-

[Blobby]

It will be the append command thats slowing it down not the read. I have a program that reads all lines in text files and its like lightning. Comment out the append line and see how fast it is then

[Jareware]

What would be the fastest way to store the entire file in a string-variable then? I am myself writing a file searching application, and the file I'm opening is an index of some 600 word documents (that have been parsed and useful data from them has been extracted and stored in XML in the index file).

Thank you for your interest in my problem - my project is not making much progress while it takes a minute for the program to load!


-JR-

[Cyberius]

try using binary mode so you can read the whole file into one string without loops, use something like this:

Open "file.dat" for Binary As #1
Dim FileData As String * LOF(1)
Get #1, , FileData
Close #1

that should dump the whole file into the string

[Blobby]

Yes i agree. Apening for Binary access reads the whole file in in one go whereas opening for Input allows u to read line by line (each line terminated by a newline).

reading the whole file is faster in Binary mode but then you have the problems of finding the things u want from this huge file.

[Jareware]

Cyberius: The code you posted gives me a compile error (expected: end of statement) on the Dim-line. I have never played around with binary access to files, so what could be wrong?

Blobby: I have already made an xml-parsing engine that takes care of that and it works perfectly, so that is not an issue.

So how do I input the entire file into a variable using binary access?


-JR-

[Cyberius]

Originally posted by Jareware What would be the fastest way to store the entire file in a string-variable then?

i was just answering the question

[Cyberius]

my mistake...try this, it should work now

Open "file.dat" for Binary As #1
Dim FileSize As Long
FileSize = LOF(1)
Dim FileData As String * FileSize
Get #1, , FileData
Close #1

[Blobby]

In Cyberius's post the entire file will be in the variable 'Filedata' which should be dimmed as a string

[Jareware]

Still gives me a compile error, now "Constant expression required", on the same line still.


-JR-

[macai]

Dim x As String
Open "C:\somefile.txt" For Input As #1
x = Input(LOF(1), 1)
Close #1

There!

[Cyberius]

i DID dim it as a string

[Jareware]

Thank you very much, got it working now, and it's fast as a breeze!


-JR-

[Cyberius]

that what i get for not actually trying the code, lol....someone else comes in and steals the glory

[Blobby]

hehehe Cyberius so u did! Im going code blind,....must be this snow we are having

[Cyberius]

snow...hehe.....i wish.....take a look at my location....hot and humid summer

[Blobby]

yes indeedee, bitterly cold here. As this post is now finished and the authors buggered off.....fancy a pint?

[Cyberius]

dont mind if i do

[Cyberius]

well isnt that a coincidence, your 'hollow-headed-homer' logo is the same themed image i have on my WinXP logon screen...this can only mean one thing...great, yet incredibly small minds think alike

[Blobby]

hehehe Yeas but ive got a bigger head than you cos my brain is smaller than yours....so there!

[Blobby]

..........and its your round..........

[Cyberius]

right you are.....*buys a round of drinks*
i think we've officially made this a 'Chit Chat' thread now lol.....or more to a point, a thread about big heads and small brains