FileSize?????

[kanejone]

I got this code as a reply to a previous thread. It's to take file names into an array and then compare the size of the old file to the size of the copied file in a diferent folder(The copying is done in another sub). I just can't seem to get it working. The files won't delete. Your help is greatlty appreciated.

'thanks to kedaman for the original code
Sub EnumDir(ByRef edir() As String, path As String)
Dim n As Integer, a As String
 a = Dir(path)
 Do While Len(a)
   ReDim Preserve edir(n)
   edir(n) = a
   n = n + 1
   a = Dir
  Loop
End Sub

Sub SizeChecking()
Dim olddir() As String, newdir() As String
Dim FSO As Object
Set FSO = CreateObject("Scripting.FileSystemObject")
Dim n As Integer, a As String
  EnumDir olddir(), "C:\TestOrator\Outgone\*.txt"
  EnumDir newdir(), MyNewDir
  For n = 0 To UBound(olddir)
    If FileLen(olddir(n)) = FileLen(newdir(n)) Then
      'files are the same size
      MsgBox "files are the same size"
      FSO.DeleteFile "C:\TestOrator\Outgone\*.txt"
      Else
      'files are not the same size
      MsgBox "The Files that were transferred were not the same size."
    End If
  Next n
End Sub

Thanks

[Edited by kanejone on 09-15-2000 at 10:28 AM]

[kedaman]

Actually i don't know how, you're using FSO (i'm not too familiar with it but vb has it's own command "Kill" and you'll get an error when you can't delete files with it.

BTW, this should be the 80000'th post on this forum

[kanejone]

Thanks for the reply kedaman. Even when I'm not using the FSO I can't even get the message box to appear. I'm wondering if it is possible to use the directory path in this way :EnumDir olddir(), "C:\TestOrator\Outgone\*.txt".

Thanks for your time
JK

Sub SizeChecking()
Dim olddir() As String, newdir() As String
Dim n As Integer, a As String
  EnumDir olddir(), "C:\TestOrator\Outgone\*.txt"
  EnumDir newdir(), MyNewDir
  For n = 0 To UBound(olddir)
    If FileLen(olddir(n)) = FileLen(newdir(n)) Then
      'files are the same size
      MsgBox "I can't get this message box to appear, any ideas"
      Else
      'files are not the same size
      MsgBox "The Files that were transferred were not the same size."
    End If
  Next n

[kedaman]

of course it works, that's what dir function is for.
try put a break on the if line and check out the values you get, if it doesn't break at all it's probably because there aren't any txt files in outgone, or also (and have you tested my Enumdir function enough?) there might be something wrong with enumdir, i didn't have access to vb when i wrote it

[kanejone]

Sorry kedaman. I've only been at VB for three weeks now. How do I use dir??? Sorry if it's a stupid question

[kedaman]

nono, my apologies, you probably don't know how to use kill either...
Enumdir takes care of dir, you just run my code instead, and tell me what you get in immediate window
just copy and paste it here

Sub EnumDir(ByRef edir() As String, path As String)
Dim n As Integer, a As String
 a = Dir(path)
 Do While Len(a)
   ReDim Preserve edir(n)
   edir(n) = a
   n = n + 1
   a = Dir
  Loop
End Sub

Sub SizeChecking()
Dim olddir() As String, newdir() As String
Dim FSO As Object
Set FSO = CreateObject("Scripting.FileSystemObject")
Dim n As Integer, a As String
  EnumDir olddir(), "C:\TestOrator\Outgone\*.txt"
  EnumDir newdir(), MyNewDir
  debug.print "files:" & Ubound(olddir) & "," & Ubound(newdir)
  For n = 0 To UBound(olddir)
    debug.print olddir(n) & " , " & newdir(n)
    debug.print filelen(olddir(n)) & " , " & filelen(newdir(n))
    If FileLen(olddir(n)) = FileLen(newdir(n)) Then
      'files are the same size
      MsgBox "files are the same size"
      FSO.DeleteFile "C:\TestOrator\Outgone\*.txt"
      Else
      'files are not the same size
      MsgBox "The Files that were transferred were not the same size."
    End If
  Next n
End Sub

[kanejone]

Thanks again for taking the time.
Here's what the immediate window has

files:19,91
New Text Document (10).txt , ADDSCCUS.DLL

[kedaman]

You current directory is probably not C:\TestOrator\Outgone so i guess you don't get the filesize at all, but did you get any error anyhow?

You should replace

If FileLen(olddir(n)) = FileLen(newdir(n)) Then

with

If FileLen("C:\TestOrator\Outgone\*.txt"
 & olddir(n)) = FileLen(mynewdir & newdir(n)) Then

note mynewdir should end with \ or you would have to add it in between

[Joacim Andersson]

Kedaman made a slight typo in his last reply.
This is the correct code:

If FileLen("C:\TestOrator\Outgone\"
 & olddir(n)) = FileLen(mynewdir & newdir(n)) Then

Good luck!

[kanejone]

Sorry I really must be wrecking your head at this stage. I really do appreciate it though. Here's my code in total so you can see what exactly I am trying to do. I still can't manage to delete the files from the outgone folder. Sorry about this

'added a public var for dirname
Public MyNewDir As String
Option Explicit

Private Function MakeFolder(newdir As String)

    Dim dirname As String
    dirname = "C:\TestOrator\"
    newdir = dirname & newdir
    
    ChDir dirname
      If Dir(newdir, vbDirectory) <> "" Then
        MsgBox "The Archiving Process has been started already.  Please check the Correct folder to make sure."
      Else
        
    MkDir newdir
    MyNewDir = newdir
       End If

End Function

Private Sub Archive_Click()
    Dim today As String
    today = Format(Now, "dd mmmm yyyy")
    MakeFolder (today)

Call CopyA
End Sub



Sub EnumDir(ByRef edir() As String, path As String)
Dim n As Integer, a As String
 a = Dir(path)
 Do While Len(a)
   ReDim Preserve edir(n)
   edir(n) = a
   n = n + 1
   a = Dir
  Loop
End Sub

Sub SizeChecking()
Dim olddir() As String, newdir() As String
Dim FSO As Object
Set FSO = CreateObject("Scripting.FileSystemObject")
Dim n As Integer, a As String
  EnumDir olddir(), "C:\TestOrator\Outgone\*.txt"
  EnumDir newdir(), MyNewDir
  Debug.Print "files:" & UBound(olddir) & "," & UBound(newdir)
  For n = 0 To UBound(olddir)
    Debug.Print olddir(n) & " , " & newdir(n)
    Debug.Print FileLen(olddir(n)) & " , " & FileLen(newdir(n))
    If FileLen("C:\TestOrator\Outgone\" & olddir(n)) = FileLen(MyNewDir & newdir(n)) Then
      'files are the same size
      MsgBox "files are the same size"
      FSO.DeleteFile "C:\TestOrator\Outgone\*.txt"
      Else
      'files are not the same size
      MsgBox "The Files that were transferred were not the same size."
    End If
  Next n
End Sub


Public Sub CopyA()

    Dim today As String
    Dim FSO As Object
    On Error GoTo NOFSO
    Set FSO = CreateObject("Scripting.FileSystemObject")
    today = Format(Now, "dd mmmm yyyy")
    On Error Resume Next
    FSO.CopyFile "C:\TestOrator\Outgone\*.txt", MyNewDir, True
    Call SizeChecking
    'instead of just deleting the files here I want to check that the contents
    'of the copied file is the same size as the contents of the original files
    FSO.CopyFile "C:\TestOrator\Outgone\*.doc", MyNewDir, True
    FSO.DeleteFile "C:\TestOrator\Outgone\*.doc"
    FSO.CopyFile "C:\TestOrator\Outgone\*.exe", MyNewDir, True
    FSO.DeleteFile "C:\TestOrator\Outgone\*.exe"
    MsgBox "The files have been Successfully transferred"
    Set FSO = Nothing
    Exit Sub
NOFSO:
    MsgBox "FSO CreateObject Failed, Copying of files"

End Sub

[reeset]

Just thought I would chime in. The problem seems to be that the FSO object doesn't know what file to delete. In the SizeChecking function, changed the FSO.DeleteFile to this:

Sub SizeChecking()
Dim olddir() As String, newdir() As String
Dim FSO As Object
Set FSO = CreateObject("Scripting.FileSystemObject")
Dim n As Integer, a As String
  EnumDir olddir(), "C:\TestOrator\Outgone\*.txt"
  EnumDir newdir(), MyNewDir
  Debug.Print "files:" & UBound(olddir) & "," & UBound(newdir)
  For n = 0 To UBound(olddir)
    Debug.Print olddir(n) & " , " & newdir(n)
    Debug.Print FileLen(olddir(n)) & " , " & FileLen(newdir(n))
    If FileLen("C:\TestOrator\Outgone\" & olddir(n)) = FileLen(MyNewDir & newdir(n)) Then
      'files are the same size
      MsgBox "files are the same size"
      FSO.DeleteFile "C:\TestOrator\Outgone\" & olddir(n)
      Else
      'files are not the same size
      MsgBox "The Files that were transferred were not the same size."
    End If
  Next n
End Sub

Hope this helps.

[kedaman]

Or maybe you just could leave the FSO out and have one less reference in your project

Sub SizeChecking()
Dim olddir() As String, newdir() As String
Dim n As Integer, a As String
  EnumDir olddir(), "C:\TestOrator\Outgone\*.txt"
  EnumDir newdir(), MyNewDir
  For n = 0 To UBound(olddir)
    If FileLen("C:\TestOrator\Outgone\" & olddir(n)) = FileLen(MyNewDir & newdir(n)) Then
      'files are the same size
      MsgBox "files are the same size"
      Kill "C:\TestOrator\Outgone\" & olddir(n)
      Else
      'files are not the same size
      MsgBox "The Files that were transferred were not the same size."
    End If
  Next n
End Sub

[Joacim Andersson]

Even if it's actually has been stated before in this thread I would like to ******** it.
The Dir statement only returns the file name and not the path.
Consider the following statement:

Dim sFileName As String
sFileName = Dir("C:\OneDirectory\AnAnotherOne\TheFile.txt")

If the above file exist sFileName would be TheFile.txt and NOT C:\OneDirectory\AnAnotherOne\TheFile.txt