URGENT: What is wrong with my counter?>??!??

[MoMad]

I have a counter which keeps track of how many times a page has been visited today and how much total. For some reason, my counters keep reseting... im pretty sure my code is good, but maybe its not? Can anyone please see if my code has a problem??

function CountPage ($pg) {
    global $db;
    $db->query ("SELECT * FROM counters WHERE page='$pg'");
    if ($db->fetchRow ()) {
        // Update the count
        $curtodaycount = intval($db->record["todaycount"]);
        $curtotalcount = intval($db->record["totalcount"]);
        
        // change the date here
        $todaydate = $db->record["todaydate"];
        $curtotalcount ++;
        if ($todaydate == date("Y-m-d")) {
            $curtodaycount ++;
        }
        else {
            $todaydate = date("Y-m-d");
            $curtodaycount = 0;
            
            // Reset all counters to 0
            $db->query("UPDATE counters SET todaydate='$todaydate', todaycount='0'");
        }
        
        // Now update the count
        $db->query("UPDATE counters SET todaydate='$todaydate', todaycount='$curtodaycount', totalcount='$curtotalcount' WHERE page='$pg'");
    }
    else {
        // Create a new record
        $curtodaycount = 1;
        $curtotalcount = 1;
        $todaydate = date("Y-m-d");
        
        // Insert
        $db->query("INSERT INTO counters (page,todaydate,todaycount,totalcount) VALUES('$pg','$todaydate','$curtodaycount','$curtotalcount')");
    }
    $db->showErrors ();
} 

I have no idea whats going on...

[The Hobo]

did you debug all the IFs to make sure it was returning true where it should have and all that jazz?

It's probably some really small error, but those are always the hardest to find.

[MoMad]

It worked fine before, it suddenly stopped working (i dont kno what i did wrong)

[Aaron Young]

Shouldn't this

// Reset all counters to 0
$db->query("UPDATE counters SET todaydate='$todaydate', todaycount='0'");

Include a WHERE clause for the Page being referenced?

[MoMad]

I only have two if/else's one of them (I Know it works), is the $db->fetchRow() which just updates the db->records[] array on the record and the next one:

if ($todaydate == date("Y-m-d")) { 

This always worked and infact to be sure i made a simple script to test it and it worked!

Aaron Young: I didnt use WHERE because I want it to reset ALL the counters to 0 at the end of the day.

I have a table like this:

	Page:		Today:		Total:
----------------------------------------------
 Home			91		2523
 Contact Us		23		126
 Search			32		632
 ...

And for some reason at around 6pm, the counters mysteriously reset... i dont know whats going on, but my code looks fine right? I mean it worked the other days...

[phpman]

if it keeps reseting

if ($todaydate == date("Y-m-d")) { then apparently this is never true
$curtodaycount ++;
}
else {
$todaydate = date("Y-m-d");
$curtodaycount = 0;

// Reset all counters to 0
$db->query("UPDATE counters SET todaydate='$todaydate', todaycount='0'");
}

[MoMad]

Let me rephrase that, and i have some reason to think that this is server related (maybe either the server or mysql have the wrong time)...

Its supposed to reset at MIDNIGHT, any other time, its supposed to increment. But for some weird reason it resets at some awkward times! I verified that my code isnt the problem, but maybe the mysql or the unix machine! I am now contacting the admin and trying to get things to work out.

Thanks everyone for your quick responses! I really appreciate it!

[The Hobo]

Originally posted by MoMad
Let me rephrase that, and i have some reason to think that this is server related (maybe either the server or mysql have the wrong time)...

Its supposed to reset at MIDNIGHT, any other time, its supposed to increment. But for some weird reason it resets at some awkward times! I verified that my code isnt the problem, but maybe the mysql or the unix machine! I am now contacting the admin and trying to get things to work out.

Thanks everyone for your quick responses! I really appreciate it!

Yeah, I'm sure.

[phpman]

yeah when my code doesn't work I always blame it on the server.

[wpearsall]

Good idea

LOL

[MoMad]

Its FIXED!! PHP returns in GMT time so I just made a custom function that will convert date() to date() - 7hours

[The Hobo]

Originally posted by MoMad
Its FIXED!! PHP returns in GMT time so I just made a custom function that will convert date() to date() - 7hours

It took you this long to fix it?

The first thing I would have done would be to check the server's timezone just be echoing the date...

[MoMad]

why didnt i think of that?