Can this be optimize

[sebs]

Hello, i did a script that shuffle number from 0 to 7,
just need to know if it can be optimize

Randomize
 
Dim rndArr(), tmp, isOk, x
 
x = 0
ReDim rndArr(x)
 
Do Until x = 8
    tmp = CInt(Rnd() * 7)
    isOk = True
    For y = 0 To x - 1
        If rndArr(y) = tmp Then
            isOk = False
            Exit For
        End If
    Next
    If isOk = True Then
        rndArr(x) = tmp
        x = x + 1
        ReDim Preserve rndArr(x)
    End If
Loop

[ccoder]

Yes!

Type cast all of your variables. isOk is boolean; rndArr(), tmp, x and y are integers. Numeric variants use 16 bytes of memory, integers and booleans use 2. Then there is the overhead required to manipulate them.

Since you know rndArr will have 8 elements, Dim it as such and stop ReDimming. ReDim also has a lot of overhead.

[Cander]

you cant type cast in vbscript ccoder. eveything is a variant in vbscript.

[sebs]

2 thing, first of all it's asp, so there's no

Dim x As Integer

your right about the 2nd thing, it's because at first
i was looping thru the rndArr, but i change my code and
now it would be ok!!so here's the changes

Randomize
 
Dim rndArr(7), tmp, isOk, x
 
x = 0
Do Until x = 8
    tmp = CInt(Rnd() * 7)
    isOk = True
    For y = 0 To x - 1
        If rndArr(y) = tmp Then
            isOk = False
            Exit For
        End If
    Next
    If isOk Then
        rndArr(x) = tmp
        x = x + 1
    End If
Loop

[ccoder]

Originally posted by Cander
you cant type cast in vbscript ccoder. eveything is a variant in vbscript.

D'oh! I see that now Guess I read the post too fast.