Annoying loop is stuck!

[Petergotchi]

Private Sub LstSites_Click()
If checkfile("links.txt") = True Then
Open "links.txt" For Input As #1
    While Not EOF(1)
        Line Input #1, strleesin
        If Not strleesin = "" Then
                If InStr(1, strleesin, ",") = True Then 'Categorie gevonden
                    strtemp1 = Split(strleesin, " , ")(0)
                    strtemp2 = Split(strleesin, " , ")(1)
                        If strtemp1 = LstSites.Text Then
                            LstSites.Text = strtemp1
                            LstCat.Text = strtemp2
                        End If
                Else 'Geen categorie gevonden
                    strtemp1 = strleesin
                    strtemp2 = ""
                        If strtemp1 = LstSites.Text Then
                            LstSites.Text = strtemp1
                            LstCat.Refresh
                        End If
                End If
        End If
    Wend
Close #1
End If
End Sub

Can somebody explain why he also loops the opening of the file en the filecheck procedure? It crashes and says: File already open. That's because something loops my whole sub again! I don't know how!

[nemaroller]

what line is the program stoppin at?

[Petergotchi]

The open file procedure!

[Bonker Gudd]

Changing the value probably fires the Click event.

Put something like this around all the code in your procedure:

If Not m_blnClick Then
    m_blnClick = True
 
...
 
    m_blnClick = False
End If

m_blnClick is a module level variable.

[D12Bit]

Try this...

Private Sub LstSites_Click()
Dim MyFileNumber as Integer
If checkfile("links.txt") = True Then
MyFileNumber = FreeFile
Open "links.txt" For Input As #MyFileNumber
    While Not EOF(MyFileNumber)
        Line Input #MyFileNumber, strleesin
        If Not strleesin = "" Then
                If InStr(1, strleesin, ",") = True Then 'Categorie gevonden
                    strtemp1 = Split(strleesin, " , ")(0)
                    strtemp2 = Split(strleesin, " , ")(1)
                        If strtemp1 = LstSites.Text Then
                            LstSites.Text = strtemp1
                            LstCat.Text = strtemp2
                        End If
                Else 'Geen categorie gevonden
                    strtemp1 = strleesin
                    strtemp2 = ""
                        If strtemp1 = LstSites.Text Then
                            LstSites.Text = strtemp1
                            LstCat.Refresh
                        End If
                End If
        End If
    Wend
Close #MyFileNumber
End If
End Sub

I put there the FreeFile instruction so you'll get the next file handle available...Good luck!

[Petergotchi]

By changing the list text it indeed triggered the click event! Thx for all the help!

Greetz Pierre

[Joey_k29]

Did you try to debug your application stepping one line at a time? If you did you would have seen that when it changed the text that it did not finish the routine and started the click routine over again. Stepping one line at a time can be very helpful in debugging your application. Hope that'll help you in the future.

Joe

[Ultimasnake]

i think the bug is just in Open "links.txt" For Input As #1
doesnt it always need a full path and drivename etc etc?

try this:

Filename = app.path &"\links.txt"
Open filename For Input As #1

[Joey_k29]

No snake, the loop is the result of changing the text. The textfile automatically opens the file in the current directory if none is specified.

Joe

P.S. I hate using App.Path. There is one major problem with it; if your application is not run from the root of a drive then the App.Path has no '\', but if it is run from the root it contains the '\' which means any code written App.Path + "\myfile" fails when run from the root. I always declare a public variable called AppPath that always contains the '\' at the end.