atoi is screwy

[nabeels786]

i have 27015 in a string, and i do atio, i get 325041



port = atoi((LPCSTR)servern.Right(servern.GetLength() - servern.Find(':') - 1));

[parksie]

27015...isn't that Half-Life?

What's the code around it?

[nabeels786]

yeah im querying a half life server.

char *buf = new char[6];
	
	if(servern.Find(':') != -1) {
		port = atoi((LPCSTR)servern.Right(servern.GetLength() - servern.Find(':') - 1));
	}
	else port=27015;

	MessageBox(itoa(port,buffer,6),"port");

	return false;
	//get the IP
	servern = (servern.Find(':') != -1)  ? servern.Left(servern.Find(':')) : servern;

	if(sock.Create((int)port, SOCK_DGRAM) == 0) return false;	//create the socket
	if(sock.Connect(servern,port) == 0) return false;									//connect
	Sleep(200);

	strcpy(send,"ÿÿÿÿinfo\x00");
	sock.Send(send,strlen(send));

	sock.Receive(buffer,5);
	MessageBox("5","5");

	char *ret=new char[];
	bool done=false;
	char *tmp=new char[1];

	for(int i=0;i<12;i++){
		while(!done){	
			sock.Receive(tmp,1);
			if(tmp=='\x00'){ done=true; } 
			else{ serverinfo[i]+=tmp; }
		}	
		MessageBox((LPCSTR)serverinfo[i],(LPCSTR)serverinfo[i]);
		done=false;
	}

	return true;

im returning false after i get the port because i wanna make sure i get teh port right, its just for debug. the code isnt complete either

im using cstring until it all works, then ill use char*

thanks

[parksie]

const char *sn = "host.domain.com:27000";
const char *iter = sn;

while(iter++) {
    if(*iter == ':') {
        break;
    }
}

if(*iter) {
    port = atoi(iter);
}

...something like that might work if you wanted to use the C style strings

[nabeels786]

yeah i wanna convert it to c-style.

so i guess atoi doesnt work on cstring?

and that code just loops through it until it reaches the : character...so i guess ihave to fill it in?

[parksie]

Well, if it comes out of the loop with a value of ':' then you can send it to atoi. Actually, that code's wrong -- you need to add 1 to the pointer to get the port number (although you might need to verify a little more, like there actually is a port there).

If it comes out with NULL then it reached the end without finding ':' and you can put 27015 in.

[nabeels786]

yeah thats why i had the find there.
so itll loop through, and i guess toss out the characters until it reachs the :?

[parksie]

No, it doesn't change the pointer to the start, it uses a second pointer to traverse the string, since atoi doesn't care where in the string it starts.

[nabeels786]

oh i see now

[nabeels786]

	const char *iter = server_name;
	while(iter++) {
		if(*iter == ':') {
			*iter++;
			break;
		}
	}
	if(*iter) {
		port = atoi(iter);
	} else{
		port = 27015;
	}

atoi still gives me 325041

[parksie]

*iter++;

That can just be ++iter;.

Can't think why atoi *still* won't give the right number :S

[nabeels786]

its not, i dunno why

and sprintf has gone funky on me too

	port=27015;
	char *test=new char[];

	sprintf(test,"%i",&port);

i outputted it, and got 1241156

[parksie]

Try giving that a size:

port=27015;
char test[40];

sprintf(test, "%i", port);

...you need to pass the number, not the pointer as well.

[nabeels786]

hmm now it worked.

i thought you had to pass a pointer to it? or if that scanf only?

now to get atoi working..

[parksie]

That's scanf. This is why I like the iostreams stuff...in many cases they're a lot faster as well (all the conversions are resolved at compile-time rather than run-time).

Actually, tell a lie, some compilers can interpret printf, etc., as intrinsics and they parse the format string themselves, but they're the minority.

[nabeels786]

ah ok. i find it easier to format using printf though. its part of my laziness

[nabeels786]

ok now it works

next to figure out why it locks up..thanks for the help