combining arrays

[ober0330]

I have two arrays that are created with the following code and then attempted to be concatenated with the last for loop. However it gives a "subscript out of range" error after only one iteration!? help!?

intmon = Format(strx, "mm")
intyr = Format(strx, "yy")
 
Open "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm" For Input As #1
    rtb1.LoadFile "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm"
Close #1
    arrmon = Split(rtb1, "</a></div>")
i = UBound(arrmon, 1)
 
intmon = Format(Now, "mm")
intyr = Format(Now, "yy")
 
Open "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm" For Input As #1
    rtb1.LoadFile "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm"
Close #1
    arrmon2 = Split(rtb1, "</a></div>")
    
For x = 0 To UBound(arrmon2, 1)
     arrmon(i) = arrmon2(x)
     i = i + 1
Next x

[cafeenman]

redim arrmon(Ubound(arrmon2))
For i = Lbound(arrmon2) To UBound(arrmon2)
     arrmon(i) = arrmon2(i)
Next i

[cafeenman]

actually, you can probably just assign the array in one line.

arrmon = arrmon2

[phinds]

well since you start off the index at the upper bound of the array, you'd pretty much expect to get an index error after one iteration, huh?

you need to redim the array before attempting to concatenate the 2nd one onto the end of it. Otherwise your code is fine.

cafeenman seems to have mistaken you question for how to reassign one array to another, not concatenate as you asked.

[ober0330]

ok, I thought there was something wrong with that.

here's what I've done:

ReDim arrmon(UBound(arrmon) + UBound(arrmon2))
For x = 0 To UBound(arrmon2, 1)
     arrmon(i) = arrmon2(x)
     i = i + 1
Next x

However, when I do that, it makes all of the initial array nothing. I've tried using "Preserve", but that appears to simply put the second array in the new array twice!?!

[ober0330]

scratch that... my

strx = Now -1
intmon = Format(strx, "mm")

is giving me the wrong date (this month).... !?

[phinds]

hm ... your code looks good to me, but I'm don't use redim. there must be something we're missing, obviously.

you could always just make a large 3rd array and move the 1st then the 2nd into it. that's inelegant, but memory's cheap

[Microbasic]

Code analysis:

Set the value of var "strx" to TODAY - 1 DAY
Get the month

So unless if it's the first of the month (which is not the case), it would return this month. Try this instead:

strx = DateAdd("n", -1, Now)
intmon = Format(strx, "mm")

[ober0330]

actually i just did:

strx = Now - 30
intmon = Format(strx, "mm")

That works fine now. I'm still having problems with the arrays tho.

The first array[portion] /edit in the concatenated array comes up as empty elements, and there's a few extra elements on the end of the concatenated array(which I can deal with).

anyone?

[Microbasic]

I've just noticed something. Your code will replace the last variable in the first array. To prevent that, use:

intmon = Format(strx, "mm")
intyr = Format(strx, "yy")
 
Open "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm" For Input As #1
    rtb1.LoadFile "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm"
Close #1
arrmon = Split(rtb1, "</a></div>")
i = UBound(arrmon, 1) + 1
 
intmon = Format(Now, "mm")
intyr = Format(Now, "yy")
 
Open "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm" For Input As #1
    rtb1.LoadFile "O:\ER2002\Inetlog\" & intyr & "\" & intmon & "\" & intmon & "e.htm"
Close #1
    arrmon2 = Split(rtb1, "</a></div>")
    
ReDim Preserve arrmon(UBound(arrmon) + UBound(arrmon2) + 1)
For x = 0 To UBound(arrmon2, 1)
     arrmon(i) = arrmon2(x)
     i = i + 1
Next x

[Microbasic]

Originally posted by ober5861
actually i just did:

strx = Now - 30
intmon = Format(strx, "mm")

NO! That is NOT RIGHT! Set your computer date to July 31, 2002 and see if that code works. It will warp back to July 1, which is still July!!!

Also, if you set your calender to March 1 and use that code, it will return January, NOT February!!!

[ober0330]

i just saw that myself

and I knew about the problem with the 30 days, I was going to fix that later. I just wanted to get the array catonation to work.

It works perfectly now. Thank you all.

[Microbasic]

PMbyober5861
hey, thanks for your help, but a piece of code you gave me doesn't work like you said:

strx = DateAdd("n", -1, Now)

That still returns the current month!?!

You PMed me concerning my code. OK, here's the modified code:

strx = DateAdd("[b]m[/b]", -1, Now)
intmon = Format(strx, "mm")

Iactuallychangedtheminutesinsteadofthemonth...Iamstupid...:(