Dear strings....

[abdul]

Trying to copy one string to another using strcpy but always crashes:

char *tempcaption;
strcpy(tempcaption, cLabel::caption); 

"cLabel::caption" is declared as "char *caption".

[amac]

You must pass in something that is previously allocated.

Either

char szBuffer[32] = "";
strcpy( szBuffer, "Alright" );

or

char * pszBuffer = new char[32];
strcpy( szBuffer, "Alright" );
delete [] pszBuffer;

I suppose you could always do this too

char * pszBuffer = strdup( "Word" );
free( pszBuffer );

[abdul]

I am trying to keep away from char array (the one declared as an array) that's why I have to mess up with the pointers. I just got it working by using:

char *tempcaption = cLabel::caption;
cLabel::caption = szCaption; 

I thought you couldn't use = sign to set the value of one string to another.

[CornedBee]

You can't. You only assign pointer values here. When you modify one string now, all others will be modified too.

[abdul]

So is this right:

char *cLabel::SetCaption(char szCaption[])
{
    char *tempcaption = cLabel::caption;
    cLabel::caption = szCaption;
    return (char*)tempcaption;
}

char *cLabel::GetCaption()
{
    return (char*)cLabel::caption;
} 

None of the functions return an address to a local variable or a variable from the class?

[amac]

you have to use something strcpy() like CornedBee said you are only copying the pointer's not the actual character array.


See above examples.

[Jop]

Try dereferencing the pointers maybe?

[CornedBee]

No, if he only returns the class members the get-version is ok.
The SetCaption can't work this way, you don't return the old caption, but rather the new.
Really, since this is MFC (I think, seems like it), why don't you just store the caption in a CString and return string from the Set function. It makes life so much easier. And if it's not MFC, use string. It's better than CString most of the time anyway.