[RESOLVED] VB Error

[DJ P@CkMaN]

hey all,
can anyone tell me what is wrong with this??

FileName = App.Path & "\Scores\High Score.cam"
 
    'get high scores from file
    Open FileName For Input As 1
    Do Until EOF(1)
        Line Input #1, HScore.Name
        Line Input #1, HScore.Score
    Loop
    Close #1

in a code module, i have a Public Type which is where the HScore.Name and HScore.Score came from. when i try to run the program, it comes up with a mismatch error and when i click debug, it highlights the .Score part of HScore.Score


thanks

[Ed Lampman]

If Score is numeric you may need to convert it to a numeric value.

FileName = App.Path & "\Scores\High Score.cam"

'get high scores from file
Open FileName For Input As 1
Do Until EOF(1)
Line Input #1, HScore.Name
Line Input #1, Score$
HScore.Score = clng(Score$)
Loop
Close #1

[DJ P@CkMaN]

that sounds right because in the type, its

Score As Integer

thanx for the help

[DJ P@CkMaN]

i get an Overflow error. it highlights

HScore.Score = CLng(Score$)

any ideas??

[Ed Lampman]

Why are you using Line Input?

Line Input reads the entire line in the file until it encounters a CR.

If the file contains this data, for instance,

Johnny, 1345
Billy, 7890

Line input would read the whole line - 'Johnny, 1345' into the first variable.

Input would only read 'Johnny'

[DJ P@CkMaN]

the file is

Cameron
100

so i do line input, and line 1 goes into HScore.Name and the score goes into HScore.Score

it works fine if i use plain strings instead of a public type, so i tried

Open FileName For Input As 1
Do Until EOF(1)
    Line Input #1, strName
    Line Input 1, intScore
Loop
Close #1
 
HScore.Name = strName
HScore.Score = intScore

but i get an overflow error with that

[Ed Lampman]

The overflow error on an integer data type is usually caused by being assigned a value greater than 32767.

Are there any scores greater than that? If so, try using a Long Integer.

HTH

[DJ P@CkMaN]

the highest possible score is 120, but i will try changing it to Long and see if that makes a diff

[DJ P@CkMaN]

weird.. Long works perfectly.. oh well, thanx heaps for your help

[Bruce Fox]

You were trying to assign a CLng (a LONG conversion) to
HScore.Score (prolly Dimmed an Integer).... So it would make
sense that HScore.Score should be Dimensioned as a Long.