Is this the best way?

[steve65]

I am trying to save records that are in a binary file to a string array. The code below works but leads me to that there could be a better way to get number of strings in the file.

Is it safe just to put in 16 instead of Len(ObjectID(0)) or is this not good programming practice.

Public Sub File2Query(FilePath As String)

Dim TempDataFile As Integer
Dim ObjectID() As String * 16
Dim i As Integer

    ReDim ObjectID(1)
    ObjectID(0) = ""

    ReDim ObjectID(FileLen(FilePath) / Len(ObjectID(0)))
    
    TempDataFile = FreeFile
    Open FilePath For Binary As #TempDataFile

    Get #TempDataFile, , ObjectID

    Close #TempDataFile

End Function

Thanks