Player 1 works in my game but how can I make "Player 2" work?

[rastin]

Hi,
Thanks all for helping me with my game so far.

I've made a small board game which includes player one only (inc code as well for him to help with making code for player 2).

I've also set up player 2's icons and labels etc...but not sure what code to make for him to work in the same way

I’m sure that most of player 2’s code can be cut and pasted from player 1’s but I’m not sure which parts.

How can I make player 2 work in the game?

(.zip file attached which has the game)


Thanks,
Rastin

[BrianHawley]

I'm guessing this game is at a fairly early stage, so I'm just going to make some general comments, not give actual code.

1) You need a global variable (e.g. Dim CurrentPlayer as Integer) that indicates whose turn it is.

2) Put a routine at the end of the players' turns to change it to the next player.

3) Good programming practice says that you should assume in future there could be any number of players, not just two.

Therefore duplicating your code for the two players is not a good idea. You'ld end up withj six copies for six players and it would be difficult to maintain.

4) Write general routines for everything, and use the CurrentPlayer variable to control what is done.

e.g. Image(CurrentPlayer).move etc...

That way you can have the same code for every player. Easier to maintain and update.

5) Instead of code like

Select Case Image2.Top
Case "3360"
  Image2.Top = 2535
Case "2535"
  Image2.Top = 1710
Case "1710"
  Image2.Left = 4755
  Image2.Top = 1711
End Select

I would use global constants like

Dim Const CONST_A1 = 3360
etc...

Select Case Image2.Top
Case CONST_A1
  Image2.Top = CONST_B1
Case CONST_B1
  Image2.Top = CONST_C2
 
 etc...

That way you can set your constants at the start of the program and easily change them if you change the board size. You can also give them meaningful names.

Hope the above helps!