porobably a silly question

[Neilbaker86]

i have just tried adding a Progress bar to my project everythings ok but i need help on hiding it

i tried this

Private Sub pro_Click()
If pro.Caption = "Hide Progress Bar" Then GoTo 1 Else
If pro.Caption = "Show Progress Bar" Then GoTo 2

1: ProgressBar1.Visible = False
pro.Caption = "Show Progress Bar"

2: ProgressBar1.Visible = True
pro.Caption = "Hide Progress Bar"
End Sub

i think it needs some kind of end in between 1 and 2 because it does both, can someone help me out?

[jbart]

You need to put an Exit Sub before the second go to label. But, you should just lose goTo.

Private Sub pro_Click()
    If pro.Caption = "Hide Progress Bar" Then
        ProgressBar1.Visible = False
        pro.Caption = "Show Progress Bar"
    ElseIf pro.Caption = "Show Progress Bar" Then
        ProgressBar1.Visible = True
        pro.Caption = "Hide Progress Bar"
    End If
End Sub

[Mega_Man]

Do this instead.

Private Sub pro_Click()

If pro.Caption = "Hide Progress Bar" Then
ProgressBar1.Visible = False
pro.Caption = "Show Progress Bar"
Else
ProgressBar1.Visible = True
pro.Caption = "Hide Progress Bar"
End if

End Sub

Mega.

[Mega_Man]

Cross posted again.. ARGH!!!!.. Every time.

[Neilbaker86]

Thanks guys!!

[alip1]

Also:

Insert EXIT SUB between lin1 1. an d 2.

Private Sub pro_Click()
If pro.Caption = "Hide Progress Bar" Then GoTo 1 Else
If pro.Caption = "Show Progress Bar" Then GoTo 2

1: ProgressBar1.Visible = False
pro.Caption = "Show Progress Bar"
EXIT SUB
2: ProgressBar1.Visible = True
pro.Caption = "Hide Progress Bar"
End Sub

[beachbum]

Originally posted by alip1
Also:
Insert EXIT SUB between lin1 1. an d 2.

Nooooooooooooooooooooooooooo
Don't use goto's at all. The only times they should be used are in error handling (On Error Goto...) and maybe if the number of nested If Then's is too great.
Regards
Stuart