Results 1 to 2 of 2

Thread: VBA error 1004 Application-defined or object-defined error

  1. #1

    Thread Starter
    New Member
    Join Date
    May 2013
    Posts
    1

    Question VBA error 1004 Application-defined or object-defined error

    I have inherirted an application that has been working up until now using VBA to put hyperlinks on an active worksheet in Excel to other worksheets in the workbook.

    I have debugged the code and narrowed it down to the following:

    Function ksListSheets()
    '===========================================================
    ' Copy summary AFO data to worksheet
    '===========================================================
    On Error GoTo Err_ksListSheets

    Dim ws As Object
    Dim wsMain As Object
    Dim intCtr As Integer
    Dim intRC1 As Integer

    intCtr = 7

    With oWkBk.Sheets("MainSheet")
    Set wsMain = oWkBk.Sheets("MainSheet")
    End With

    wsMain.Activate

    For Each ws In oWkBk.Worksheets
    Select Case ws.Name
    Case "MainSheet", "rhTemplate", "rhTemplateAuto", "rhTemplateFire", "rhSummaryData", "rhTeamAFOData"
    ' do not build hyperlinks for these sheets
    Case Else
    ActiveSheet.Hyperlinks.Add _
    Anchor:=Cells(intCtr, 3), _
    Address:="", _
    SubAddress:="'" & Replace(ws.Name, "'", "''", 1) & "'!A1", _
    TextToDisplay:=ws.Name

    intCtr = intCtr + 1
    End Select
    Next ws

    Done_ksListSheets:
    ksListSheets = intRC1
    Set ws = Nothing
    Set wsMain = Nothing
    On Error Resume Next
    Exit Function

    Err_ksListSheets:
    MsgBox Err.Number & " " & Err.Description
    intRC1 = 16
    Resume Done_ksListSheets
    End Function

    What happens is the Excel workbook is open to the "MainSheet" and is active. It goes through the case once and the ws.Name is set at "MainSheet" so it does nothing and goes to the next worksheet, which is "Zone - Auto". The code then falls through to Case Else and immediately goes to Err-ksListSheets. I have Anchor, SubAddress and TextToDisplay in my watch list and they display "expression not defined in context" in the value field. Again this code had been working up until recently.

    Can anyone help. I have no idea.

  2. #2
    PowerPoster
    Join Date
    Dec 2004
    Posts
    25,618

    Re: VBA error 1004 Application-defined or object-defined error

    pls use code tags when posting code

    this should really be a SUB as it returns nothing to the caller

    ActiveSheet.Hyperlinks.Add _
    Anchor:=Cells(intCtr, 3), _
    Address:="", _
    SubAddress:="'" & Replace(ws.Name, "'", "''", 1) & "'!A1", _
    TextToDisplay:=ws.Name
    your problem is not using fully qualified ranges for all range object parameters, avoid using activesheet, specify the correct sheet for the target hyperlinks and specify the sheet for the range parameters of anchor
    maybe like
    Code:
    wsMain.Hyperlinks.Add _
    Anchor:=ws.Cells(intCtr, 3), _
    Address:="", _
    SubAddress:="'" & Replace(ws.Name, "'", "''", 1) & "'!A1", _
    TextToDisplay:=ws.Name
    after staring at the subaddress for a while i am still at a loss as to what you are replacing in the worksheet name
    edit i can see this after posting the code within the tags
    Last edited by westconn1; May 4th, 2013 at 06:13 AM.
    i do my best to test code works before i post it, but sometimes am unable to do so for some reason, and usually say so if this is the case.
    Note code snippets posted are just that and do not include error handling that is required in real world applications, but avoid On Error Resume Next

    dim all variables as required as often i have done so elsewhere in my code but only posted the relevant part

    come back and mark your original post as resolved if your problem is fixed
    pete

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  



Click Here to Expand Forum to Full Width