variable not defined

[angel06]

Please help me with my program guys!
Im currently creating a color guessing program, for every correct answer will give score. The codes of my program are below. Im having a hard time in correcting my code. It has an error of variable not defined please help me!


Option Explicit
Dim score As Integer
Private Sub Command1_Click()
Dim Values(3) As ColorConstants
Values(0) = vbRed
Values(1) = vbBlue
Values(2) = vbGreen
Dim RandomNumber As ColorConstants
RandomNumber = Values(Rnd * 2)
Label1.BackColor = RandomNumber
Randomize
End Sub

Private Sub Command2_MouseDown(Button As Integer, Shift As Integer, X As Single, Y As Single)
If Text1.Text = Label1.BackColor = Values(0) Then
score = score + 1
Label3.Caption = score
End If
If Text1.Text = Label1.BackColor = Values(1) Then
score = score + 1
Label3.Caption = score
If Text1.Text = Label1.BackColor = Values(2) Then
score = score + 1
Label3.Caption = score
End Sub

Private Sub Form_Load()
Label2.Caption = "the color is:"
Text1.Text = ""
Label4.Caption = "score:"
Label1.Caption = ""
Command2.Caption = "submit"
End Sub

[Doogle]

You've got at least 3 problems

1. The Variable Values is defined in Command1_Click and you're trying to access it in Command2_Click. To do this you must define Values at the Form level (ie in the Declarations Section of the Form.

2. You're missing 2 'End If' statements in Command2_Click

3. This statement: If Text1.Text = Label1.BackColor = Values(0) Then will result in a Type Mismatch Error. It's not clear what you're trying to do

[angel06]

Then how would I do with this statement If Text1.Text = Label1.BackColor = Values(0)? What i'm trying to do is that if the value in Text1.text is equivalent to the BackColor of Label1 for example vbRed, vbBlue or vbGreen then it should add score. I'm really having hard time with this thing.

[DataMiser]

You would not use more than 1 = on a line what you have there will effectively check to see if the text is true or false and that is not what you want.

The question is what do you want them to enter in the text box? Do you want them to enter a number from 1 to 3, The actual numeric value of the color or the word for the color. Depending on this factor the code would be different in each case.

For example if you want them to enter the word Red for the color red then you would do

If Text1.Text="Red" and Label1.BackColor=vbRed Then
    score=score+1
End If

If the first part of your code you have another mistake. You call rnd() before you call randomize. You need to call Randomize first and make sure that you only call it once then the rnd() function will work properly.

In other words the call to Randomize should be moved to the Form_Load event and removed from where you have it.

[angel06]

You would not use more than 1 = on a line what you have there will effectively check to see if the text is true or false and that is not what you want.

The question is what do you want them to enter in the text box? Do you want them to enter a number from 1 to 3, The actual numeric value of the color or the word for the color. Depending on this factor the code would be different in each case.

For example if you want them to enter the word Red for the color red then you would do

If Text1.Text="Red" and Label1.BackColor=vbRed Then
    score=score+1
End If

If the first part of your code you have another mistake. You call rnd() before you call randomize. You need to call Randomize first and make sure that you only call it once then the rnd() function will work properly.

In other words the call to Randomize should be moved to the Form_Load event and removed from where you have it.

Thank you very much! I already finished creating my program thanks man!

[angel06]

Um can I ask one last thing, how would I code a statement for example the user will enter the color in text box i.e. yellow, it must be the same if the user enters Yellow. How would I do that?

[DataMiser]

You can either use the Ucase$() or LCase$() functions to convert the case in your test or if you want a global solution you can add a line to the very top of your form code under the declarations section

Option Compare Text

adding this line will make all text checks non case sensitive

Otherwise you could do

If Ucase$(Text1.Text)="RED" and Label1.BackColor=vbRed Then
    score=score+1
End If

or you could do

If LCase$(Text1.Text)="red" and Label1.BackColor=vbRed Then
    score=score+1
End If

[angel06]

Thank you again! I already fixed my program.

[Doogle]

Also.....

If StrConv(Text1.Text, vbProperCase) = "Red" And Label1.BackColor = vbRed Then

[firoz.raj]

Yep doggle is right .you are missing two end if as well .

Option Explicit
Dim score As Integer
Private Sub Command1_Click()
Dim Values(3) As ColorConstants
Values(0) = vbRed
Values(1) = vbBlue
Values(2) = vbGreen
Dim RandomNumber As ColorConstants
RandomNumber = Values(Rnd * 2)
Label1.BackColor = RandomNumber
Randomize
End Sub

Private Sub Command2_MouseDown(Button As Integer, Shift As Integer, X As Single, Y As Single)
If Text1.Text = Label1.BackColor = Values(0) Then
score = score + 1
Label3.Caption = score
End If
If Text1.Text = Label1.BackColor = Values(1) Then
score = score + 1
Label3.Caption = score
End if      'End if Needs to be here 
If Text1.Text = Label1.BackColor = Values(2) Then
score = score + 1
Label3.Caption = score
End if             'Endif needs to be here
End Sub

Private Sub Form_Load()
Label2.Caption = "the color is:"
Text1.Text = ""
Label4.Caption = "score:"
Label1.Caption = ""
Command2.Caption = "submit"
End Sub