Unable to insert data into sql database

[dougancil]

I'm sure that I'm missing something really basic here, but I'm just not seeing it. I have the following code:

    Public Sub InsertRow()
        Dim employeenumber As String = employeeListBox.SelectedValue
        Dim headsetnumber As String = headsetnumberText.Text
        Dim amplifiernumber As String = amplifiernumberText.Text
        Dim returnreason As String = returnreasonDropDown.SelectedValue
        Dim notes As String = notesText.Text

        Dim myConnectionString As String = "Initial Catalog=xxxxx;Data Source=xxxxx;uid=xxxxx;password=xxxxx;"
        Dim myConnection As New SqlConnection(myConnectionString)
        Dim insertcommandText As String = _
        "insert into equipment (employeenumber, headsetnumber, amplifiernumber, returnreason, notes) " & _
        "values(employeenumber, headsetnumber, amplifiernumber, returnreason, notes)"

        Using connection As New SqlConnection(myConnectionString)
            Dim command As New SqlCommand(insertcommandText, connection)

            Try
                connection.Open()
                command.ExecuteNonQuery()
                thankyouLabel.Text = "Your data has been submitted."

            Catch ex As Exception
                If myerrormessageLabel.Text = ex.Message Then
                    thankyouLabel.Text = ""
                End If
            End Try
        End Using

    End Sub

and when I put a break point on the command.ExecuteNonQuery line, and then step through that, I'm never displayed the thankyouLabel.Text nor is my data being inserted into the database. Can someone point out what I may be missing?

Thank you

Doug

[GaryMazzone]

this line is wrong:

insert into equipment (employeenumber, headsetnumber, amplifiernumber, returnreason, notes) " & _
"values(employeenumber, headsetnumber, amplifiernumber, returnreason, notes)"


Is should be:

insert into equipment (employeenumber, headsetnumber, amplifiernumber, returnreason, notes) " & _
"values(" & employeenumber & "," & headsetnumber & "," & amplifiernumber & "," & returnreason & "," & notes & ")"

if Notes is text then you need to enclose in single qoutes
same for any of these things actually

[wild_bill]

you should be getting an exception. try this.

    Public Sub InsertRow()
        Dim employeenumber As String = employeeListBox.SelectedValue
        Dim headsetnumber As String = headsetnumberText.Text
        Dim amplifiernumber As String = amplifiernumberText.Text
        Dim returnreason As String = returnreasonDropDown.SelectedValue
        Dim notes As String = notesText.Text

        Dim myConnectionString As String = "Initial Catalog=xxxxx;Data Source=xxxxx;uid=xxxxx;password=xxxxx;"
        Dim myConnection As New SqlConnection(myConnectionString)
        Dim insertcommandText As String = _
        "insert into equipment (employeenumber, headsetnumber, amplifiernumber, returnreason, notes) " & _
        "values(@employeenumber, @headsetnumber, @amplifiernumber, @returnreason, @notes)"

        Using connection As New SqlConnection(myConnectionString)
            Dim command As New SqlCommand(insertcommandText, connection)
            command.parameters.addwithvalue("@employeenumber",employeenumber)
            command.parameters.addwithvalue("@headsetnumber",headsetnumber)
            command.parameters.addwithvalue("@amplifiernumber",amplifiernumber)
            command.parameters.addwithvalue("@returnreason",returnreason)
            command.parameters.addwithvalue("@notes",notes)



            Try
                connection.Open()
                command.ExecuteNonQuery()
                thankyouLabel.Text = "Your data has been submitted."

            Catch ex As Exception
                If myerrormessageLabel.Text = ex.Message Then
                    thankyouLabel.Text = ""
                End If
            End Try
        End Using

    End Sub

[dougancil]

Wild Bill,

thanks ... that did it.