Data not Updated ?

[Tengkorak]

i can't update my data at database
this my code :

Private Sub cmdSave_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdSave.Click
        Try
            'Dim ds As New DataSet
            Dim scmd As New OleDbCommand
            If bAdd Then
                scmd.CommandText = "insert into inv_t_products (prod_id,prod_name,unit,unitprice) " & _
                        "values(@prodid,@prodname,@unit,@unitprice)"
            Else
                'modify
                scmd.CommandText = "update inv_t_products set prod_name=@prodname,unit=@unit,unitprice=@unitprice " & _
                    "where prod_id=@prodid"
            End If
 
            scmd.Parameters.Add(New OleDbParameter("@prodid", txtKd.Text))
            scmd.Parameters.Add(New OleDbParameter("@prodname", txtNm.Text))
            scmd.Parameters.Add(New OleDbParameter("@unit", txtSat.Text))
            scmd.Parameters.Add(New OleDbParameter("@unitprice", txtHarga.Text))
 
            scmd.Connection = dbConn
            scmd.ExecuteNonQuery()
            bUpdated = True
 
            Me.Close()
 
        Catch ex As Exception
            ERRDesc(ex)
        End Try
 
        MsgBox("Saved", MsgBoxStyle.Information)
 
    End Sub

i have problem when update data, data not updated.

how the solution ?

thank you

[cicatrix]

ExecuteNonQuery returns an integer value indicating how many rows has been affected by the command. See what it is:

Dim rowsaffected As Integer = scmd.ExecuteNonQuery()
MsgBox("Rows affected:" & rowsaffected.ToString())

Also I didn't see where dbconn connection is opened in your code.
Are you sure it stays open?

If dbconn.State <> ConnectionState.Open Then dbconn.Open()

[jmcilhinney]

How EXACTLY do you know that data isn't saved? When you try to save data, there are only three possibilities:

1. There are changes to save, they are saved successfully and ExecuteNonQuery returns a non-zero value.
2. There are no changes to save so ExecuteNonQuery returns zero.
3. An exception is thrown.

Which is it in your case? If it's not 2 or 3 then the data IS being saved and you're just looking in the wrong place or at the wrong time. In that case, follow the first link in my signature.

[Tengkorak]

thank you for your replay.

i tried check connection state and the result is 1 (Open)
and when i try this code :

Dim rowsaffected As Integer = scmd.ExecuteNonQuery()
MsgBox("Rows affected:" & rowsaffected.ToString())

the result is 0

[Tengkorak]

I've got the solution, I changed my code to:

 scmd.CommandText = "update inv_t_products set prod_name=@prodname,unit=@unit,unitprice=@unitprice " & _
                    "where prod_id='" & txtKd.Text & "'"

[rocky_inc]

yes the solution is correct