[RESOLVED] Message in PHP script is displayed in other server

[dee-u]

This is the code, somehow I noticed that in the other server that I have tried it the messages (Please specify email., Incorrect email format., etc...) are being displayed, why is this?

<?php if(isset($_GET['empty_email'])){?> 
Please specify email.<br /> 
<?php ;}?>

<?php if(isset($_GET['invalid_email'])){?> 
Incorrect email format.<br /> 
<?php ;}?>  

<?php if(isset($_GET['empty_captcha'])){?> 
Please specify verification code.<br /> 
<?php ;}?> 

<?php if(isset($_GET['wrong_code'])){?> 
Wrong verification code.<br /> 
<?php ;}?> 

<?php if(isset($_GET['success'])){?> 
Comment successfully sent.<br /> 
<?php ;}?>

I'm really no PHP developer and most of the stuffs I used are from searching the web so I am not sure of the answer. Thanks for anyone who could point out what I am doing wrong.

[kows]

I'm not entirely sure what you're asking.

the code you posted doesn't really mean anything. what is the desired output? what is showing up instead? where is the rest of the script? what is this "other server"?

[Nightwalker83]

This is the code, somehow I noticed that in the other server that I have tried it the messages (Please specify email., Incorrect email format., etc...) are being displayed, why is this?

<?php if(isset($_GET['empty_email'])){?> 
Please specify email.<br /> 
<?php ;}?>

<?php if(isset($_GET['invalid_email'])){?> 
Incorrect email format.<br /> 
<?php ;}?>  

<?php if(isset($_GET['empty_captcha'])){?> 
Please specify verification code.<br /> 
<?php ;}?> 

<?php if(isset($_GET['wrong_code'])){?> 
Wrong verification code.<br /> 
<?php ;}?> 

<?php if(isset($_GET['success'])){?> 
Comment successfully sent.<br /> 
<?php ;}?>

I'm really no PHP developer and most of the stuffs I used are from searching the web so I am not sure of the answer. Thanks for anyone who could point out what I am doing wrong.

Write it like this:

<?php 
if (isset($_GET['empty_email'])) 
{ 
//Something here
} 
else 
{ 
//Something else
} 
?>

I'm not entirely sure what you're asking.

the code you posted doesn't really mean anything. what is the desired output? what is showing up instead? where is the rest of the script? what is this "other server"?

I think dee-u is asking why the else part of the code is being triggered!

[dee-u]

The message "Please specify email." should only be shown when there is no email but without doing anything it does show up when I just show my contact form which is hosted on another server. I will look closely at night's suggestion when I get home.

[dee-u]

When I tried Nightwalker83's suggestion here is what is displayed when the html is shown.

} else { Test } ?>

Is the script specific to any version or something?

[SambaNeko]

Your condition for PHP to write out "please specify email" is if $_GET['empty_email'] is set. Check the URL you're using to access the page... does it have "empty_email" anywhere in it?

[I_Love_My_Vans]

<?php

if (isset($_GET['empty_email'])) 
{ 
    ?>Please specify an email<br /><?php
}

?>

Does your condition (if) statement look like this? ^^^

Please post what you currently have, and and SambaN suggested, an example link that you are using to fire this script.


ILMV

[dee-u]

This is how it is. This works on one server and not on other servers I have tested.

<div id="outer">
<div id="inner2">

<?php if(isset($_GET['empty_email'])){?> 
Please specify email.<br /> 
<?php ;}?>

<?php if(isset($_GET['invalid_email'])){?> 
Incorrect email format.<br /> 
<?php ;}?>  

<?php if(isset($_GET['empty_captcha'])){?> 
Please specify verification code.<br /> 
<?php ;}?> 

<?php if(isset($_GET['wrong_code'])){?> 
Wrong verification code.<br /> 
<?php ;}?> 

<?php if(isset($_GET['success'])){?> 
Comment successfully sent.<br /> 
<?php ;}?>
<form action="send_contact.php" method="post" >
        <fieldset style="border: none;">
        <input type="hidden" name="submit" value="submit" />
        <p>Name:<br />
          <input type="text" maxlength="50" name="name" value="" />
        </p>
        <p>Email:<br />
          <input type="text" maxlength="50" name="email" value="" />		  
        </p>
		<p>Type verification image:<br />
          <input name="verif_box" type="text" id="verif_box""/>
			<img src="verificationimage.php?<?php echo rand(0,9999);?>" alt="verification image, type it in the box" width="50" height="24" align="absbottom" />
			<br />								
        </p>
        <p>Comments:<br />
          <textarea name="comments" rows="7" cols="7" style="width: 98&#37;;" ></textarea>
        </p>
        <p>
          <input type="submit" name="submit" value="Submit" />
        </p>
        </fieldset>
      </form>
</div>
</div>

[I_Love_My_Vans]

It should be cleaned up as I suggested... like this:

<div id="outer">
<div id="inner2">

<?php 

if(isset($_GET['empty_email'])) {
    ?>Please specify email.<br /><?php
}
if(isset($_GET['invalid_email'])) {
    ?>Incorrect email format.<br /><?php
}
if(isset($_GET['empty_captcha'])){
    ?>Please specify verification code.<br /><?php 
} 
if(isset($_GET['wrong_code'])){ 
    ?>Wrong verification code.<br /><?php 
}
if(isset($_GET['success'])){ 
    ?>Comment successfully sent.<br /><?php 
}

?>
<form action="send_contact.php" method="post" >
        <fieldset style="border: none;">
        <input type="hidden" name="submit" value="submit" />
        <p>Name:<br />
          <input type="text" maxlength="50" name="name" value="" />
        </p>
        <p>Email:<br />
          <input type="text" maxlength="50" name="email" value="" />          
        </p>
        <p>Type verification image:<br />
          <input name="verif_box" type="text" id="verif_box""/>
            <img src="verificationimage.php?<?php echo rand(0,9999);?>" alt="verification image, type it in the box" width="50" height="24" align="absbottom" />
            <br />                                
        </p>
        <p>Comments:<br />
          <textarea name="comments" rows="7" cols="7" style="width: 98%;" ></textarea>
        </p>
        <p>
          <input type="submit" name="submit" value="Submit" />
        </p>
        </fieldset>
      </form>
</div>
</div>

ILMV

[dee-u]

Okay, I cleaned it up but still it show. Have a look at this. The same script works here.

[dee-u]

As odd as it is the script for the PHP is viewable when I view the source of the first link. Is it a server setting?

[kfcSmitty]

Why are you using a .html file extension? I wasn't even aware you could do that.

Should be .php

[dee-u]

Pardon? You mean I should change to contact.php?

[kows]

well, if you tell Apache to use the PHP interpreter on HTML files, it would work. but not many people would do that! from now on, make sure your PHP scripts have the right extension! if you want, you can use mod_rewrite (in an HTACCESS file) to mimic the functionality.

RewriteEngine On
RewriteRule ^contact.html$ /contact.php [NC,L]

[dee-u]

ahhh... so anything that has a PHP script in it should be saved with .php extension, I thought if the whole file is PHP only then should we save it as such. Thanks guys, changing the extension worked.

[SambaNeko]

For your reference, as kows mentioned, if you want to have .html files parsed as PHP, here's what you need to add to your .htaccess file:

AddType application/x-httpd-php .htm .html 
AddHandler application/x-httpd-php .html .htm .php

[Nightwalker83]

?>Please specify email.<br /><?php

What is the reason for the php tags as above? The start and end tags should be enough?

[SambaNeko]

What is the reason for the php tags as above? The start and end tags should be enough?

Because that line of code exits (with "?>"), and then re-enters (with "<?php") the PHP context to write out a line of HTML. It's the same as doing this:

<?php
echo "Please specify email.<br />";
?>

...and I'd say that's the preferred method when the string is so short, but if you have a particularly large block of HTML to output in the middle of your PHP script, it's easier and cleaner to do it the aforementioned way.

[Nightwalker83]

Because that line of code exits (with "?>"), and then re-enters (with "<?php") the PHP context to write out a line of HTML. It's the same as doing this:

<?php
echo "Please specify email.<br />";
?>

...and I'd say that's the preferred method when the string is so short, but if you have a particularly large block of HTML to output in the middle of your PHP script, it's easier and cleaner to do it the aforementioned way.

Ah, I've just been taught to echo method as you posted! It seems tidier.

[I_Love_My_Vans]

Don't let VisualAd know your echoing HTML!

I have been beaten by said member of the forums, into not echoing out HTML. PHP is an embedded language, you don't need to echo even the little one liners because of the small amount of code needed to close and re-enter the executable PHP code.

Not only does echoing HTML make the server work more, but because it is wraped in PHP code your text editor may not highlight it, and thus it may be more difficult to spot validation errors.


Cheers Adam!