Next without for

[a5bcap]

i have this code that i'm making a dice game with 6 dice. I can't get one command button to roll all of them. when i use this code it just gives me a compile error: NEXT witout FOR . on the NEXT inCount before picDieThree
can someone help me

Private Sub Command1_click()
'Player One (Die One)
'Definitions
Dim intShow As Integer
Dim intCount As Integer
'Roll Dice
Randomize Timer
intShow = Int((5 * Rnd))
For intCount = 0 To intShow
picDieOne(intCount).ZOrder (0)
Next intCount
picDieTwo(intCount).ZOrder (0)
Next intCount
picDieThree(intCount).ZOrder (0)
Next intCount
picDieFour(intcout).ZOrder (0)
Next intCount
picDieSix(intCount).ZOrder (0)

thanks Zayn Kalyan

[kewakl]

what do you want the routine to do.
i guess that you want the for ... next loop to make the 6 dice take their ZOrder position in sequence, not simultaneously.? am i close?

[kewakl]

do you already have the six die faces drawn? - not the actual 6 DICE, but their DOT faces
what are the pic names for each side?

[a5bcap]

i have all the sides drawn but i want them to be random i'll give you the code for how they are drawn. I do not care how the take their ZOrder postions

[CODE]Private Sub Form_Load()
'Initialise Dice
frmMain.Caption = "Lucky Dice"
'Definitions
Dim intTop As Integer
Dim intLeft As Integer
Dim intRadius As Integer
Dim intColour As Integer
Dim intCount As Integer
'Set Circle Settings
intRadius = 60
intColour = vbBlack
'Die One
'Set Die One Settings
intLeft = picDieOne(0).Left
intTop = picDieOne(0).Top
'Setup Picture Boxes (Move, Fill and Visbility)
For intCount = 0 To 5
picDieOne(intCount).Left = intLeft
picDieOne(intCount).Top = intTop
picDieOne(intCount).FillStyle = vbFSSolid
picDieOne(intCount).Visible = True
picDieOne(intCount).BackColor = vbWhite
Next intCount
'Render Dice Patterns
'Number One
picDieOne(0).Circle (280, 280), intRadius, intColour
'Number Two
picDieOne(1).Circle (140, 120), intRadius, intColour
picDieOne(1).Circle (400, 400), intRadius, intColour
'Number Three
picDieOne(2).Circle (140, 120), intRadius, intColour
picDieOne(2).Circle (280, 280), intRadius, intColour
picDieOne(2).Circle (440, 440), intRadius, intColour
'Number Four
picDieOne(3).Circle (140, 120), intRadius, intColour
picDieOne(3).Circle (140, 440), intRadius, intColour
picDieOne(3).Circle (440, 120), intRadius, intColour
picDieOne(3).Circle (440, 440), intRadius, intColour
'Number Five
picDieOne(4).Circle (140, 120), intRadius, intColour
picDieOne(4).Circle (140, 440), intRadius, intColour
picDieOne(4).Circle (280, 280), intRadius, intColour
picDieOne(4).Circle (440, 120), intRadius, intColour
picDieOne(4).Circle (440, 440), intRadius, intColour
'Number Six
picDieOne(5).Circle (140, 120), intRadius, intColour
picDieOne(5).Circle (140, 270), intRadius, intColour
picDieOne(5).Circle (140, 440), intRadius, intColour
picDieOne(5).Circle (440, 120), intRadius, intColour
picDieOne(5).Circle (440, 270), intRadius, intColour
picDieOne(5).Circle (440, 440), intRadius, intColour
'Die Two
'Set Die Two Settings
intLeft = picDieTwo(0).Left
intTop = picDieTwo(0).Top
'Setup Picture Boxes (Move, Fill and Visbility)
For intCount = 0 To 5
picDieTwo(intCount).Left = intLeft
picDieTwo(intCount).Top = intTop
picDieTwo(intCount).FillStyle = vbFSSolid
picDieTwo(intCount).Visible = True
picDieTwo(intCount).BackColor = vbWhite
Next intCount
'Render Dice Patterns
'Number One
picDieTwo(0).Circle (280, 280), intRadius, intColour
'Number Two
picDieTwo(1).Circle (140, 120), intRadius, intColour
picDieTwo(1).Circle (400, 400), intRadius, intColour
'Number Three
picDieTwo(2).Circle (140, 120), intRadius, intColour
picDieTwo(2).Circle (280, 280), intRadius, intColour
picDieTwo(2).Circle (440, 440), intRadius, intColour
'Number Four
picDieTwo(3).Circle (140, 120), intRadius, intColour
picDieTwo(3).Circle (140, 440), intRadius, intColour
picDieTwo(3).Circle (440, 120), intRadius, intColour
picDieTwo(3).Circle (440, 440), intRadius, intColour
'Number Five
picDieTwo(4).Circle (140, 120), intRadius, intColour
picDieTwo(4).Circle (140, 440), intRadius, intColour
picDieTwo(4).Circle (280, 280), intRadius, intColour
picDieTwo(4).Circle (440, 120), intRadius, intColour
picDieTwo(4).Circle (440, 440), intRadius, intColour
'Number Six
picDieTwo(5).Circle (140, 120), intRadius, intColour
picDieTwo(5).Circle (140, 270), intRadius, intColour
picDieTwo(5).Circle (140, 440), intRadius, intColour
picDieTwo(5).Circle (440, 120), intRadius, intColour
picDieTwo(5).Circle (440, 270), intRadius, intColour
picDieTwo(5).Circle (440, 440), intRadius, intColour
'Set Die Three Settings
intLeft = picDieThree(0).Left
intTop = picDieThree(0).Top
'Setup Picture Boxes (Move, Fill and Visbility)
For intCount = 0 To 5
picDieThree(intCount).Left = intLeft
picDieThree(intCount).Top = intTop
picDieThree(intCount).FillStyle = vbFSSolid
picDieThree(intCount).Visible = True
picDieThree(intCount).BackColor = vbWhite
Next intCount
'Render Dice Patterns
'Number One
picDieThree(0).Circle (280, 280), intRadius, intColour
'Number Two
picDieThree(1).Circle (140, 120), intRadius, intColour
picDieThree(1).Circle (400, 400), intRadius, intColour
'Number Three
picDieThree(2).Circle (140, 120), intRadius, intColour
picDieThree(2).Circle (280, 280), intRadius, intColour
picDieThree(2).Circle (440, 440), intRadius, intColour
'Number Four
picDieThree(3).Circle (140, 120), intRadius, intColour
picDieThree(3).Circle (140, 440), intRadius, intColour
picDieThree(3).Circle (440, 120), intRadius, intColour
picDieThree(3).Circle (440, 440), intRadius, intColour

[kewakl]

with the attached example, you can see how to assign the desired face to the desired die.

I have picboxes for six DICE and six DIE FACES.
click the button and the routine RaNDomly picks a die FACE to apply to a DIE.
I included my quickly drawn die faces as .bmps because my example loads the pics as opposed to drawing the pics as your prog does.

hopefully you can follow it. it is only 15 lines
the For Next loops through the DICE and RND-picks a FACE.

good luck and goodnight.

added a .zip file for compliance with forum

[iPrank]

Re: Syntax error in your first post

Private Sub Command1_click()
 
    'Player One (Die One)
    'Definitions
    Dim intShow As Integer
    Dim intCount As Integer
    'Roll Dice
    Randomize Timer
    intShow = Int((5 * Rnd))
 
    For intCount = 0 To intShow
        picDieOne(intCount).ZOrder (0)
    Next intCount
 
    picDieTwo(intCount).ZOrder (0)
Next intCount '--> orphan
 
picDieThree(intCount).ZOrder (0)
Next intCount '--> orphan
 
picDieFour(intcout).ZOrder (0)
Next intCount '--> orphan
 
picDieSix(intCount).ZOrder (0)
 
End Sub

The Nexts marked as 'orphan' do not have a correcponding For. Every For must have its corresponding closing Next

Also, the For Next <Counter> format is slower. You don't need to add the counter after the Next - it will be faster.

you can write the above code as:

For intCount = 0 To intShow
        picDieOne(intCount).ZOrder (0)
        picDieTwo(intCount).ZOrder (0)
        picDieThree(intCount).ZOrder (0)
        picDieFour(intcout).ZOrder (0)
        picDieSix(intCount).ZOrder (0)
    Next ' No counter here

[a5bcap]

thanks kewakl for the code
and thanks for the .bmps

thanks

[Merri]

Also, the For Next <Counter> format is slower. You don't need to add the counter after the Next - it will be faster.

Untrue. In compiled code there is no difference was the counter put there or not: it compiles to the exact same code both ways. For code readability it is better to put it in (and that's why we have it).

[kewakl]

thanks kewakl for the code
and thanks for the .bmps

thanks

you are welcome!

there is nothing wrong with the prog drawing the images at runtime:
the total program footprint would be smaller.
you do not have to include images in the install.


you could do the program without any dice pictureboxes -- they can be drawn on the form itself.

i have a peg solitaire game that has no controls or windows except the main form. all pegs and buttons are drawn on the form.

[kewakl]

you may have noticed that you cannot roll a '6'

change this

Private Sub cmdRoll_Click()
Dim nDieFaceVal As Integer
Dim nDie As Integer
For nDie = 0 To 5
    nDieFaceVal = Int((6 * Rnd))
    picDie(nDie).Picture = picDieFace(nDieFaceVal)
Next
End Sub

also you can LOCK individual dice so that they will not change on a roll.
you *can* use the .Appearance property -- if you like.

Private Sub cmdRoll_Click()
.
.
.
    If picDie(nDie).Appearance = 0 Then picDie(nDie).Picture = picDieFace(nDieFaceVal)
.
.
.
Next
End Sub

and in picDie_Click

Private Sub picDie_Click(Index As Integer)
If picDie(Index).Appearance = 0 Then
    picDie(Index).Appearance = 1
Else
    picDie(Index).Appearance = 0
End If
End Sub

**could not find a declaration for the vb Appearance property value.