Batch

[nbmprivat]

Hey guys/girls

I have a problem. I made a program that runs batch files from a location on our network.



When I press a button, the code looks like this:

Private Sub Arcadre_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Arcadre.Click
        txtCommand.Text = "acadre.bat"
        startThread()
End Sub

txtComand is a hidden label that contains the network path.

Some of them work, and some don't. I don't understand why some batch files won't run. (The batch files installs the program selected).

One batch file that doesn't work is for example the above code:

txtCommand.text = "\\network\path\path\acadre.bat

Acadre.bat contains this line:

\\network2\path\path\acadreinst\AcadreClient.bat

The final batch file contains a small amount of code:

rd /s /q %temp%\acadrecache
start /wait msiexec /x{490AFB76-A301-4BAB-8BD5-AE796C304F21} REBOOT=R /qn
regedit /s \\network2\path\path\acadreinst\AcadreClient.reg
regsvr32 /s c:\program files\lotus\notes\nlsxbe.dll
start /wait msiexec /i \\network2\path\path\acadreinst\acadreclient.msi /qb! ADDLOCAL=CM,CM_Core,CM_Core_Shortcuts,CM_EI,CM_GIS,CM_KA,CM_LN,CM_Off2000,CM_Routing REMOVE=MM,MM_Client,MM_Client_Shortcuts,MM_OL,MM_Off2000

I didn't code the batch files, I just need to get them to run via the interface.

Am I doing something wrong or is it possible to code the last batch inside vb and drop the batch files?

[jmcilhinney]

I have a few issues with your code. I hate Hungarian notation personally, but if you're going to use it you should try to be consistent. "txt" implies a TextBox while "lbl" implies a Label. Also, you appear to not have used a prefix for what I assume is the Button Arcadre. Also, why would you use a hidden Label? Why would you not just use a String variable?

As for your issue, how are you actually running the batch file?

[nbmprivat]

Forgot about that. Sorry.

Private Sub startThread()
        Dim CMDThread As New Threading.Thread(AddressOf CMDAutomate)
        CMDThread.Start()
    End Sub
 
    Private Sub CMDAutomate()
        Control.CheckForIllegalCrossThreadCalls = False
        Dim myprocess As New Process
 
        Dim StartInfo As New System.Diagnostics.ProcessStartInfo
        StartInfo.FileName = "cmd" 'starts cmd window
        StartInfo.RedirectStandardInput = True
        StartInfo.RedirectStandardOutput = True
        StartInfo.UseShellExecute = False 'required to redirect
        myprocess.StartInfo = StartInfo
        myprocess.Start()
        Dim SR As System.IO.StreamReader = myprocess.StandardOutput
        Dim SW As System.IO.StreamWriter = myprocess.StandardInput
        SW.WriteLine(txtCommand.Text) 'the command you wish to run.....
        SW.WriteLine("exit") 'exits command prompt window
        txtResults.Text = SR.ReadToEnd
        SW.Close()
        SR.Close()
    End Sub

CMDAutomate writes the output of the cmd screen in the textbox. And I use a hidden textbox, not a label. Sorry again. But that isn't the important part

What do you mean by hungarian code?

[nbmprivat]

No one?