VB Innovative Log-In Form Improvement

[dee-u]

I have made this simple log-in form but I know its not perfect, I will appreciate if if anybody could pinpoint the bugs in it.... I am thinking I could make that textbox into an .ocx, perhaps adding a property that would be displayed as the mask of the control but I still dont have time.....

[Wokawidget]

OK. I'm just gonna list things wrong with it in no particualr order.

Private Function UserIsExisting(ByVal UserPassword As String) As Boolean
    If StrComp(HiddenPassword, "rodelio", 0) = 0 Then
        UserIsExisting = True
    Else
        UserIsExisting = False
    End If
End Function

What is the point of passing the param UserPassword into this function?

There is no X on the login form...how is a user supposed to exit it?

frmDenied.Show 1

Should be:

frmDenied.Show vbModal

Does the same thing, but it uses the correct constant and is easier to read.

Private b As Integer, PasswordLenght As Integer

Don't do this...it makes it hard to see what varibles are declared.
Always do:

Private b As Integer
Private PasswordLenght As Integer

You may want to add naming conventions to your app.

str = string
int = integer
lng = long
bln = boolean
dte = date
cur = currency
dbl = double
sng = single
byt = byte

so you would declare varibles like:

Dim lngCount As Long
Dim dteBirthday As Date
Dim curWage  As Currency

This makes code MUCH MUCH easier to read and to see what's going on.

If the varible if at modular level, ie at the top of the form, for example in your case lets take the varible EnteredValues.
You proceed this with "m" which stands for modular level varible. This would be:

Private mstrEnteredValues As String

I use "p" for parameters passed into functions also, but some coders don't. It's entirely up to you. For example:

Private SUb Login(ByVal pstrUsername As String, Byval pstrPassword As String)
Dim strSQL As String
Dim adoRec As Recordset
    'code to check if username and password are correct in DB
End Sub

Instead of using DoEvents in your Timer1_Timer event I would add the following to the end of the function:

lblKeyIn1.Refresh
lblKeyIn2.Refresh

DoEvents is used far to often in the wrong circumstances This can cause all sorts of unknown and evil problems to occur if you're not carefull...a small exmaple is to create a new project then add the following:

Private Sub Command1_Click()
Dim lngIndex As long
Dim lngOtherNum As Long
   For lngIndex = 1 To 1000000
      DoEvents
      lngOthernum = lngIndex
   Next lngIndex
End Sub

Click the command button and then close your form down by clicking the X. Notice how your app doesn't unload

That's all I can see for starters...but I think the main question is why you would want a login form like this?

Woka