Function Error -C#

[Rahils573]

Hello Everybody:
I am trying to develop a function to concate three strings . When I compile it gives me a runtime error .Can anyone tell me whats wrong?

The error is :

public string Variable(string UserName, string PhoneNumber, string RemoteYN)

{
txtUserName.Text=UserName ;
txtPhoneNumber.Text=PhoneNumber;
txtRemoteString.Text=RemoteYN ;

// Variable;
return Variable(UserName,PhoneNumber,RemoteYN);


}



private void cmdOutPut_Click(object sender, System.EventArgs e)


{ txtOutput.Text= Variable(UserName,PhoneNumber,RemoteYN);
txtOutput.Text = txtUserName.Text + " " + txtPhoneNumber.Text + " " + txtRemoteString.Text;


}


The run time error is : System.StackOverflowException' occurred in system.windows.forms.dll


Pls guide...

Rahil

[dynamic_sysop]

looks like you need to be using a void not a string for Variable , eg:

public void Variable(string UserName, string PhoneNumber, string RemoteYN)
 
{ 
    string strResult = string.Empty; // initialize the string
 
    strResult +=UserName + " " ;
    strResult +=PhoneNumber + " ";
    strResult +=RemoteYN ;
    
    txtOutput.Text = strResult;
}
 
private void cmdOutPut_Click(object sender, System.EventArgs e)
{
    Variable(txtUserName.Text,txtPhoneNumber.Text,txtRemoteString.Text);
}

this line ...

return Variable(UserName,PhoneNumber,RemoteYN);

will be causing the error , because you are trying to return part of the calling string.

[Memnoch1207]

Try using the StringBuilder class, because everytime you concatenate strings it is creating a new instance of the string.

[Magiaus]

why not

return string1 + string2 + string3;

or

string s = "";
s += string1;
s += string2;
s += string3;
return s;