Calculation Error.....Any ideas? [RESOLVED]

[poodle726]

I am taking a beginning VB.NET course, I am having trouble getting this project to calculate properly. I think the calculations are in the wrong place, cause when you uncheck a box (deselect) it continues to hold that value in memory and add it to the total. It also adds all values no matter how many check boxes you check or which discount you apply. Any help would be really appreciated!! We are required to use Option Strict in all programs for this course.

Jennifer

Public Class Form1
    Inherits System.Windows.Forms.Form
 
#Region " Windows Form Designer generated code "
 
  
 
#End Region
    Const mdecMANICURE_PRICE As Decimal = 35D
    Const mdecMAKEOVER_PRICE As Decimal = 125D
    Const mdecHAIRSTYLING_PRICE As Decimal = 60D
    Const mdecPERMANENTMAKEUP_PRICE As Decimal = 200D
    Const mdecDISCOUNT10 As Decimal = 0.9D
    Const mdecDISCOUNT20 As Decimal = 0.8D
    Dim decSubtotal As Decimal
    Private Sub btnExit_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnExit.Click
        'Exit the project
        Me.Close()
    End Sub
    Private Sub btnCalculate_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnCalculate.Click
 
        If chkMakeover.Checked = True Then
            lblMakeover.Text = CStr(mdecMAKEOVER_PRICE)
            lblMakeover.Text = FormatCurrency(mdecMAKEOVER_PRICE)
 
        ElseIf chkMakeover.Checked = False Then
            lblMakeover.Text = ""
            decSubtotal = decSubtotal + mdecMAKEOVER_PRICE
        End If
 
        If chkHairstyling.Checked = True Then
            lblHairstyling.Text = CStr(mdecHAIRSTYLING_PRICE)
            lblHairstyling.Text = FormatCurrency(mdecHAIRSTYLING_PRICE)
 
        ElseIf chkHairstyling.Checked = False Then
            lblHairstyling.Text = ""
            decSubtotal = decSubtotal + mdecHAIRSTYLING_PRICE
        End If
 
        If chkManicure.Checked = True Then
            lblManicure.Text = CStr(mdecMANICURE_PRICE)
            lblManicure.Text = FormatCurrency(mdecMANICURE_PRICE)
        ElseIf chkManicure.Checked = False Then
            lblManicure.Text = ""
            decSubtotal = decSubtotal + mdecMANICURE_PRICE
        End If
 
        If chkPermanentmakeup.Checked = True Then
            lblPermanentmakeup.Text = CStr(mdecPERMANENTMAKEUP_PRICE)
            lblPermanentmakeup.Text = FormatCurrency(mdecPERMANENTMAKEUP_PRICE)
        ElseIf chkPermanentmakeup.Checked = False Then
            lblPermanentmakeup.Text = ""
            decSubtotal = decSubtotal + mdecPERMANENTMAKEUP_PRICE
        End If
 
        If radDiscount10.Checked = True Then
            decSubtotal = decSubtotal * mdecDISCOUNT10
        ElseIf radDiscount20.Checked = True Then
            decSubtotal = decSubtotal * mdecDISCOUNT20
        ElseIf radDiscountNo.Checked = True Then
            decSubtotal = decSubtotal * 1
        End If
        lblTotalDue.Text = FormatCurrency(decSubtotal)
 
    End Sub
 
    Private Sub btnClear_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnClear.Click
        If lblTotalDue.Text <> "" Then
            If IsNumeric(lblTotalDue.Text) Then
 
                chkMakeover.Checked = False
                chkHairstyling.Checked = False
                chkManicure.Checked = False
                chkPermanentmakeup.Checked = False
                lblTotalDue.Text = ""
                lblMakeover.Text = ""
                lblHairstyling.Text = ""
                lblManicure.Text = ""
                lblPermanentmakeup.Text = ""
                decSubtotal = 0
                radDiscount10.Checked = False
                radDiscount20.Checked = False
                radDiscountNo.Checked = False
                txtCustomerName.Clear()
                txtCustomerName.Focus()
            End If
 
        End If
    End Sub
End Class

[nemaroller]

Alright...

the problem was your If ... Then statements. Also, you should have cleared decSubtotal before each Calculate .
I highlighted the changes made in the first If - Else below. The others I changed, but didn't highlight because they follow the same logic.

Private Sub btnCalculate_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnCalculate.Click
 
        [b]decSubtotal = 0[/b]
        If chkMakeover.Checked = True Then
            lblMakeover.Text = CStr(mdecMAKEOVER_PRICE)
            lblMakeover.Text = FormatCurrency(mdecMAKEOVER_PRICE)
           
           [b] decSubtotal += mdecMAKEOVER_PRICE[/b] 'add price to subtotal because box is checked
 
 
        [b]Else 'chmakeover.checked must be false, so do not add price to decsubtotal[/b]
            lblMakeover.Text = ""
        End If
 
        If chkHairStyling.Checked = True Then
            lblHairStyling.Text = CStr(mdecHAIRSTYLING_PRICE)
            lblHairStyling.Text = FormatCurrency(mdecHAIRSTYLING_PRICE)
            decSubtotal += mdecHAIRSTYLING_PRICE
 
 
        Else
            lblHairStyling.Text = ""
        End If
 
        If chkManicure.Checked = True Then
            lblManicure.Text = CStr(mdecMANICURE_PRICE)
            lblManicure.Text = FormatCurrency(mdecMANICURE_PRICE)
            decSubtotal += mdecMANICURE_PRICE
        Else
            lblManicure.Text = ""
 
        End If
 
        If chkPermanentMakeup.Checked = True Then
            lblPermanentMakeup.Text = CStr(mdecPERMANENTMAKEUP_PRICE)
            lblPermanentMakeup.Text = FormatCurrency(mdecPERMANENTMAKEUP_PRICE)
            decSubtotal += mdecPERMANENTMAKEUP_PRICE
        Else
            lblPermanentMakeup.Text = ""
 
        End If
 
        If radDiscount10.Checked = True Then
            decSubtotal = decSubtotal * mdecDISCOUNT10
        ElseIf radDiscount20.Checked = True Then
            decSubtotal = decSubtotal * mdecDISCOUNT20
        ElseIf radDiscountNo.Checked = True Then
            decSubtotal = decSubtotal * 1
        End If
        lblTotalDue.Text = FormatCurrency(decSubtotal)
 
    End Sub

[nemaroller]

The importance here being that when you use IF-Else:

If checkbox is checked then
'do something
Else
'obviously the checkbox is not checked
'do something else
End If

[poodle726]

Thanks nemaroller....worked like a charm!!! I appreciate your help!!!

Jennifer