problem passing parameters to function that is a parameter itself in setTimeout()

[bsw2112]

Hello

I am having a small problem which I thought I resolved a while back...unfortunately it's back

it's a dropdown layer that waits 1 second before closing.


here is my code

<script>
var delay;
function swap()
{ 
   var nameOfLayer = swap.arguments[0];
   if(window.delay)
 {
  clearTimeout(delay);
 }
  
   if(swap.arguments[1] == 1)
 {
    document.getElementById(nameOfLayer).style.visibility = "visible";
 }
 else
 {
  document.getElementById(nameOfLayer).style.visibility = "hidden";
 }
}

function wait()
{
 var n = wait.arguments[0];
 delay = setTimeout("swap(' + n + ',2)",1000);

           //   if i change ' + n + ' to the name of layer it works fine
           //   delay = setTimeout("swap('lay1',2)",1000);


}

</script>

here is how I call the function

 <p><a href = "" onMouseover="swap('lay1',1)" onMouseout="wait('lay1')" >Wawryn Classroom</a></p>

i always have problems passing parameters to a function that is itself a parameter of the setTimeout function

any help will be appreciated

bsw

[RealisticGraphics]

You've almost got it. In your wait function change the ' + n + ' to '" + n + "'.

Basically the string is not being compiled correctly. Here's what the function would look like.

function wait()
{
 var n = wait.arguments[0];
 delay = setTimeout("swap('" + n + "',2)",1000);
}

I'd also recommend placing your arguments as named parameters of the function. It is easier to read and can save some coding.

[bsw2112]

right on

this will work

ya i normaly put the params in, but i was being lazy

thanks for the tips

bsw

[CornedBee]

You chose a more difficult, longer to write and more complicated approach because you were LAZY?

[bsw2112]

yes

if I wouldn't be lazy I would read more javascript tutorials and wouldn't be getting stuck every two seconds


what is the correct approach CornedBee?

how can I make it more efficient and generic

bsw