onerror probs

[VBarak]

i have this code :
_________________________________________
On Error GoTo ErrHandler
path = GetSetting(App.EXEName, "path", "dir")
ErrHandler:
Call errorpad
____________________________________
my program always calls the "errorpad" procedure, no matter what, even if there is no problem (no error should be accured).

if i write only:
_______________________________________
path = GetSetting(App.EXEName, "path", "dir)
_________________________________________

then my program is working just fine and no error msgs or debuger are being loaded.
I guess that means there wasn't a problem in the first place and the "errorpad" shouldnt be load befor.

Is my vb trying to confuse me?how can i fix this problem?

[Frans C]

This is normal behaviour.
If an errro occurs, the execution jumps to the label you specified.
If no error occurs, the execution jumps to the next line (or where the code guides it to).

If you use the On Error Goto statement, you need to make sure that the code in the error handler is not executed when no error occurs.

You can do this in two ways.

1. By putting an Exit Sub or Exit Function statement before the error handler.

Sub Test
    On Error GoTo ErrHandler 
    path = GetSetting(App.EXEName, "path", "dir") 
    Exit Sub
ErrHandler: 
    Call errorpad 
End Sub
 
Function Test2
    On Error GoTo ErrHandler 
    path = GetSetting(App.EXEName, "path", "dir") 
    Exit Function
ErrHandler: 
    Call errorpad 
End Function

2. By checking Err.Number in your error handler

Sub Test
    On Error GoTo ErrHandler 
    path = GetSetting(App.EXEName, "path", "dir") 
ErrHandler: 
    If Err.Number <> 0 Then
        Call errorpad 
    End if
End Sub

I prefer the first approach.

[VBarak]

the exit sub is not working very well....even if there is an error it exits the sub
its the opposite problem of what i have had
ill now go try the other option you gave
hope itll work!

[Frans C]

Are you sure that there is an error?
GetSetting doesn't produce an error that fast. Which error do you think you should get?

[Joacim Andersson]

Actually GetSetting doesn't raise any errors, if the specified key doesn't exist it returns the default value, an empty string in your case.

[techgnome]

I would like to add one more itme of note: If you plan to use errorpad to trap & log errors, then you will/should capture the ErrorNumber before calling it.

Sub Test
    On Error GoTo ErrHandler 
    path = GetSetting(App.EXEName, "path", "dir") 
    Exit Sub
ErrHandler: 
Dim errNum As Long
    errNum = Err.Number
    Call errorpad errNum
End Sub

The reason is because the Err object is global in scope, the call to errorpad is sucessful, Err will get reset to no error.
This has caused a many painful debugging sessionsaround here until we caught on.

[VBarak]

you right....it does return the defult key if my key is not exist...
so if that is the case:
how can i check if the registry key is existed?

[Frans C]

path = GetSetting(App.EXEName, "path", "dir", "damn, I can't find it.")
If path = "damn, I can't find it." Then
    Msgbox "Nothing there."
End If