Reading File into an array [RESOLVED, and then some]

[Cagez]

I've opened the file successfully and put it into a textbox, but now I want to do separate lines... I've come up with this but it always makes an error...

opnFile.ShowDialog()
        fn = opnFile.FileName ' file name
        sr = File.OpenText(fn) ' my stream reader
 
        Dim x() As String
        While sr.Peek <> -1
            x(x.Length + 1) = sr.ReadLine()
        End While
 
        txtDisplay.Lines = x
        sr.Close()

[Static]

use the split function

Split by vbcrlf

[Cagez]

... care to elaborate?

[Guile.NET]

opnFile.ShowDialog()
Dim fn As String = opnFile.FileName
Dim sr As New StreamReader(fn)
Dim x As String = sr.ReadToEnd()
sr.Close()
textbox.text = x

It isn't reading into an array, however, if you only plan on opening a text file, it won't matter.

[Cagez]

It needs to be an array, Guile.NET

[Static]

sorry

Dim temp As String
temp = txtNote.Text 'txtNote is the textbox
Dim txtSplit() As String
txtSplit = temp.Split(vbLf)

if vbLf doesnt work..try vbCr or vbCrLf
vbLf was the one that worked for me...

[Guile.NET]

I'm still working on this Class, but if you can use what I have, more power to you:

Option Compare Binary : Option Explicit On  : Option Strict On
 
Imports System.IO
 
Public Class InputStream
 
    Event ReadComplete(ByVal Buffer() As Byte)
    Event ReadError(ByVal ErrorMessage As String)
 
    Private g_File As String
    Private g_BufferSize As Integer
 
    Public Sub New(ByVal AbsFilePath As String, ByVal BufferSize As Integer)
        If File.Exists(AbsFilePath) Then
            g_File = AbsFilePath
            g_BufferSize = BufferSize
        End If
    End Sub
 
    Public Sub BeginRead()
        Dim ReadThread As New Threading.Thread(AddressOf DoRead)
        ReadThread.Start()
    End Sub
 
    Private Sub DoRead()
        Dim ByteArray() As Byte, InputBuffer() As Byte
        ReDim InputBuffer(g_BufferSize)
        Dim Stream As BinaryReader
        Try
            Stream = New BinaryReader(New FileStream(g_File, FileMode.Open, FileAccess.Read, FileShare.None), System.Text.Encoding.UTF8)
            Do
                InputBuffer = Stream.ReadBytes(InputBuffer.Length)
                ByteArray = AppendArray(ByteArray, InputBuffer)
            Loop Until Stream.BaseStream.Position = Stream.BaseStream.Length
        Catch e As Exception
            RaiseEvent ReadError(e.Message)
        Finally
            Stream.Close()
            RaiseEvent ReadComplete(ByteArray)
        End Try
    End Sub
 
    Private Function AppendArray(ByRef BaseArray() As Byte, ByRef Buffer() As Byte) As Byte()
        Dim WriteIndex As Integer
        Select Case IsArray(BaseArray)
            Case False
                ReDim BaseArray(Buffer.Length - 1)
                WriteIndex = 0
            Case True
                ReDim Preserve BaseArray(BaseArray.Length + (Buffer.Length - 1))
                WriteIndex = BaseArray.Length - Buffer.Length
        End Select
        Buffer.CopyTo(BaseArray, WriteIndex)
        Return BaseArray
    End Function
 
End Class

Usage:

Dim WithEvents Input As InputStream
 
    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        Input = New InputStream(TheFile, 255)
        Input.BeginRead()
    End Sub
 
    Private Sub Input_ReadComplete(ByVal ByteArray() As Byte) Handles Input.ReadComplete
        RTB.Text = System.Text.Encoding.UTF8.GetString(ByteArray)
    End Sub

If you can tweak it, can you post it please?

[Cagez]

Thanks you guys.

[LGS]Static, your code with a little tweaking works like a charm, thank you

[Static]

glad I could help..im still learning vb.net its a bit different from VB6

Just for curiosity (and for future reference) what did you tweak?

[Cagez]

Well I had to customize it a bit for starters And, to get the lines from the file to display on different lines in the text box, I had to use txtMyBox.Lines.

So I came out with this, which is basically your code

sr = File.OpenText(fn)
            Dim x As String = sr.ReadToEnd
            sr.Close()
 
            txtDisplay.Lines = Split(x, vbLf)

Thanks again

[Guile.NET]

I thought you said it needed to be an array?

[Cagez]

It is an array Guile, x gets all the text from the file them splits it into an array.

[Guile.NET]

My Initial Code:

opnFile.ShowDialog()
Dim fn As String = opnFile.FileName
Dim sr As New StreamReader(fn)
Dim x As String = sr.ReadToEnd()
sr.Close()
textbox.text = x

It isn't reading into an array, however, if you only plan on opening a text file, it won't matter.

Your Reply:

It needs to be an array, Guile.NET

The code you used:

sr = File.OpenText(fn)
            Dim x As String = sr.ReadToEnd
            sr.Close()

By your own definition... that is not an array.

All you did was load the file into a string (x), of which you split up, as if in an array - there is a big difference!

Nonetheless, splitting it is a waste of time; the following code will do exactly the same thing:

txtDisplay.Text = x

[Cagez]

Guile, all I needed was the ned result to be an array and static helped me with that.

As for splitting being a waste of time, no its not. If I just add the text to the text box, the file will go all on the same line, no matter whats in the file. By splitting it into lines, everything is displayed as if you were to open it in notepad.

[Static]

Cagez... Guile is right. There is no need for any array or Split function


try this:

Dim sr As System.IO.StreamReader = System.IO.File.OpenText("c:\Path\file.txt")
Dim txt As String = sr.ReadToEnd
TextBox1.Text = txt
sr.Close()

this should work....

[Cagez]

That was not working before! When I did that before it kept putting everything on the same line!

But yes, now it is working If you read the entire file into a variable, though, isn't that hard on the memory?

(Thanks Guile for pointing that out, btw)

[Static]

no..not hard at all on mem (unless your trying to load txt files that are HUGE!)

but it is better on performance...if you have a 2000 line txt file
and read it in line by line...that will consume cpu
whereas if you get it all in one chomp...much quicker

[Cagez]

Ahh, I see...

Well thank you Static and thank you Guile!

I thought the only way to get it on separate lines was the way I was doing it, I though I was doing it Guile's way, but I was actually reading line-by-line then adding it to the text box, thats why everything was on the same line.

Thanks again

[Guile.NET]

There is a property for the textbox that defines whether it is multi-lined, or single. Somehow, unbeknown to you, you have changed it to multi.

For future reference, the property name is 'Multiline'.

[ViewSonic1]

I could be wrong..... but wont this get rid of your varible.

        Dim sr As System.IO.StreamReader = System.IO.File.OpenText("c:\file.txt")
        TextBox1.Text = sr.ReadToEnd
        sr.Close()

[Cagez]

Guile, it is set to multiline purposely

[Guile.NET]

I meant when it was only reading to one line, and then miraculously began using many.