Hello! Id like some help with my bubblesort code

[Huntington]

So basically my bubblesort isnt working no matter what i do it doesnt work. Basically im trying to make an application where the user uploads a text file that includes numbers and it bubblesorts them everything works fine but not bubblesorting would anyone help me and tell me whats wrong? and can someone too explain in simplified terms since im new

[Huntington]

Attachment 191264Attachment 191264 it is basically like this

[PlausiblyDamp]

So when you say it isn't working, what exactly is happening? Is it not sorting at all? Sorting in an incorrect way? Hanging?

You are much more likely to get help when you provide a useful description of the problem.

[.paul.]

Private Sub BubbleSort(ByRef x As List(of String))

[.paul.]

Also x is a List(Of String), which you’re trying to sort as a List(Of Integer).
You need to explicitly convert.

Dim i, a As Integer
Dim t As String
For 1 = 0 To x. Count - 1
    For a = i + 1 To x.Count - 1
        If CInt(x (i)) > CInt(x(a)) Then
           t=x(i)
           x(i) = x(a)
           x(a) = t
        End If
    Next
Next

[Huntington]

it isnt sorting at all like its giving the same numbers as before sorting

[Huntington]

it says i got this error

[.paul.]

Attachment 191266 it says i got this error

If you’re posting code, use plain text and the forum formatting.
If you have an error, I don’t want to have to open an attachment, which may or may not work…

[.paul.]

For i = 0 to…

[Huntington]

I apologize, i copied this code (from you) and im getting an error called BC30074: Constant cannot be the target of an assignment.

Dim i, a As Integer
Dim t As String
For 1 = 0 To x. Count - 1
For a = i + 1 To x.Count - 1
If CInt(x (i)) > CInt(x(a)) Then
t=x(i)
x(i) = x(a)
x(a) = t
End If
Next
Next

[Huntington]

the error still persists (the numbers arent being sorted)

[.paul.]

The errors you’re seeing now are a result of what I’ve copied and pasted. You’ll have to type it out again. The important part is using the correct types for your variables, and converting the elements of x to integer, which will sort differently to standard string sorting. Also pass your List(Of String) ByRef

[.paul.]

Dim i, a As Integer
Dim t As String
For i = 0 To x. Count - 1
    For a = i + 1 To x.Count - 1
        If CInt(x (i)) > CInt(x(a)) Then
            t=x(i)
            x(i) = x(a)
            x(a) = t
        End If
    Next
Next

[Huntington]

it still persists and yes i retyped it, if needed here is my whole code:




' Read the numbers from the ListBox
Dim numbers As New List(Of Integer)
For Each item As Object In lstNumbers.Items
numbers.Add(CInt(item))
Next

' Sort the numbers using bubble sort
BubbleSort(numbers)

' Display the sorted elements in the lstSortedNumbers ListBox
lstSortedNumbers.Items.Clear()
For Each num In numbers
lstSortedNumbers.Items.Add(num)
Next
End Sub

' Bubble sort function
Private Sub BubbleSort(ByRef x As List(Of Integer))
Dim i, a As Integer
Dim t As String
For i = 0 To x.Count - 1
For a = i + 1 To x.Count - 1
If CInt(x(i)) > CInt(x(a)) Then
t = x(i)
x(i) = x(a)
x(a) = t
End If
Next
Next
End Sub

[.paul.]

Now you've changed all of your datatypes, instead of just those i highlighted. Try exactly this..

' Read the numbers from the ListBox
Dim numbers As New List(Of Integer)
For Each item As Object In lstNumbers.Items
numbers.Add(CInt(item))
Next

' Sort the numbers using bubble sort
BubbleSort(numbers)

' Display the sorted elements in the lstSortedNumbers ListBox
lstSortedNumbers.Items.Clear()
For Each num In numbers
lstSortedNumbers.Items.Add(num)
Next
End Sub

' Bubble sort function
Private Sub BubbleSort(ByRef x As List(Of Integer))
    Dim i, a, t As Integer
    For i = 0 To x.Count - 1
        For a = i + 1 To x.Count - 1
            If x(i) > x(a) Then
                t = x(i)
                x(i) = x(a)
                x(a) = t
            End If
        Next
    Next
End Sub

[Huntington]

alright

[.paul.]

If that doesn't work, tell me the exact error, and the code where it breaks.

[Huntington]

Its basically like this

[Huntington]

the numbers wont bubblesort no matter what i do..

[.paul.]

Are your original listbox items just numbers or numbers and text?

[Huntington]

just numbers also im using a system where the user would upload a notepad file with numbers only in them to bubblesort

[.paul.]

How many items does your unsorted list contain?

[Huntington]

6 digits of numbers

[.paul.]

Your screenshot in post #18 only shows 1 integer number??? Where are the others?

[Huntington]

sorry i meant that, thats the only integers there

[.paul.]

You mean 1 six digit number?
So 684723, you want to sort as 234678? That's not anywhere near what your code does

[Huntington]

i just want it to bubblesort thats all

[Huntington]

i meant those numbers there on the post

[Huntington]

so to work i need to have multiple integers for it to work?

[OptionBase1]

By definition, a list of 1 item IS sorted. Both in ascending and descending order. It's like magic.

[.paul.]

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
    Dim numbers() As Integer = Array.ConvertAll(lstNumbers.Items(0).ToString.ToCharArray, Function(c As Char) CInt(c.ToString))

    ' Sort the numbers using bubble sort
    BubbleSort(numbers)
    ' Display the sorted elements in the lstSortedNumbers ListBox
    lstSortedNumbers.Items.Clear()
    For Each num In numbers
        lstSortedNumbers.Items.Add(num)
    Next

End Sub

' Bubble sort function
Private Sub BubbleSort(ByRef x() As Integer)
    Dim i, a, t As Integer
    For i = 0 To x.Count - 1
        For a = i + 1 To x.Count - 1
            If x(i) > x(a) Then
                t = x(i)
                x(i) = x(a)
                x(a) = t
            End If
        Next
    Next
End Sub

[OptionBase1]

By the way, this screams of someone in complete panic mode trying to turn in an assignment before the end of a term so that they don't fail a class. Just saying.

[Huntington]

dude you are a life saver thank you so much i would literraly buy you a drink if its possible, biggest thanks to you

[.paul.]

My last post will display your numbers as..

2
3
4
6
7
8

to display as...

234678

, use this code...

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
    Dim numbers() As Integer = Array.ConvertAll(lstNumbers.Items(0).ToString.ToCharArray, Function(c As Char) CInt(c.ToString))

    ' Sort the numbers using bubble sort
    BubbleSort(numbers)
    Dim newNumber As Integer = CInt(String.Join("", Array.ConvertAll(numbers, Function(x) x.ToString)))
    ' Display the sorted elements in the lstSortedNumbers ListBox
    lstSortedNumbers.Items.Clear()
    lstSortedNumbers.Items.Add(newNumber)

End Sub

[Huntington]

thank you dude a million thanks to you

[Huntington]

thats true i have like 2 weeks to submit which is emough time but i like to start early