[RESOLVED] replace strings in list1

[doberman2002]

replace all strings in list1 matching a string.

text1.text = love you

list1 =

love you all now
genreal love you
love you tonight 
i will love you again darling
love you now forever

replace all love you

[Arnoutdv]

Look up the help for the Replace() function
I assume you know how to iterate through all items of a Listbox?

[doberman2002]

Look up the help for the Replace() function
I assume you know how to iterate through all items of a Listbox?

Private Sub Command2_Click()
Dim i As Long
On Error Resume Next
For i = 0 To List1.ListCount - 1
    If InStr(List1.List(i), Text1.Text) Then
List1.List(i) = Replace(List1.List(i), Text1, "")

    End If
Next
End Sub

Text1.text = love you
it removes the first item., it should have removed all of it

What i think its wrong is the find string cannot detect the main ( string ) in a sentence mixed with other string. Target love you but mixed with love you xxx xxx string

even tried this says only found in index = 0

Private Const LB_ERR = -1
Private Const LB_FINDSTRINGEXACT = &H1A2
Private Const LB_FINDSTRING = &H18F

Private Declare Function SendMessage Lib "USER32" _
    Alias "SendMessageA" (ByVal hWnd As Long _
    , ByVal wMsg As Long _
    , ByVal wParam As Integer _
    , ByVal lParam As Any) As Long

Public Function GetListBoxIndex(hWnd As Long _
    , SearchKey As String _
    , StartIndex As Long _
    , Optional FindExactMatch As Boolean = True) As Long
    If FindExactMatch Then
        GetListBoxIndex = SendMessage(hWnd, LB_FINDSTRINGEXACT, StartIndex, SearchKey)
    Else
        GetListBoxIndex = SendMessage(hWnd, LB_FINDSTRING, StartIndex, SearchKey)
         Debug.Print GetListBoxIndex
    End If
    
   
End Function

Private Sub PrintAllMatches(hWnd As Long, SearchKey As String)
    Dim firstMatch As Long, nextMatch As Long
    nextMatch = GetListBoxIndex(hWnd, SearchKey, -1, False)
    If nextMatch = LB_ERR Then
        Debug.Print "Not found"
        Exit Sub
    End If

    firstMatch = nextMatch
    Do
        Debug.Print "Match is at index " & nextMatch
        nextMatch = GetListBoxIndex(hWnd, SearchKey, nextMatch, False)
    Loop While nextMatch <> firstMatch
End Sub
Private Sub Command4_Click()
GetListBoxIndex List1.hWnd, Text1, 0, False
End Sub

[DataMiser]

Instr as used will be case sensitive but yes it will find love you if it exists anywhere in the string no matter where it is as long as all those characters appear together as they are in your search string.

That said you do not really even need the If test. Replace will replace only that phrase and only if it exists.

Get rid of the On Error Resume Next

[DataMiser]

I tried your code and it works as expected. I removed the On Error Resume next as it should not have been there not that it would have caused a problem just that it should not be used in any but limited cases.

Option Explicit
Private Sub Form_Load()
List1.AddItem "love you all now"
List1.AddItem "genreal love you"
List1.AddItem "love you tonight"
List1.AddItem "i will love you again darling"
List1.AddItem "love you now forever"

Text1.Text = "love you"
End Sub
Private Sub Command1_Click()
Dim i As Long

For i = 0 To List1.ListCount - 1
    If InStr(List1.List(i), Text1.Text) Then
        List1.List(i) = Replace(List1.List(i), Text1.Text, "")
    End If
Next

It also works without the If test

[doberman2002]

I tried your code and it works as expected. I removed the On Error Resume next as it should not have been there not that it would have caused a problem just that it should not be used in any but limited cases.

Option Explicit
Private Sub Form_Load()
List1.AddItem "love you all now"
List1.AddItem "genreal love you"
List1.AddItem "love you tonight"
List1.AddItem "i will love you again darling"
List1.AddItem "love you now forever"

Text1.Text = "love you"
End Sub
Private Sub Command1_Click()
Dim i As Long

For i = 0 To List1.ListCount - 1
    If InStr(List1.List(i), Text1.Text) Then
        List1.List(i) = Replace(List1.List(i), Text1.Text, "")
    End If
Next

It also works without the If test

[Arnoutdv]

Add a Trim$() around the Replace$()

[doberman2002]

Add a Trim$() around the Replace$()

am new to trimm can you show me

[Arnoutdv]

Look up the help, come on man!
Just press F1 for the help

[doberman2002]

Look up the help, come on man!
Just press F1 for the help

List1.List(i) = Replace(List1.List(i), Text1.Text, "")

is that the right way

[ChrisE]

List1.List(i) = Replace(List1.List(i), Text1.Text, "")

is that the right way

you didn't bother pressing F1
if that's your answer

[doberman2002]

you didn't bother pressing F1
if that's your answer

f1 brings error

[LaVolpe]

Yeah, F1 may not work if the msdn library wasn't installed.

In my signature below is a link to msdn 'on-line' help files for VB6. You may want to bookmark it. Even to this day, I hit that site a couple times a month to refresh my memory on this or that.

[DataMiser]

It is a simple method just typing in the word trim in the ide should give you enough of a hint to figure it out but here is a simple example.

MyString=Trim(MyString)

The reason you were seeing those spaces is because replace replaces exactly what you tell it to replace and since you have a space in the original string that is not part of the replacement criteria it is left untouched which is exactly how it should happen.

For trimming you have 3 methods LTrim() RTrim() and Trim()

[SamOscarBrown]

dubiousman....If you want to get rid of the spaces left after removing text1.text (trimmed of spaces), simply try this...

Private Sub Command1_Click()
    Dim i As Long
    For i = 0 To List1.ListCount - 1
        If InStr(List1.List(i), Trim(Text1.Text)) Then
            List1.List(i) = Replace(Trim(Replace(List1.List(i), Trim(Text1.Text), "")), "  ", " ")
        End If
    Next
End Sub

EDIT: Notice that one of the Replace functions will replace any double-space left in a line with a single space

[doberman2002]

thank you sam. and all