[RESOLVED] Condense code...

[BrailleSchool]

Hi, how would you condense this into on with instead of multiple due to them all having the same values but different number?

Private Sub Form_Load()
    Call Button_Captions
    Call Label_Captions
    
    Me.BackColor = vbBlue
    
'THIS DOESNT WORK SO PROBABLY GOING WRONG SOMEWHERE.  WANT
'TO CONDENSE THE ONES BELOW INTO ONE INSTEAD OF MULTIPLE.
    Dim intFrame As Integer
    With Frame(intFrame)
        .BackColor = vbBlue
        .ForeColor = vbWhite
    End With
    
    'With Frame(0)
    '    .BackColor = vbBlue
    '    .ForeColor = vbWhite
    'End With
    
    'With Frame(1)
    '    .BackColor = vbBlue
    '    .ForeColor = vbWhite
    'End With
    
    'With Frame(2)
    '    .BackColor = vbBlue
    '    .ForeColor = vbWhite
    'End With
 
    'With Frame(3)
    '    .BackColor = vbBlue
    '    .ForeColor = vbWhite
    'End With
    
    'With Frame(4)
    '    .BackColor = vbBlue
    '    .ForeColor = vbWhite
    'End With
    
    'With Frame(5)
    '    .BackColor = vbBlue
    '    .ForeColor = vbWhite
    'End With
    
    'With Frame(6)
    '    .BackColor = vbBlue
    '    .ForeColor = vbWhite
    'End With
End Sub

[RhinoBull]

You can loop through control array (sample below) or controls collection (if you don't have control array):

Dim i%
 
On Error Resume Next
 
For i = Frame.Lbound To Frame.Ubound
    Frame(i).BackColor = vbBlue
    Frame(i).ForeColor = vbWhite
Next i

[Mark Gambo]

Hi, how would you condense this into on with instead of multiple due to them all having the same values but different number? . . .

I think this is what you want:

Private Sub Form_Load()
Dim a as Long
 
    Call Button_Captions
    Call Label_Captions
    
    Me.BackColor = vbBlue
       
     With Frame
           For a = .LBound to .UBound    
                With .Item(a)
                     .BackColor = vbBlue
                     .ForeColor = vbWhite
                End With
           Next a '<==== Edit  :blush:  :blush: 
     End With
End Sub

[Mark Gambo]

Rats, you beat me again!!!!!!

[umilmi81]

I'll be a jerk and point out that

With Frame(intFrame)
     .BackColor = vbBlue
     .ForeColor = vbWhite
End With

is more lines than

Frame(intFrame).BackColor = vbBlue
Frame(intFrame).ForeColor = vbWhite

[BrailleSchool]

I think this is what you want:

Private Sub Form_Load()
Dim a as Long
 
    Call Button_Captions
    Call Label_Captions
    
    Me.BackColor = vbBlue
       
     With Frame
           For a = .LBound to .UBound    
                With .Item(a)
                     .BackColor = vbBlue
                     .ForeColor = vbWhite
                End With
     End With
End Sub

Compile error:
end with without with. (last end with -- interesting)

[BrailleSchool]

You can loop through control array (sample below) or controls collection (if you don't have control array):

Dim i%
 
On Error Resume Next
 
For i = Frame.Lbound To Frame.Ubound
    Frame(i).BackColor = vbBlue
    Frame(i).ForeColor = vbWhite
Next i

thanks for the sample Rhino. % is the same as a long right?

[Mark Gambo]

I'll be a bigger jerk and point out that

With Frame(intFrame)
     .BackColor = vbBlue
     .ForeColor = vbWhite
End With

requires only 61 characters

Frame(intFrame).BackColor = vbBlue
Frame(intFrame).ForeColor = vbWhite

While requires 65 characters (including spaces)

[chemicalNova]

% are integers. ! are longs.
chem

[Mark Gambo]

Compile error:
end with without with. (last end with -- interesting)

ah, I forgot the "Next A", I'll fix my code and it will work now. That's what I get when I don't test my code before posting.

[RhinoBull]

thanks for the sample Rhino. % is the same as a long right?

You're welcome.
% is a shortcut for Integer. When it comes to Control Arrays - Integer type is more than enough.

[BrailleSchool]

You're welcome.
% is a shortcut for Integer. When it comes to Control Arrays - Integer type is more than enough.

Learn something new every day! love shortcuts. will have to go to MSDN online to see if i can read up about this stuff. would rather type on char instead of the whole darned thing.

[RhinoBull]

% are integers. ! are longs.
chem

Sorry, but second type is wrong:
! - Single

To find out more run ths sample:

Private Sub Command1_Click()
Dim var1%, var2&, var3#, var4!, var5@, var6$, var7, var8 As Object
 
    Debug.Print "var1: " & TypeName(var1)
    Debug.Print "var2: " & TypeName(var2)
    Debug.Print "var3: " & TypeName(var3)
    Debug.Print "var4: " & TypeName(var4)
    Debug.Print "var5: " & TypeName(var5)
    Debug.Print "var6: " & TypeName(var6)
    Debug.Print "var7: " & TypeName(var7)
    Debug.Print "var8: " & TypeName(var8)
 
End Sub

[RhinoBull]

Learn something new every day! love shortcuts. will have to go to MSDN online to see if i can read up about this stuff. would rather type on char instead of the whole darned thing.

LOL... I wouldn't recommend to use it too often - only "old timers" may recognize these symbols - all "new commers" will get lost and frustrated, though.

[BrailleSchool]

LOL... I wouldn't recommend to use it too often - only "old timers" may recognize these symbols - all "new commers" will get lost and frustrated, though.

i would rather be an "old timer" than wear my keyboard out lol. anyway, i am old, im almos 30. lol.

[RhinoBull]

Yea, sounds like old and it's OK with me. Use TypeName() if you ever need to find type of your variable (see sample code in one of my previous posts).

[BrailleSchool]

Sorry, but second type is wrong:
! - Single

To find out more run ths sample:

Private Sub Command1_Click()
Dim var1%, var2&, var3#, var4!, var5@, var6$, var7, var8 As Object
 
    Debug.Print "var1: " & TypeName(var1)
    Debug.Print "var2: " & TypeName(var2)
    Debug.Print "var3: " & TypeName(var3)
    Debug.Print "var4: " & TypeName(var4)
    Debug.Print "var5: " & TypeName(var5)
    Debug.Print "var6: " & TypeName(var6)
    Debug.Print "var7: " & TypeName(var7)
    Debug.Print "var8: " & TypeName(var8)
 
End Sub

made a small app with this info so i dont forget. enclosed for all us young-timers lol