[STILL UNRESOLVED] destroy timer question

my splash screen fades in to display the splash screen and then after X seconds, it automatically closes and then displays the login form. i would like to destroy the timer (set = nothing). I have done this when the user clicks on the splash screen but where would I set it for when the form closes after X seconds? Would this be in Form_QueryUnload, Form_Terminate or Form_Unload??

seems i am doing it wrong because i am getting an error:

Quote:

---

compile error:
invalid use of property

---

VB Code:

Private Sub imgSplash_Click()
    'when the splash screen is clicked on, set the timer to nothing so that the
    'login form doesnt haunt the end user
    Set tmrSplash = Nothing ' <--------------------------errors here
    
    frmLoginForm.Show
    
    Unload Me
End Sub

complete code:

VB Code:

Option Explicit
 
Private Declare Function GetWindowLong Lib "user32" Alias "GetWindowLongA" (ByVal hwnd As Long, _
                                                                            ByVal nIndex As Long) As Long
 
Private Declare Function SetWindowLong Lib "user32" Alias "SetWindowLongA" (ByVal hwnd As Long, _
                                                                            ByVal nIndex As Long, _
                                                                            ByVal dwNewLong As Long) As Long
 
Private Const GWL_EXSTYLE      As Long = (-20)
Private Const WS_EX_LAYERED    As Long = &H80000
 
Private Declare Function SetLayeredWindowAttributes Lib "user32" (ByVal hwnd As Long, _
                                                                  ByVal crKey As Long, _
                                                                  ByVal bAlpha As Byte, _
                                                                  ByVal dwFlags As Long) As Long
 
Private Const LWA_ALPHA        As Long = &H2
Private lngForNum              As Long
Private lngStyle               As Long
Private bolActive              As Boolean
 
Private Sub Form_Activate()
    If Not bolActive Then
        bolActive = True
 
        For lngForNum = 10 To 255
            MakeWindowTransparent Me.hwnd, lngForNum
            DoEvents
        Next
    End If
End Sub
 
Private Sub Form_Load()
    MakeWindowTransparent Me.hwnd, 10
End Sub
 
Private Sub Form_QueryUnload(Cancel As Integer, UnloadMode As Integer)
    'when the splash screen is automatically closed, set the timer to nothing so that the
    'login form doesnt haunt the end user
    Set tmrSplash = Nothing
End Sub
 
Private Sub Form_Terminate()
    'when the splash screen is clicked on, set the timer to nothing so that the
    'login form doesnt haunt the end user
    Set tmrSplash = Nothing
End Sub
 
Private Sub Form_Unload(Cancel As Integer)
    'when the splash screen is clicked on, set the timer to nothing so that the
    'login form doesnt haunt the end user
    Set tmrSplash = Nothing
End Sub
 
Private Sub imgSplash_Click()
    'when the splash screen is clicked on, set the timer to nothing so that the
    'login form doesnt haunt the end user
    Set tmrSplash = Nothing
    
    frmLoginForm.Show
    
    Unload Me
End Sub
 
Public Sub MakeWindowTransparent(ByVal lngHwnd As Long, _
                                 ByVal bytRate As Byte)
    
    lngStyle = GetWindowLong(lngHwnd, GWL_EXSTYLE)
    lngStyle = lngStyle Or WS_EX_LAYERED
    SetWindowLong lngHwnd, GWL_EXSTYLE, lngStyle
    SetLayeredWindowAttributes lngHwnd, 0, bytRate, LWA_ALPHA
End Sub
 
Private Sub tmrSplash_Timer()
    frmLoginForm.Show
    tmrSplash.Enabled = False
    Unload Me
End Sub

I wouldn't think you would need to set a control to nothing. That is done with objects (assuming tmrSplash is a VB timer control.)

I believe this is what is causing the "Invalid use of Property"

yes, its a vb timer control. the problem i am having is when i am in my app after login, the damned login screen will just popup. i thought it might have been the timer that was doing it. everywhere else in my app where frmLoginForm is called from is within a click event so it couldnt be those, and also form_unload events so couldnt be that either. need to figure out why the damned login form is haunting me, lol.

In the QueryUnload event of your splash form, I would check to see if frmLogin has already been loaded.

If so, do nothing. If not, then load it.

the login form isnt loaded until the splash form is either clicked on or automatically closed by the timer. when i am in the MDI parent, the login form is haunting me. thats why i am wondering where it is coming from, but alas, cannot figure out where its coming from.

Quote:

---

Originally Posted by BrailleSchool

the login form isnt loaded until the splash form is either clicked on or automatically closed by the timer. when i am in the MDI parent, the login form is haunting me. thats why i am wondering where it is coming from, but alas, cannot figure out where its coming from.

---

Well, it can only be loaded after an explicit .Show has been performed. So, take a look at every place in your code where it says frmLogin.Show

That is where it is coming from.

Quote:

---

Originally Posted by Hack

Well, it can only be loaded after an explicit .Show has been performed. So, take a look at every place in your code where it says frmLogin.Show

That is where it is coming from.

---

These are the places its coming from.
frmAccessDenied = Form_Unload
frmAccessDenied = cmdAccessDeniedOK_Click()
frmInternalSplash = Private Sub cmdLogout_Click()
frmMain = MDIForm_Unload
frmMain = Private Sub mnuLogout_Click() (MDI Form)
frmSplash = Private Sub imgSplash_Click()
frmSplash = Private Sub tmrSplash_Timer()
frmAccountDisabled = Private Sub cmdAccountDisabledOK_Click()
frmAccountDisabled = Private Sub Form_Unload

Is frmSplash your startup form, or is that called from somewhere else?

Is this issue with the login form happening only at startup time, or periodically, throughout the application?

Here's your new code... all I did was comment out the Bold lines... and it worked properly for me...

VB Code:

Option Explicit
 
Private Declare Function GetWindowLong Lib "user32" Alias "GetWindowLongA" (ByVal hwnd As Long, _
                                                                            ByVal nIndex As Long) As Long
 
Private Declare Function SetWindowLong Lib "user32" Alias "SetWindowLongA" (ByVal hwnd As Long, _
                                                                            ByVal nIndex As Long, _
                                                                            ByVal dwNewLong As Long) As Long
 
Private Const GWL_EXSTYLE      As Long = (-20)
Private Const WS_EX_LAYERED    As Long = &H80000
 
Private Declare Function SetLayeredWindowAttributes Lib "user32" (ByVal hwnd As Long, _
                                                                  ByVal crKey As Long, _
                                                                  ByVal bAlpha As Byte, _
                                                                  ByVal dwFlags As Long) As Long
 
Private Const LWA_ALPHA        As Long = &H2
Private lngForNum              As Long
Private lngStyle               As Long
Private bolActive              As Boolean
 
Private Sub Form_Activate()
    If Not bolActive Then
        bolActive = True
 
        For lngForNum = 10 To 255
            MakeWindowTransparent Me.hwnd, lngForNum
            DoEvents
        Next
    End If
End Sub
 
Private Sub Form_Load()
    MakeWindowTransparent Me.hwnd, 10
End Sub
 
Private Sub Form_QueryUnload(Cancel As Integer, UnloadMode As Integer)
    'when the splash screen is automatically closed, set the timer to nothing so that the
    'login form doesnt haunt the end user
    [B]Set tmrSplash = Nothing[/B]
End Sub
 
Private Sub Form_Terminate()
    'when the splash screen is clicked on, set the timer to nothing so that the
    'login form doesnt haunt the end user
    [B]Set tmrSplash = Nothing[/B]
End Sub
 
Private Sub Form_Unload(Cancel As Integer)
    'when the splash screen is clicked on, set the timer to nothing so that the
    'login form doesnt haunt the end user
    [B]Set tmrSplash = Nothing[/B]
End Sub
 
Private Sub imgSplash_Click()
    'when the splash screen is clicked on, set the timer to nothing so that the
    'login form doesnt haunt the end user
    [B]Set tmrSplash = Nothing[/B]
    
    frmLoginForm.Show
    
    Unload Me
End Sub
 
Public Sub MakeWindowTransparent(ByVal lngHwnd As Long, _
                                 ByVal bytRate As Byte)
    
    lngStyle = GetWindowLong(lngHwnd, GWL_EXSTYLE)
    lngStyle = lngStyle Or WS_EX_LAYERED
    SetWindowLong lngHwnd, GWL_EXSTYLE, lngStyle
    SetLayeredWindowAttributes lngHwnd, 0, bytRate, LWA_ALPHA
End Sub
 
Private Sub tmrSplash_Timer()
    frmLoginForm.Show
    tmrSplash.Enabled = False
    Unload Me
End Sub

Make sure you have no references made to the splash form on your login form or any other subsequent form... cause this will cause the splash for to be loaded again...

Plus I would put the entire code for the fade effect in a module, including the declarations and just have a function to it... that way the form doesn't reopen if you were to call eg. frmSplash.GetWindowLong...

Quote:

---

Originally Posted by Hack

Is frmSplash your startup form, or is that called from somewhere else?

Is this issue with the login form happening only at startup time, or periodically, throughout the application?

---

when you click on the exe icon (on desktop), frmSplash is loaded, then if the user clicks on frmSplash then frmLoginForm is loaded, otherwise frmLoginForm is loaded when the timer reaches its limit and closes frmSplash. Then when the user logins in and the information is wrong, frmAccessDenied comes up. if the account has been disabled (either by an admin or entering wrong info 4x) then frmAccountDisabled is shown. But this is where I am having the problem (when the frmLoginForm is haunting me...) frmMain is the MDI form and I am using an internal form to show buttons called frmInternalSplash, so I am thinking it has to be either frmMain or frmInternalSplash (i am not sure if its the timer on frmSplash.) So least I have narrowed it down to 3 of the forms. However, the .Show is within a click event of cmdLogout (frmInternalSplash) or mnuLogout within frmMain, and of course the MDIForm_Unload event when the red X is clicked on.

Although I am not very good in VB but what I feel is if you make the vb timer interval to 0 it will help you.

Is frmSplash and frmLogin an MDI Child form... cause if it is then that could be where your problem lies...

Check the AutoShowChildren property and make sure it's enabled to false...

Quote:

---

Originally Posted by Protocol

Is frmSplash and frmLogin an MDI Child form... cause if it is then that could be where your problem lies...

Check the AutoShowChildren property and make sure it's enabled to false...

---

no, they are regular forms outside the MDI

Try something like this and see if it works.

Create a public boolean. Something like IsLoggedIn.

After a successful log, set the Boolean to true, and then in every place where frmLogin can be called, prior to calling it, check the state of this Boolean. If it is true, then don't do a .Show

You may need to reset it to False in other places like frmAccessDenied, or whatever. I'm not familiar with exacly how your app works, but this approach may help you out.

Quote:

---

Originally Posted by Hack

Try something like this and see if it works.

Create a public boolean. Something like IsLoggedIn.

After a successful log, set the Boolean to true, and then in every place where frmLogin can be called, prior to calling it, check the state of this Boolean. If it is true, then don't do a .Show

You may need to reset it to False in other places like frmAccessDenied, or whatever. I'm not familiar with exacly how your app works, but this approach may help you out.

---

Ill try it and see what happens. havent done much with flags before

frmAccessDenied is a form that is used like a message box to tell end user that login details are wrong. Same for frmAccountDisabled. I dislike the look of the MsgBox so use forms in their place to make them a little nicer in appearance.

ok, i set the IsLoggedIn to true or false and the frmLoginForm hasnt haunted me yet, let's see if it stays that way. will report back if it doesn't. hope the ghost has been laid to rest. hehehe.

unfortunately, no change. the login form still haunts me.

Quote:

---

Originally Posted by BrailleSchool

unfortunately, no change. the login form still haunts me.

---

Is the problem still coming from one of the three forms that mentioned previously?

I don't understand why you can't just set .Enabled to False ?

Quote:

---

Originally Posted by penagate

I don't understand why you can't just set .Enabled to False ?

---

:confused: Set .Enabled to False for what control?

The Timer. I don't understand why you need a timer for this anyway, maybe I'm being thick.

Quote:

---

Originally Posted by penagate

The Timer. I don't understand why you need a timer for this anyway, maybe I'm being thick.

---

No, you aren't thick...he wants to provide two ways of opening his app from the splash screen.

1. The traditional way of just clicking an Ok button on the splash screen.

2. If nothing is done within X amount of time, the splash screen closes all by itself and calls his login form...hence the use of the timer.

Quote:

---

Originally Posted by Hack

No, you aren't thick...he wants to provide two ways of opening his app from the splash screen.

1. The traditional way of just clicking an Ok button on the splash screen.

2. If nothing is done within X amount of time, the splash screen closes all by itself and calls his login form...hence the use of the timer.

---

so cant it be like this:

-the splash screen is loaded and it fires the timer.
-let the timer do its work until user clicks the button.
-if the user clicks the button before the time (of the timer) completes, then disable the timer.

or am i saying something wrong? :confused:

From the code provided, it seems that the timer is being disabled in the timer event, and not the click event.

From my limited experience, I have found that the timer is activated anytime a control, sub, or any event is triggered on the form that the timer resides.

I suggest disabling the timer in the click event, timer event, and the form unload event.

Quote:

---

Originally Posted by Hack

Is the problem still coming from one of the three forms that mentioned previously?

---

Yes, because those forms are the only places where frmLoginForm is shown (unload and click events)

Quote:

---

Originally Posted by Hack

No, you aren't thick...he wants to provide two ways of opening his app from the splash screen.

1. The traditional way of just clicking an Ok button on the splash screen.

2. If nothing is done within X amount of time, the splash screen closes all by itself and calls his login form...hence the use of the timer.

---

exactly. however, i dont have a button on the splash screen, the splash image is in a picturebox and when the image/picure box is clicked, it closes the splash screen and calls the login form

Quote:

---

Originally Posted by Hack

No, you aren't thick...he wants to provide two ways of opening his app from the splash screen.

1. The traditional way of just clicking an Ok button on the splash screen.

2. If nothing is done within X amount of time, the splash screen closes all by itself and calls his login form...hence the use of the timer.

---

it's right, I think there are something missing, and i think it's a little problem, he should zip the project and send it, to see the whole functions

Quote:

---

Originally Posted by BrailleSchool

Yes, because those forms are the only places where frmLoginForm is shown (unload and click events)

---

And you have incorporate the boolean flag, especially in the .Show on these three forms, right?

If so, then somehow that boolean is getting reset to False when it hits one of them.

I'm almost afraid to ask this question because I just know you are going to say: No ....but I gotta ask anyway....is there any consistent pattern to when your login form shows up uninvited?

Quote:

---

Originally Posted by zeusspider

From the code provided, it seems that the timer is being disabled in the timer event, and not the click event.

From my limited experience, I have found that the timer is activated anytime a control, sub, or any event is triggered on the form that the timer resides.

I suggest disabling the timer in the click event, timer event, and the form unload event.

---

This is what I have so far for frmSplash

VB Code:

Option Explicit
 
Private Declare Function GetWindowLong Lib "user32" Alias "GetWindowLongA" (ByVal hwnd As Long, _
                                                                            ByVal nIndex As Long) As Long
 
Private Declare Function SetWindowLong Lib "user32" Alias "SetWindowLongA" (ByVal hwnd As Long, _
                                                                            ByVal nIndex As Long, _
                                                                            ByVal dwNewLong As Long) As Long
 
Private Const GWL_EXSTYLE      As Long = (-20)
Private Const WS_EX_LAYERED    As Long = &H80000
 
Private Declare Function SetLayeredWindowAttributes Lib "user32" (ByVal hwnd As Long, _
                                                                  ByVal crKey As Long, _
                                                                  ByVal bAlpha As Byte, _
                                                                  ByVal dwFlags As Long) As Long
 
Private Const LWA_ALPHA        As Long = &H2
Private lngForNum              As Long
Private lngStyle               As Long
Private bolActive              As Boolean
 
Private Sub Form_Activate()
    If Not bolActive Then
        bolActive = True
 
        For lngForNum = 10 To 255
            MakeWindowTransparent Me.hwnd, lngForNum
            DoEvents
        Next
    End If
End Sub
 
Private Sub Form_Load()
    MakeWindowTransparent Me.hwnd, 10
End Sub
 
Private Sub imgSplash_Click()
    IsLoggedIn = False
    frmLoginForm.Show
    tmrSplash.Enabled = False
    Unload Me
End Sub
 
Public Sub MakeWindowTransparent(ByVal lngHwnd As Long, _
                                 ByVal bytRate As Byte)
    
    lngStyle = GetWindowLong(lngHwnd, GWL_EXSTYLE)
    lngStyle = lngStyle Or WS_EX_LAYERED
    SetWindowLong lngHwnd, GWL_EXSTYLE, lngStyle
    SetLayeredWindowAttributes lngHwnd, 0, bytRate, LWA_ALPHA
End Sub
 
Private Sub tmrSplash_Timer()
    IsLoggedIn = False
    frmLoginForm.Show
    Unload Me
End Sub

Quote:

---

Originally Posted by Hack

And you have incorporate the boolean flag, especially in the .Show on these three forms, right?

If so, then somehow that boolean is getting reset to False when it hits one of them.

I'm almost afraid to ask this question because I just know you are going to say: No ....but I gotta ask anyway....is there any consistent pattern to when your login form shows up uninvited?

---

I am not sure if I have setup the boolean flag correctly or not. I havent worked with boolean until the other day so i am very new to it.

Do you reference the spalsh screen or any subs/controls etc anywhere else in your project?

Try these changes:

VB Code:

Private Sub tmrSplash_Timer()
    IsLoggedIn = False
    tmrSplash.Enabled = False
    frmLoginForm.Show
    Unload Me
End Sub
 
Private Sub Form_UnLoad()
    MakeWindowTransparent Me.hwnd, 10
    tmrSplash.Enabled = False
End Sub

Quote:

---

Originally Posted by zeusspider

Do you reference the spalsh screen or any subs/controls etc anywhere else in your project?

Try these changes:

VB Code:

Private Sub tmrSplash_Timer()
    IsLoggedIn = False
    tmrSplash.Enabled = False
    frmLoginForm.Show
    Unload Me
End Sub
 
Private Sub Form_UnLoad()
    MakeWindowTransparent Me.hwnd, 10
    tmrSplash.Enabled = False
End Sub

---

made the changes except for including MakeWindowTransparent Me.hwnd, 10
into the unload event because that part is what makes the form fade in and you cant fade in if the form is unloaded :)

declare then in a module and make them public

Quote:

---

Originally Posted by zeusspider

Do you reference the spalsh screen or any subs/controls etc anywhere else in your project?

---

Everything starts from Sub Main() and this is where the splash screen is started

Sub Main() looks like so:

VB Code:

Option Explicit
 
Public Sub Main()
    If App.PrevInstance Then
        Beep
        frmAppAlreadyRunning.Show
        IsLoggedIn = False
    Else
        If Not App.PrevInstance Then
            If LenB(Dir("license.lic")) Then
                frmSplash.Show
                IsLoggedIn = False
            ElseIf LenB(Dir("licence.lic")) = 0 Then
                frmRegister.Show
                IsLoggedIn = False
            Else
                End
            End If
        End If
    End If
End Sub

Quote:

---

Originally Posted by BrailleSchool

I am not sure if I have setup the boolean flag correctly or not. I havent worked with boolean until the other day so i am very new to it.

---

Show me an example of how you are using it.

man send all the project we already have this code

Quote:

---

Originally Posted by TheMinime

man send all the project we already have this code

---

if i sent the project then it would check for the .lic file based on your hard drive volumn number

:D I think I cant' comment the check code, it's not a big deal

Quote:

---

Originally Posted by TheMinime

man send all the project we already have this code

---

He is developing what he hopes to be a successful commerical application. He isn't going to do this.

BrailleSchool: Got that example I asked for?

Quote:

---

Originally Posted by Hack

Show me an example of how you are using it.

---

if you are not logged in, the boolean is False, if you are logged in then its set to true. this is what i have.

frmAccessDenied

VB Code:

Private Sub cmdAccessDeniedOK_Click()
    With frmLoginForm
        IsLoggedIn = False
        .Show
        .txtUsername.Text = vbNullString
        .txtPassword.Text = vbNullString
        .txtUsername.SetFocus
    End With
    
    Unload Me
End Sub
 
Private Sub Form_Unload(Cancel As Integer)
    IsLoggedIn = False
            
    With frmLoginForm
        .Show
        .txtUsername.Text = vbNullString
        .txtPassword.Text = vbNullString
        .txtUsername.SetFocus
    End With
    
    Unload Me
End Sub

modPublicVariables

VB Code:

Option Explicit
 
Public IsLoggedIn As Boolean

frmAccountDisabled

VB Code:

Private Sub cmdAccountDisabledOK_Click()
    With frmLoginForm
        IsLoggedIn = False
        .Show
        .txtUsername.Text = vbNullString
        .txtPassword.Text = vbNullString
        .txtUsername.SetFocus
    End With
End Sub
 
Private Sub Form_Unload(Cancel As Integer)
    With frmLoginForm
        IsLoggedIn = False
        .Show
        .txtUsername.Text = vbNullString
        .txtPassword.Text = vbNullString
        .txtUsername.SetFocus
        IsLoggedIn = False
    End With
End Sub

frmSplash

VB Code:

Private Sub Form_Unload(Cancel As Integer)
    tmrSplash.Enabled = False
    IsLoggedIn = False
End Sub
 
Private Sub imgSplash_Click()
    IsLoggedIn = False
    frmLoginForm.Show
    tmrSplash.Enabled = False
    Unload Me
End Sub
 
Private Sub tmrSplash_Timer()
    IsLoggedIn = False
    frmLoginForm.Show
    Unload Me
End Sub

Sub Main as above

frmMain

VB Code:

Private Sub MDIForm_Unload(Cancel As Integer)
 
    If gbSubClassMenu Then
        '/ prevent error if the menu is not subclassed
        On Error Resume Next
        '/ release object
        Call objMenuEx.Uninstall(Me.hwnd, ImageList, MenuEvents)
        Set MenuEvents = Nothing
        Set objMenuEx = Nothing
    End If
 
    With Me
        If .WindowState <> vbMinimized Then
            SaveSetting "Operations Manager Pro", "Settings", "MDI.L", .Left
            SaveSetting "Operations Manager Pro", "Settings", "MDI.T", .Top
            SaveSetting "Operations Manager Pro", "Settings", "MDI.W", .Width
            SaveSetting "Operations Manager Pro", "Settings", "MDI.H", .Height
        End If
    End With
 
    Unload frmMain
    
    If IsLoggedIn = True Then
            IsLoggedIn = False
        
        With frmLoginForm
            .Show
            .txtUsername.Text = vbNullString
            .txtPassword.Text = vbNullString
            .txtUsername.SetFocus
        End With
    End If
End Sub
 
Private Sub mnuLogout_Click()
    If IsLoggedIn = True Then
        IsLoggedIn = False
        frmLoginForm.Show
        Unload frmMain
    End If
End Sub

frmLoginForm

VB Code:

Option Explicit
 
Private intLoginAttempts    As Long
 
Private Sub cmdClose_Click()
    Unload Me
    End
End Sub
 
Private Sub cmdLogin_Click()
Dim strSQL          As String
Dim strUName        As String
Dim strPwd          As String
Dim strOperatorName As String
Dim conn            As ADODB.Connection
Dim rs              As ADODB.Recordset
 
    Set conn = New ADODB.Connection
    Set rs = New ADODB.Recordset
 
    conn.CursorLocation = adUseClient
    conn.Open "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=Database.mdb;Persist Security Info=false"
    
    strSQL = "SELECT * "
    strSQL = strSQL & "FROM Users "
    strSQL = strSQL & "WHERE Username = '" & txtUsername.Text & "' "
    strSQL = strSQL & "AND Password = '" & txtPassword.Text & "' "
    strSQL = strSQL & "AND Disabled = 'No'"
 
    'UNCOMMENT NEXT LINE TO DEBUG SQL STATEMENT
    'Debug.Print strSQL
 
    rs.Open strSQL, conn, adOpenKeyset, adLockOptimistic
 
    If Not (rs.EOF) Then
        strUName = rs.Fields("Username").Value
        strPwd = rs.Fields("Password").Value
        strOperatorName = rs.Fields("Operator").Value
    End If
 
    intLoginAttempts = intLoginAttempts + 1
 
    If txtUsername.Text = strUName And txtPassword.Text = strPwd Then
        If IsLoggedIn = False Then
            IsLoggedIn = True
            frmMain.Show
            Unload frmLoginForm
        End If
    ElseIf intLoginAttempts = 1 Then
        IsLoggedIn = False
        frmAccessDenied.Show
        frmAccessDenied.lblAccessDeniedCaption.Caption = "Login Credentials Mismatch." & vbNewLine & _
                                                         "Access Denied" & vbNewLine & _
                                                         "Attempt 1 of 4."
        Exit Sub
    ElseIf intLoginAttempts = 2 Then
        IsLoggedIn = False
        frmAccessDenied.Show
        frmAccessDenied.lblAccessDeniedCaption.Caption = "Login Credentials Mismatch." & vbNewLine & _
                                                         "Access Denied" & vbNewLine & _
                                                         "Attempt 2 of 4."
        Exit Sub
    ElseIf intLoginAttempts = 3 Then
        IsLoggedIn = False
        frmAccessDenied.Show
        frmAccessDenied.lblAccessDeniedCaption.Caption = "Login Credentials Mismatch." & vbNewLine & _
                                                         "Access Denied" & vbNewLine & _
                                                         "Attempt 3 of 4."
        Exit Sub
    ElseIf intLoginAttempts = 4 Then
        With frmAccessDenied
            IsLoggedIn = False
            .Show
            .lblAccessDeniedCaption.Top = 40
            .lblAccessDeniedCaption.Caption = "Login Credentials Mismatch." & vbNewLine & _
                                              "Access Denied" & vbNewLine & _
                                              "Attempt 4 of 4." & vbNewLine & _
                                              "Accound Disabled.  Contact Support."
        End With
        
        strSQL = "UPDATE Users "
        strSQL = strSQL & "SET Disabled = 'Yes' "
        strSQL = strSQL & "WHERE Username = '" & txtUsername.Text & "'"
        conn.Execute strSQL
 
        Exit Sub
    ElseIf txtUsername.Text = strUName And txtPassword.Text = strPwd And rs.Fields("Disabled").Value = "Yes" Then
        IsLoggedIn = False
        frmAccountDisabled.Show
        Exit Sub
    ElseIf Not rs.EOF And rs.Fields("FullAccess").Value = "Yes" Then
        'do nothing
    Else
        With frmInternalSplash
            'INVENTORY MANAGER
            .Frame(0).Height = "1455"
            .Frame(0).Width = "1695"
            .Frame(0).Top = "480"
            .Frame(0).Left = "120"
            .cmdAddProduct.Visible = False
            .cmdDeleteProduct.Visible = False
            .cmdEditProduct.Visible = False
            .cmdSearchProduct.Top = "240"
            .cmdSearchProduct.Left = "120"
            .cmdStockControl.Top = "840"
            .cmdStockControl.Left = "120"
 
            'CLIENT MANAGER
            .Frame(1).Height = "2055"
            .Frame(1).Width = "1695"
            .Frame(1).Top = "2040"
            .Frame(1).Left = "120"
            .cmdDeleteClient.Visible = False
            .cmdEditClient.Top = "840"
            .cmdEditClient.Left = "120"
            .cmdSearchClient.Top = "1440"
            .cmdSearchClient.Left = "120"
 
            'INVOICE MANAGER
            .Frame(2).Height = "1455"
            .Frame(2).Width = "1695"
            .Frame(2).Top = "4200"
            .Frame(2).Left = "120"
 
            'LOGOUT
            .Frame(3).Height = "855"
            .Frame(3).Width = "1695"
            .Frame(3).Top = "2160"
            .Frame(3).Left = "1920"
 
            'NAVIGATION HINT
            .Frame(4).Height = "975"
            .Frame(4).Width = "1695"
            .Frame(4).Top = "3120"
            .Frame(4).Left = "1920"
 
            'HIDE THE ADD/EDIT/DELETE OPERATOR OPTIONS IF YOU DONT HAVE FULL ACCESS
            .Frame(5).Visible = False
        End With
 
        With frmMain
            .mnuAddProduct.Visible = False
            .mnuAddOperator.Visible = False
            .mnuEditProduct.Visible = False
            .mnuEditOperator.Visible = False
            .mnuDelete.Visible = False
            .mnuDeleteOperator.Visible = False
            .mnuSettings.Visible = False
        End With
    End If
 
    frmMain.sbStatusBar.Panels(7).Text = "Welcome to Operations Manager Pro " & strOperatorName & ", you are logged in as " & strUName & "."
 
    rs.Close
    Set rs = Nothing
 
    conn.Close
    Set conn = Nothing
End Sub
 
Private Sub Form_Load()
    cmdLogin.Enabled = False
End Sub
 
Private Sub txtPassword_Change()
    If LenB(txtPassword.Text) = 0 Or LenB(txtUsername.Text) = 0 Then
        cmdLogin.Enabled = False
    End If
 
    If LenB(txtPassword.Text) = 0 Then
        If LenB(txtUsername.Text) = 0 Then
            cmdLogin.Enabled = False
        End If
    End If
 
    If LenB(txtPassword.Text) > 0 And LenB(txtUsername.Text) Then
        cmdLogin.Enabled = True
    End If
End Sub
 
Private Sub txtPassword_GotFocus()
    SelectWholeTextBox txtPassword
End Sub
 
Private Sub txtUsername_Change()
    If LenB(txtPassword.Text) = 0 Or LenB(txtUsername.Text) = 0 Then
        cmdLogin.Enabled = False
    End If
 
    If LenB(txtPassword.Text) = 0 Then
        If LenB(txtUsername.Text) = 0 Then
            cmdLogin.Enabled = False
        End If
    End If
 
    If LenB(txtPassword.Text) > 0 And LenB(txtUsername.Text) Then
        cmdLogin.Enabled = True
    End If
End Sub
 
Private Sub txtUsername_GotFocus()
    SelectWholeTextBox txtUsername
End Sub

frmInternalSplash

VB Code:

Private Sub cmdLogout_Click()
    If IsLoggedIn = True Then
        IsLoggedIn = False
    
        Unload frmMain
    
        With frmLoginForm
                .Show
                .txtUsername.Text = vbNullString
                .txtPassword.Text = vbNullString
                .txtUsername.SetFocus
        End With
    End If
End Sub

this post and the above is everwhere frmLoginForm is called from.

First, by default, a boolean is False. You do not need to expressly set it to False unless it has been previously set to True, and you need to reset it.

The first suggestion I have is remove all of those lines of code that set it to False at startup. They are unnecessary and confusing.

The second suggestion is this change: Under this line in cmdLogin_Click()

Code:

---

frmMain.sbStatusBar.Panels(7).Text blah blah

---

set the boolean to True.

Also, you do not need to test for the condition of IsLoggedIn. If you set it to False and it is already False, then nothing is going to have. Your If statements on this boolean are unnecessary.

I would encaspulate each With/End With that deals with frmLogin thusly:

VB Code:

If IsLoggedIn = False Then
     With frmLoginForm
                .Show
                .txtUsername.Text = vbNullString
                .txtPassword.Text = vbNullString
                .txtUsername.SetFocus
        End With

When you set IsLoggedIn to True in the beginning, these with statements will never execute. In cmdLogout_Click, set it to False.

If you encapsulate all of the .Show statements in an If IsLoggedIn = False and set IsLoggedIn equal to True in the correct portion of cmdLogin and never set it to False except in cmdLogout, you shouldn't continue to be haunted by frmLogin.

Quote:

---

Originally Posted by Hack

First, by default, a boolean is False. You do not need to expressly set it to False unless it has been previously set to True, and you need to reset it.

The first suggestion I have is remove all of those lines of code that set it to False at startup. They are unnecessary and confusing.

---

ok. i have removed it from Sub Main()

Quote:

---

Originally Posted by Hack

The second suggestion is this change: Under this line in cmdLogin_Click()

Code:

---

frmMain.sbStatusBar.Panels(7).Text blah blah

---

set the boolean to True.

---

VB Code:

frmMain.sbStatusBar.Panels(7).Text = "Welcome to Operations Manager Pro " & strOperatorName & ", you are logged in as " & strUName & "."
    
    If IsLoggedIn = False Then
        IsLoggedIn = True
    End If

Does it work?