Whats in the Hand?

Im writing a program that deals with poker, the person has 10 combo boxes and tells me the value and suit of their cards, then I want to say if they have a royal flush, straight flush, four of a kind, etc. The problem is I can't compare an Ace to a 7 to test which is bigger. Whats my best option here?

Ace is only the lowest when it is used in a straight A2345. What difficulties are you having?

If Card1=Ace and Not A Straight with A2345, then Ace is big.

I have 5 combo boxes named cmbC1 cmbC2 cmbC3 all the way to 5. I want to compare each card and see which is the highest.

Nvrmind I got it :D

Here's the code I wrote to check the high card, its not working and its very tedious can anyone help?

VB Code:

Private Sub checkHighCard()
Dim highcard As String
Dim cardone As String
Dim cardtwo As String
Dim carthree As String
Dim cardfour As String
Dim cardfive As String
cardone = cmbC1.Text
cardtwo = cmbC2.Text
cardthree = cmbC3.Text
cardfour = cmbC4.Text
cardfive = cmbC5.Text
 
If cardone = "A" Then
cardone = 14
End If
If cardtwo = "A" Then
cardtwo = 14
End If
If cardthree = "A" Then
cardthree = 14
End If
If cardfour = "A" Then
cardfour = 14
End If
If cardfive = "A" Then
cardfive = 14
End If
 
If cardone = "K" Then
cardone = 13
End If
If cardtwo = "K" Then
cardtwo = 13
End If
If cardthree = "K" Then
cardthree = 13
End If
If cardfour = "K" Then
cardfour = 13
End If
If cardfive = "K" Then
cardfive = 13
End If
 
If cardone = "Q" Then
cardone = 12
End If
If cardtwo = "Q" Then
cardtwo = 12
End If
If cardthree = "Q" Then
cardthree = 12
End If
If cardfour = "Q" Then
cardfour = 12
End If
If cardfive = "Q" Then
cardfive = 12
End If
 
If cardone = "J" Then
cardone = 11
End If
If cardtwo = "J" Then
cardtwo = 11
End If
If cardthree = "J" Then
cardthree = 11
End If
If cardfour = "J" Then
cardfour = 11
End If
If cardfive = "J" Then
cardfive = 11
End If
 
'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 
highcard = cardone
If cardtwo > highcard Then
highcard = cardtwo
End If
If cardthree > highcard Then
highcard = cardtwo
End If
If cardfour > highcard Then
highcard = cardtwo
End If
If cardfive > highcard Then
highcard = cardtwo
End If
 
If highcard = 14 Then
highcard = "A"
End If
If highcard = 13 Then
highcard = "K"
End If
If highcard = 12 Then
highcard = "Q"
End If
If highcard = 11 Then
highcard = "J"
End If
MsgBox highcard
End Sub

You need a CONTROL ARRAY of COMBO BOXES.

That way you can loop through the COMBO BOXES.

That will make your life much easier.

How do I do that?

Also, by adding items to comboboxes in this way:

VB Code:

'to all five comboboxes
    For I = 0 To 4
        MyCombo(I).AddItem "A"
        MyCombo(I).ItemData(MyCombo(I).NewIndex) = 14
        MyCombo(I).AddItem "K"
        MyCombo(I).ItemData(MyCombo(I).NewIndex) = 13
        MyCombo(I).AddItem "Q"
        MyCombo(I).ItemData(MyCombo(I).NewIndex) = 12
        'etc...
    Next I

And by using With, you save some coding...

VB Code:

'to all five comboboxes
    For I = 0 To 4
        With MyCombo(I)
            .AddItem "A"
            .ItemData(.NewIndex) = 14
            .AddItem "K"
            .ItemData(.NewIndex) = 13
            .AddItem "Q"
            .ItemData(.NewIndex) = 12
            'etc...
        End With
    Next I

Hope this helps :)


Edit Oh yeah, then the usage afterwards:

VB Code:

ValueOfTheCard = MyCombo(0).ItemData(MyCombo(0).ListIndex)
    'will return 2, 3, 4... 13, 14

Remove all but the first combo box.

Go into the properties of that combo box and set the index to "0" (it will be blank).

It is now a control array. Copy/Paste it 4 times onto the FORM.

Notice the index of each of these four combo box controls - they are 1, 2, 3 and 4.

The events you have for the COMBO BOX are no good anymore - if you comment out the event and put it in again you get "(INDEX)" appended to the event function name.

So instead of events for 5 combo boxes, you have just a single event for a box - with an INDEX parameter that will be equal to 0, 1, 2, 3, 4 or 5 when the event fires (such as CMBBOX_CLICK(INDEX))

So I should start over? lol

Well, it probably eases your coding more than continuing with your current style. So yeah, make a backup of your current project and edit it to our suggestions. You can then always go back to what you had if you want to :)

Ok Here's how it looks. Im not sure how to use it though, could I have some explanation of how to get the value of it and show the A as 14 etc.?

Merri already showed you how to use the .ITEMDATA property to store a number associated with the "text" displayed (and selected) in the box.

That makes the numeric association much easier.

Ok it's getting better. I'm now getting an error on this code :

VB Code:

Private Sub checkHighCard()
Dim cardone As String
Dim cardtwo As String
Dim cardthree As String
Dim cardfour As String
Dim cardfive As String
 
cardone = MyCombo(0).ItemData(MyCombo(0).ListIndex)
cardtwo = MyCombo(1).ItemData(MyCombo(1).ListIndex)
cardthree = MyCombo(2).ItemData(MyCombo(2).ListIndex)
cardfour = MyCombo(3).ItemData(MyCombo(3).ListIndex)
cardfive = MyCombo(4).ItemData(MyCombo(4).ListIndex)
 
MsgBox cardone
MsgBox cardtwo
MsgBox cardthree
MsgBox cardfour
MsgBox cardfive
End Sub

ListIndex might be -1 when no item is selected, I guess this might be causing your error (as you are pointing to non-existant item). You can avoid it by having a code like this when you have added items to your combos:

VB Code:

Private Sub Form_Load()
    Dim I As Long
 
    'add items to combobox here
 
    'set first items selected
    For I = 0 To 4
        MyCombo1.ListIndex = 0
    Next I
End Sub

Here's the new code, it's not working properly when I put one of the cards as a number. I put in K 4 10 10 J and it said 4 is the high card.

VB Code:

Private Sub checkHighCard()
Dim highcard As String
Dim cardone As String
Dim cardtwo As String
Dim cardthree As String
Dim cardfour As String
Dim cardfive As String
 
cardone = MyCombo(0).ItemData(MyCombo(0).ListIndex)
cardtwo = MyCombo(1).ItemData(MyCombo(1).ListIndex)
cardthree = MyCombo(2).ItemData(MyCombo(2).ListIndex)
cardfour = MyCombo(3).ItemData(MyCombo(3).ListIndex)
cardfive = MyCombo(4).ItemData(MyCombo(4).ListIndex)
 
highcard = cardone
If cardtwo > highcard Then
highcard = cardtwo
End If
If cardthree > highcard Then
highcard = cardthree
End If
If cardfour > highcard Then
highcard = cardfour
End If
If cardfive > highcard Then
highcard = cardfive
End If
 
If highcard = 14 Then
highcard = "Ace"
End If
If highcard = 13 Then
highcard = "King"
End If
If highcard = 12 Then
highcard = "Queen"
End If
If highcard = 11 Then
highcard = "Jack"
End If
MsgBox highcard
End Sub

VB Code:

Private Sub checkHighCard()
    'I changed these to Long datatype
    'then there will be no data type conversions and code is less likely to have errors
    Dim highcard As Long, compareto As Long, I As Long
 
    highcard = MyCombo(0).ItemData(MyCombo(0).ListIndex)
    For I = 1 To 4
        compareto = MyCombo(I).ItemData(MyCombo(I).ListIndex)
        If highcard < compareto Then highcard = compareto
    Next I
 
    Select Case highcard
        Case 14
            MsgBox "Ace"
        Case 13
            MsgBox "King"
        Case 12
            MsgBox "Queen"
        Case 11
            MsgBox "Jack"
        Case Else
            MsgBox highcard
    End Select
End Sub

These were all your ideas, I just used some more compact techniques to attain the same effect :)

You should use an array for dim card(51) and dim suit(51) and another array dim deck(51). That way, deck(0) would be the first card.

Hand should be another array dim Hand(4) that points to a deck value, which is a card.

then, Hand(0) would be the value for the first card (1), Hand(1) (if it had been discarded) may be deck(6)

sorry I wasn't here earlier to advise you. I used textboxes, and the chr() for spade, heart, diamond, and club when I wrote a draw poker game.

You have to use 1 for ACE, and if you have a straight, allow ACE to also be a high card (13).

I don't think combo boxes are your best choice for cards.

Nice to jump in, but if you look, this person is having a hard time with the concept of looping. Multi-dimensional arrays and "best-practice" concepts for card games are great - but we are talking some pretty elementary stuff here...

That hurts :'(

i simplified it just now. i think it will be very hard to set things up if arrays aren't used. better to use good design, even if it means starting again.

I simply compared your code after the suggestion to use CONTROL ARRAY with what MERRI wrote for you - the whole point of the CONTROL ARRAY was to allow for that simple loop that MERRI wrote.

I meant no offense - sorry.

None taken. I'll work on the program and get back to you guys tomorrow. Thanks for the help so far though.

it is very logical if you set it up correctly.
if suit(4)=suit(5) then possible straight
if card(4)=card(5) then pair

To dglienna: Offtopic is offtopic, but all in all, we are here to help people. I myself and szlamany are trying to teach some basic concepts which are more valuable to learn right now and still useable in the already done code (to lessen the amount of work to be thrown off), compared to what you are asking for an entirely new project. The way you want to help now would be fine for someone who already knew what we are trying to teach. As szlamany said, no offence meant with all this text either, just trying to clarify this situatation as I (and maybe szlamany) see it.


Anyways, I hope we can go on with this, one thing at a time :)

well, I don't see how a control array of combo boxes help much either, as combo boxes are a bad idea for cards. you kind of skipped that he had 10 combo's on his form to begin with.

Interesting thing to start arguing about :)

The first code posted (not the zip) had an obvious need for CONTROL ARRAY. That is without a doubt the case. It allowed for the simple and elegant loop that MERRI wrote to find a high card.

After that came a zip with a form and no code - I didn't even really look at it much, as it had no code.

I can see this person is experimenting with both the UI and the code.

Of course, we're doing suggestions to help him and it is up to him to see if the changes fit what he has. He didn't describe them much in detail, so I'm concentrating to the problem he currently has. If he notices he needs more changes, he can ask for more help or try doing the required additional changes all by himself. Either way, he should learn much more effectively than if we directly told what he should or must do.

Human learns best of his errors.


I actually never downloaded the zip file, as I then didn't see a need to download it.


Edit I actually started a new topic at Chit Chat, partly having something to do with this talk: http://www.vbforums.com/showthread.php?t=317702

Hey guys i've run into my next problem. How do I go about doing a return variable for a function? I was thinking of doing something similar to checking for a flush, then for a straight to check for full house. So I want to be able to do something like this :

VB Code:

straight = funcTestStraight
If straight = true then
   flush = funcTestFlush
   If flush = true then

etc. etc. It wont look exactly like that its just to help clarify.

Here's a simple illustration of building/using a function:

Code:

---

Private Sub Command1_Click()
        'This is a simple illustration of returning values from a function.
        'Lets say you wanted a function to return the sum of 5 numbers.
        'Lets say you had those 5 numbers in an array:
        Dim AN_ARRAY(4) As Long
        'And lets say you wanted the sum placed in the following variable:
        Dim THE_SUM As Long
        'lets say that array had the values 1,2,3,4,9"
        AN_ARRAY(0) = 1
        AN_ARRAY(1) = 2
        AN_ARRAY(2) = 3
        AN_ARRAY(3) = 4
        AN_ARRAY(4) = 9
        'so, this will now access the function:
       
        THE_SUM = MY_FUNCTION(AN_ARRAY)
        MsgBox THE_SUM
End Sub
Private Function MY_FUNCTION(ByRef inArr() As Long) As Long
        'This function will return a 1 dimensional value
        'representing the sum of all the numbers in inArr()
        Dim MyI As Long
        MY_FUNCTION = 0
        For MyI = 0 To UBound(inArr)
                MY_FUNCTION = MY_FUNCTION + inArr(MyI)
        Next MyI
End Function

---

:wave:
hmmm, seems vbcode tags still aren't functioning???

Use the enter key? lol

I wrote this code to check for a flush :

VB Code:

Private Sub checkFlush(ByVal exists As Boolean)
exists = False
If MyCombos(0).Text = MyCombos(1).Text Then
    If MyCombos(1).Text = MyCombos(2).Text Then
        If MyCombos(2).Text = MyCombos(3).Text Then
            If MyCombos(3).Text = MyCombos(4).Text Then
                If MyCombos(4).Text = MyCombos(5).Text Then
                    exists = True
                End If
            End If
        End If
    End If
End If
End Sub

But when i'm not exactly sure how to call it properly. When I try it gives me errors. I tried :

VB Code:

varFlush = checkFlush(varFlush2)

But it doesnt work. Also if there is a more efficient way to do this that would help because eventually id like to make it do 200,000 or so trys in a short period of time.

So, If a flush is when all the cards are the same color, and the color is whats selected in your MyCombos(n), then your code could be changed to the following:

Code:

---

Private Sub Command2_Click()
        MsgBox checkFlush
End Sub
 
Private Function checkFlush() As Boolean
Dim MyI As Long
checkFlush = True
For MyI = 1 To 5
        checkFlush = checkFlush And (MyCombos(MyI).Text = MyCombos(MyI - 1).Text)
Next MyI
End Function

---

BTW, Your hand seems to be 6 cards?
:wave:

Now, if you were insisting on using a sub instead of a function, then
you should change:

Private Sub checkFlush(ByVal exists As Boolean)

to:

Private Sub checkFlush(ByRef exists As Boolean)

because ByRef directs the value back to your input variable, instead of
becoming a new, inaccesable variable.

And you'd use it like:

Dim varFlush as Boolean
Call checkFlush(varFlush)
Msgbox varFlush

Thanks notLKH. I can now check for the high card with a sub and check for a flush with a function. Do you think it would be simplest and most efficient to find straight, pair, two pair, and three of a kind if i added each of the values (possibly being 1-14) to a listbox then sorted it and checked for duplicates etc.?

I would venture to guess that you could loop through the cards just one time - with multiple IF statements in the loop - to check for each type of condition.

Basically add on the the logic that notLKH gave you - keeping in mind that there is a hierarchy to what you find.

I would suggest you sort the cards from low to high order before looping through them - it will make some of the checking even more intuitive.

This is my sub to check for a pair, I set up a test and it should message box how many 3's I have but it doesn't :

VB Code:

Private Sub checkOnePair()
Dim myArray(13) As String
Dim tempVar As String
 
For Z = 0 To 13
    myArray(Z) = 0
Next Z
 
For x = 0 To 4
    For y = 0 To 13
        If MyCombo(x).Text = y Then
            tempVar = myArray(y)
            tempVar = tempVar + 1
            myArray(y) = tempVar
        End If
    Next y
Next x
MsgBox myArray(2)
End Sub

As I pointed out before:

VB Code:

Dim myArray(13) As String
Dim tempVar As String

This here is your problem. You should use another data type. What is happening here:

VB Code:

myArray(0) = myArray(0) + 1
'= "1"
myArray(0) = myArray(0) + 1
'= "11"
myArray(0) = myArray(0) + 1
'= "111"
'and so on

A proper datatype would be Byte, Integer or Long. Byte is enough for you, as it never gets over 255. So:

VB Code:

Dim myArray(13) As Byte
Dim tempVar As Byte

And after that this works the way you mean:

VB Code:

myArray(0) = myArray(0) + 1
'= 1
myArray(0) = myArray(0) + 1
'= 2
myArray(0) = myArray(0) + 1
'= 3
'and so on

How would I change it to show which is a pair?

Replace your MsgBox line with this:

VB Code:

For y = 0 To 13
        If myArray(y) = 2 Then MsgBox "Pairs! " & y
    Next y

It then tells if there are any pairs at all.

This doesn'd do anything :

VB Code:

Private Sub checkOnePair()
Dim myArray(13) As Byte
Dim tempVar As Byte
 
For Z = 0 To 13
    myArray(Z) = 0
Next Z
 
For x = 0 To 4
    For y = 0 To 13
        If MyCombo(x).Text = y Then
            tempVar = myArray(y)
            tempVar = tempVar + 1
            myArray(y) = tempVar
        End If
    Next y
Next x
 
For y = 0 To 13
    If myArray(y) = 2 Then MsgBox "Pair of " & y & "s."
Next y
End Sub

Ah, noticed this:

VB Code:

If MyCombo(x).Text = y Then

Did you add the items having the ItemData added as well? If you did, you can then do:

VB Code:

If MyCombo.ItemData(MyCombo(x).ListIndex) = y Then

:)

I get an error on that line :S

Steve_F,

Now would be a really good time for you to learn the importance of stepping through code one line at a time, hovering over a variable and seeing it's value and using the immediate window.

Do you typically code using these techniques?

nope. teach me? :D

Right click on code window - TOGGLE - BREAK ON ALL ERRORS.

Next, set a break point at a code line above where you are curious about functionality.

Use F8 to step from line to line - one line at a time.

Hover over a variable - you will see it's value.

Always RUN WITH FULL COMPILE.

That's what we live by in our shop.

Not fully vetting your code before adding more code is a house-of-cards (no pun intended)...

It's now working right, do you know whats wrong?

Quote:

---

Originally Posted by Merri

Ah, noticed this:

VB Code:

If MyCombo(x).Text = y Then

Did you add the items having the ItemData added as well? If you did, you can then do:

VB Code:

If MyCombo.ItemData(MyCombo(x).ListIndex) = y Then

:)

---

Merri, you dropped an index!

VB Code:

If MyCombo[b](x)[/b].ItemData(MyCombo(x).ListIndex) = y Then

That might be what was giving the error
:wave:

The new sub now looks like this :

VB Code:

Private Sub checkOnePair()
Dim myArray(13) As Byte
Dim tempVar As Byte
 
For Z = 0 To 13
    myArray(Z) = 0
Next Z
 
For x = 0 To 4
    For y = 0 To 13
        If MyCombo(x).Text = y Then
            tempVar = myArray(y)
            tempVar = tempVar + 1
            myArray(y) = tempVar
        End If
    Next y
Next x
 
For y = 0 To 13
    If MyCombo(x).ItemData(MyCombo(x).ListIndex) = y Then
        MsgBox "Pair of " & y & "s."
    End If
Next y
End Sub

And it isnt working, im looping with y not x :s

Simplified and commented. Actually, now that I think about it, it could really help you to comment your code, because it forces you to think what your code does.

VB Code:

Private Sub checkOnePair()
    'I used 2 to 14, as these are the cards you can have in the combobox...
    Dim myArray(2 To 14) As Byte
    'by default, all values are 0, no need to reset
 
    'loop through all comboboxes
    For x = 0 To 4
        'check the card selected in the combobox
        y = MyCombo(x).ItemData(MyCombo(x).ListIndex)
        'increase the amount
        myArray(y) = myArray(y) + 1
    Next x
 
    'loop through all cards
    For y = 2 To 14
        'look for a pair
        If myArray(y) = 2 Then
            'display a message we have a pair
            MsgBox "Pair of " & y & "s."
        End If
    Next y
End Sub

:)

I get an error here :

VB Code:

myArray(y) = myArray(y) + 1

Saying "Subscript out of range." Should I change myArray's type to an integer?

I changed the code a bit just a moment ago. See if it works now.

Yeah it work's except when I get Aces it says I have a pair of 14's.

Easily fixed: Select Case

VB Code:

'loop through all cards
    For y = 2 To 14
        'look for a pair
        If myArray(y) = 2 Then
            'display a message we have a pair
            Select Case y
                Case 14
                    MsgBox "Pair of Aces."
                Case 13
                    MsgBox "Pair of Kingss."
                Case 12
                    MsgBox "Pair of Queens."
                Case 11
                    MsgBox "Pair of Jacks."
                Case Else
                    MsgBox "Pair of " & y & "s."
            End Select
        End If
    Next y

Though, if you ever change the sub so that it'll work indirectly and well enough for a real game, that is what you're going to change.

Also, you could make more functionality in the sub: you can actually check for triples as well and so on. You can check for anything actually :)

This is the status so far :

VB Code:

'checkRoyalFlush
'checkStraightFlush ***Can use when straight is done***
'checkFourKind ***Done***
'checkFullHouse
'checkFlush ***Done***
'checkStraight
'checkThreeKind ***Done***
'checkTwoPair
'checkOnePair ***Done***
'checkHighCard ***Done***

Im gonna work on the ones that arent done yet. Eventually I would like to have a section where they can test the probability of one pocket hand beating another (Texas Hold Em). The program will randomly do the 5 community cards and make the best 5 card hand, then tell which one is better, and this will happen about 200,000 and see the percent of times each hand wins. Am I getting way out of my league with this?