I need help looping through an array. [SOLVED]

Take a look at this function.

VB Code:

Private Function ColorServerMessageLines()
    Dim strArray As String
    strArray = Split(rtbServerMessages.Text, vbNewLine)
    For i = 0 To strArray - 1
        If Left$(strArray(i), 6) = "SYSTEM" Then
            rtbServerMessages.SelStart = 0
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkGreen
        ElseIf Left$(strArray(i), 5) = "ERROR" Then
            rtbServerMessages.SelStart = 0
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkRed
        End If
    Next i
End Function

What this code is *supposed to* do is split the contents of my textbox into an array, using the newline character as a delimiter. It should then loop through each of the resulting elements, searching for a specific string at the beginning, and coloring the different lines accordingly. However, when I run the code, I get this error.

Expected: Array

Shouldn't the Split function have already made it an array? What corrections do I need to make to get this to work right?

try this

VB Code:

For i = 0 To UBound(strArray)

casey.

What line gives the error? vBasicgirl is right about her comment, but I think you will also have to declare strArray as:

Dim strArray() as string

The variable strArray is highlighted.

Come to think of it, she may have already solved the problem, unless the error runs a bit deeper than I think. I'll try that now.

Well, I got rid of the error by combining your ideas. Only one problem though.

Nothing happens.

Also, when I go to view the contents of the array, I get a Type Mismatch.

Suggests that the size of the array is 0. You might confirm that Ubound strArray is something other than 0.

your code is messed, thats for sure

im workin on it...

Nevermind, stupid mistake on my part.

Had no newline characters, so it had nothing to delimit.

Still doesn't serve my purpose though. My purpose is to have each line color-coded according to the type of information it carries. Apparently, the rtbServerMessages.SelLength = Len(strArray(i)) is messing me up, I have to find another way, perhaps color everything up to the newline character.

How/when do you add the info in the RTB?

Some info is simply entered on Form Load. Other info is transferred from the client end.

Server and Client are built into a single app, you just need to run two instances of the same app, one acting as client, the other acting as server.

I made a couple of changes

VB Code:

Private Function ColorServerMessageLines()
    Dim strArray[color="#FF0080"]()[/color] As String
    strArray = Split(rtbServerMessages.Text, vbNewLine)
    For i = 0 To [color="#FF0080"]UBound[/color](strArray) - 1
        If Left$(strArray(i), 6) = "SYSTEM" Then
            rtbServerMessages.SelStart = 0
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkGreen
        ElseIf Left$(strArray(i), 5) = "ERROR" Then
            rtbServerMessages.SelStart = 0
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkRed
        End If
    Next i
End Function

Ok, this gets weirder and weirder. This will work the way I want it.

VB Code:

Private Function ColorServerMessageLines()
    Dim strArray() As String
    strArray = Split(rtbServerMessages.Text, vbNewLine)
    For i = 0 To UBound(strArray) - 1
        If Left$(strArray(i), 6) = "SYSTEM" Then
            rtbServerMessages.SelStart = 1
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkGreen
        ElseIf Left$(strArray(i), 5) = "ERROR" Then
            rtbServerMessages.SelStart = 0
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkRed
        Else
            Exit Function
        End If
    Next i
End Function

However, this will not:

VB Code:

Private Function ColorServerMessageLines()
    Dim strArray() As String
    strArray = Split(rtbServerMessages.Text, vbNewLine)
    For i = 0 To UBound(strArray) - 1
        If Left$(strArray(i), 6) = "SYSTEM" Then
            rtbServerMessages.SelStart = 0
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkGreen
        ElseIf Left$(strArray(i), 5) = "ERROR" Then
            rtbServerMessages.SelStart = 0
            rtbServerMessages.SelLength = Len(strArray(i))
            rtbServerMessages.SelColor = vbDarkRed
        Else
            Exit Function
        End If
    Next i
End Function

The difference is the beginning letter of the first line. The top code sample will not color it.

Your second example won't even compile because of setting SelStart to 0! You need to change your IDE settings.

Eh? What do you mean?

BTW: The top example works for the first two lines, then stops working.

Sorry, brain fart. I assumed that SelStart = 0 would be invalid. Since however a value of 0 indicates that you want to start with the 1st character it seems that that explains the problem in that Selstart = 1 would start with the second character.

Can you attach a file that contains the data or post what it looks like?

Here you go. The first and third lines are colored correctly, but the second line should be black.

I believe this is what's tripping me up.

VB Code:

rtbServerMessages.SelStart = 0
    rtbServerMessages.SelLength = Len(strArray(i))
    rtbServerMessages.SelColor = vbDarkGreen

Try putting

VB Code:

rtbServerMessages.SelColor = vbBlack

as the 1st line in the loop.

Nope, the green is somehow taking precedence still.

OK a few problems. The loop should definately be For i = 0 To UBound(strArray) and not -1. Sorry I didn't catch that before. Second, I don't have your actual data but splitting using vbNewLine may be wrong. It might be vbCrLf. Put a breakpoint on the If Left$(strArray(i), 6) = "SYSTEM" Then line and see what is in strArray(1). At this point I'm guessing that it contains all the text and not just the first line. Finally, where do vbDarkRed and vbDarkGreen come from? They're not recognized by my VB.

Oh, and do you really want the Exit Function line? That will end the coloring on the first line that isn't SYSTEM or ERROR.

vbDarkRed and vbDarkGreen are user-defined constants. I made those to replace the original vbRed and vbGreen, because they're WAY too bright.

Oh, then I would make them DARKGREEN and DARKRED instead. It's a matter of style but most programmers would think that because of the "vb" prefix that they were built-in constants.

Ok, now I know where the problem lies. It lies here:

rtbServerMessages.SelStart = 0

Apparently it's starting at the very first position in the textbox, not the very first position in strArray. All elements in strArray are correct, it's just that SelStart is at the beginning of the textbox. I know this because the first line is now part black and part green.

Question is how do I fix this one?

Yes, that makes sense.

I also figured out that it's not keeping the elements. They are lost as soon as I enter that first If statement. I've heard of using ReDim Preserve, but I'm not quite sure what that's for.

That can't be true unless you are running ColorServerMessageLines in a loop. Redim Preserve has to do with adding data to an array that already contains data which doesn't look like what you are doing.

BTW, I asked before about a file that contains the data. Can you supply one?

If you're talking about a text file that contains the data, the program doesn't make one. I didn't think that was a necessary step, but now that I'm running out of options, I think I will try it.

I found out something else, stepping through the code. Without the - 1, the program goes through the loop twice on the first attempt, even though there's only a single message. The - 1 is necessary.

Try this sample code.

VB Code:

Private Sub Command1_Click()
    Dim strArray() As String
    Dim i As Long
    
    strArray = Split(rtb.Text, vbNewLine)
    rtb.SelStart = 0
    
    For i = 0 To UBound(strArray)
        'select the entire line
        'the +2 is required for the NewLine characters as 
        'they are in the RTB but not the string array.
        rtb.SelLength = Len(strArray(i)) + 2
        
        If Left$(strArray(i), 6) = "SYSTEM" Then
            rtb.SelColor = vbGreen
        ElseIf Left$(strArray(i), 5) = "ERROR" Then
            rtb.SelColor = vbRed
        End If
        
        rtb.SelStart = rtb.SelStart + rtb.SelLength
        rtb.SelColor = vbBlack
    
    Next i
 
End Sub
 
Private Sub Form_Load()
    rtb.Text = "SYSTEM: ***X-Comm Server Loaded***" & vbNewLine & _
           "A Client has connected" & vbNewLine & _
           "ERROR: Client has received error 17" & vbNewLine & _
           "Client is pissed off" & vbNewLine & _
           "SYSTEM: ***A Client has disconnected***" & vbNewLine
End Sub

Quote:

---

Originally posted by hothead
...I found out something else, stepping through the code. Without the - 1, the program goes through the loop twice on the first attempt, even though there's only a single message. The - 1 is necessary.

---

The -1 is not correct. Put the following code in the Form_Load event of a new project.

VB Code:

Const SPLIT_ME As String = "split me"
    Dim strArray() As String
    Dim intIndex As Integer
    
    strArray = Split(SPLIT_ME, " ")
    For intIndex = 0 To UBound(strArray)
        Debug.Print strArray(intIndex)
    Next

That will result in

split
me

being printed. If however you add the -1 you only get split. Relating that to your data means that if you use the -1 you will never process the last line.

When you say it goes through the first line twice, that's impossible unless you are calling the routine twice. What it indicates is that the data does not look like you think it does. Did you ever put the breakpoint on the line I suggested to see what the data really looks like after the split?

Quote:

---

Originally posted by brucevde
Try this sample code.

VB Code:

Private Sub Command1_Click()
    Dim strArray() As String
    Dim i As Long
    
    strArray = Split(rtb.Text, vbNewLine)
    rtb.SelStart = 0
    
    For i = 0 To UBound(strArray)
        'select the entire line
        'the +2 is required for the NewLine characters as 
        'they are in the RTB but not the string array.
        rtb.SelLength = Len(strArray(i)) + 2
        
        If Left$(strArray(i), 6) = "SYSTEM" Then
            rtb.SelColor = vbGreen
        ElseIf Left$(strArray(i), 5) = "ERROR" Then
            rtb.SelColor = vbRed
        End If
        
        rtb.SelStart = rtb.SelStart + rtb.SelLength
        rtb.SelColor = vbBlack
    
    Next i
 
End Sub
 
Private Sub Form_Load()
    rtb.Text = "SYSTEM: ***X-Comm Server Loaded***" & vbNewLine & _
           "A Client has connected" & vbNewLine & _
           "ERROR: Client has received error 17" & vbNewLine & _
           "Client is pissed off" & vbNewLine & _
           "SYSTEM: ***A Client has disconnected***" & vbNewLine
End Sub

---

great job!

See, no -1 :)

It goes through the loop twice for some reason, even though only one line is in the textbox. strArray(0) is that first line I put in there, and strArray(1) is blank.

Put the - 1 in there, and it does right, just as I said before.

At any rate, the colors don't change at all now.

I can only repeat what I said above

Quote:

---

When you say it goes through the first line twice, that's impossible unless you are calling the routine twice. What it indicates is that the data does not look like you think it does. Did you ever put the breakpoint on the line I suggested to see what the data really looks like after the split?

---

Here is my Form_Load code. Notice that I called the routine only once.

VB Code:

Private Sub Form_Load()
    If OptionType = "Server" Then
        Frame1.Caption = "Server Status"
        Me.Caption = "X-Comm - An experimental PIRC-based chat system - Server Side"
        Label1.Visible = False
        Label2.Visible = False
        lblInfo.Visible = True
        lblInfo.Caption = "Your IP: " & wskServerListener.LocalIP
        txtServerIP.Visible = False
        txtUsername.Visible = False
        Toolbar1.ImageList = ImageList1
        Toolbar1.Buttons(1).Visible = False
        Toolbar1.Buttons(2).Visible = False
        Toolbar1.Buttons(4).Visible = True
        Toolbar1.Buttons(5).Visible = True
        rtbServerMessages.Text = "SYSTEM:  ***X-Comm Server Loaded***" & vbNewLine
        ColorServerMessageLines
        wskServerListener.LocalPort = 450
        wskServerListener.Listen
    Else
        Frame1.Caption = "Server Messages"
        Me.Caption = "X-Comm - An experimental PIRC-based chat system - Client Side"
        Toolbar1.ImageList = ImageList1
        rtbServerMessages.Text = "***X-Comm Client standing by***"
    End If
End Sub

I might know what the problem is.

strArray(0) is the actual text, and strArray(1) is actually the NewLine character, only we can't see it. But vbCrLf gives the same results.

Split will create an array with an extra element if the delimiter is at the end of the string. The extra element contains an empty string not a vbNewLine, which by the way is the same as vbCRLF.

I believe there's more to what I'm trying to do than just this. I need to set the selstart property to the beginning of strArray(i), and of course it won't let me because selstart takes a Long argument, not a String one.

Did you use the code I posted a few days ago at all?

I just got it working partially. I got an idea though. Is there any way to get the number of elements in an array?

Here's what happens:

First time, the green system message appears.
Second time, the black miscellaneous message appears.
Third time, the second green system message appears, and all text in the textbox turns green, including the *supposedly* black misc message.

Well, how about you post the code you are using again. It sounds like there have been some changes. Maybe we can get this resolved. Also explain why my code won't work.

I did make some changes to get it to work. Here's the way it looks:

VB Code:

Private Function ColorServerMessageLines()
    Dim strArray() As String
    strArray = Split(rtbServerMessages.Text, vbNewLine)
    rtbServerMessages.SelStart = 0
    For i = 0 To UBound(strArray)
        rtbServerMessages.SelLength = Len(strArray(i)) + 2
        If Left$(strArray(i), 6) = "SYSTEM" Then
            rtbServerMessages.SelColor = DarkGreen
        ElseIf Left$(strArray(i), 5) = "ERROR" Then
            rtbServerMessages.SelColor = DarkRed
        Else
            rtbServerMessages.SelColor = vbBlack
        End If
        rtbServerMessages.SelStart = rtbServerMessages.SelStart + rtbServerMessages.SelLength
    Next i
End Function

However, it only works the first couple times the code is run through. If I get something like this:

SYSTEM: Test
Test
SYSTEM: Test

the whole thing will turn green again. However, it'll work with something like this:

SYSTEM: Test
Test

Is the RTB changing at all while the coloring process is executing. What you describe seems impossible? I have tested a bunch of different ways and cannot duplicate your problem.

Can you show the code that adds the text to the RTB?

EDIT: I have already found the problem, it was a missing function call. It works completely now. Thanks a lot! :D

Quote:

---

Originally posted by hothead
It goes through the loop twice for some reason, even though only one line is in the textbox

---

And........... a CarriageReturn (that you loaded in the Form Load Event)!

Hence the Array has two elements (0) being the first word, and (1) containing ""




Bruce.

might i also suggest trimming any VBCrLf's (newline) from the end?

something like

VB Code:

Do Until Right(rtbServerMessages.Text, 2) <> vbCrLf
    rtbServerMessages.Text = Left(rtbServerMessages.Text, Len(rtbServerMessages.Text) - 2)
Loop