find files -> alter code ? chrisjk

Quote:

---

Originally posted by Dutch
btw notLKH , very nice code , and very fast ! thanks

---

Your Welcome:D
But, I Kinda thought, with the Doevents in it, { To prevent freezing up in the looping process, Just in case you want to shut it down} It really slows it down.

And, For each dir, it performs TWO searches, once to find
all the Sub Dir's, then the Next to Match the Requested Pattern.

I just wipped it together in about 10 minutes, so if I had
worked on it a little more, I'd probably trim it down, combining the
2 searches into one, which would propably make it faster.

But, Last night it was just easier to keep track of the code this way.

As to chrisjks code,
Its a stumper why you're having these problems. :(

-Good Luck
-Lou

i'm going to use your code in my program if you don't mind
, now if i could only get that darn drivelistbox to work
i would be completely happy

Quote:

---

Originally posted by NotLKH
As to chrisjks code,
Its a stumper why you're having these problems.

---

Mad isn't it?!

It sure is!

It would seem that, with a couple of tweaks, it should work just fine!

This is how the code is supposed to Function, right?

1) Find only MP3's
2) Skip the Garbage Can
3) Use a Drive List Box for selecting Searches on Logical Drive.
4) The Output of the search goes to List1.

Just on a casual inspection, I see nothing that would prevent it
from working.

I'll see if it works on my system in an hour or two.

-Lou

thats exactly what it should do , like i said , if i use a textbox and
enter C:\ or any other drive it works just fine but it doesn't with a
drivelistbox , i tried a Text1_Change and then Text1.Path =
Drive1.drive but that didn't help much , however when i use just
Drive1.Drive & "\" and select my floppy i can hear the darn thing thing rattle and i get a error , same with cd-rom .

did you try making the drivelistbox & "\" into a string, then putting the string value into the function??

i did do the & "\" , but i don't know how to make a string value into the function , plz explain :)

Quote:

---

Originally posted by Dutch
but i don't know how to make a string value into the function , plz explain :)

---

You already did ;)

dim start as string
start = drive1.drive & "\"
Start_Where = start

Skitchen 8 is the grandmaster of coding !!!! :) it flippin works :)

well . almost that is , it only scans my c drive , no matter what drive i choose :(

hm... imagine that everyone i got something right.... YAY FOR ME!!!!

darn , u were faster :)

i edited and said it only scans my c drive , no matter what drive i choose :(

hm... i might just have to load it up and work on that then.... i have my outlook set up so it gets me messages as soon as they come in so i respond right away

Quote:

---

Originally posted by Dutch
Skitchen 8 is the grandmaster of coding !!!! :) it flippin works :)

well . almost that is , it only scans my c drive , no matter what drive i choose :(

---

I just noticed something. The DriveList Box returns The
Logical Drive AND the Network Path.

ie:
msgbox Drive1.Drive
returns This: {My k Drive}

k: [\\NT-RAID1\PPI]

So, DO THIS:


dim start as string
start = left(drive1.drive, 1) & ":\"
Start_Where = start


-Hope this Helps
-Lou

ok , i just did , didn't help
what is " left " supose to do ?

Quote:

---

Returns a Variant (String) containing a specified number of characters from the left side of a string

---

[QUOTE]Originally posted by NotLKH
[B]



dim start as string
start = left(drive1.drive, 1) & ":\"
Start_Where = start


Just Double Checking:

You DID tag start with ":\" after the left, COLIN and slash, right?

FYI, the left just grabs the Drive Letter, A->Z.

Think you could do a MsgBox on Start_Where,
and tell us what you get? {For the c drive AND one of your Net Drives?}

-Lou

i see , well that figures then , i figured VB aint that hard to learn , i was wrong :)

Since we posted at the same time, you might have missed it, so
check the post RIGHT before your last.

-Lou

ok , i did the MsgBox , it returns the correct drive's , and , no matter what drive i choose , i get all the mp3's on all of the drive's , so it doesn't scan 1 drive , it just scans them all IE if i select C it returns all the mp3's on C , D and E ( my harddrives ) same goes if i select D or E

Hmm,

So you literally get the messages "C:\" or "D:\" or "E:\"
from the Message Box?

Hmm, Frustrating.

Think you code Post your Project?
Attach it as a Zip File?

-Lou

yes that what i get back from the MsgBox , ignore my last post about it scans all the drive's , it just scans C , i was wrong there , sorry .

Code:

---

Private Sub Command1_Click()
Dim Find_What As String
Dim Start_Where As String
Dim SKIP_THIS As String
SKIP_THIS = ":\RECYCLED" '''Your Recycle bin
Find_What = "*.mp3"  '''What you want to find
Start_Where = Start  '''Your initial directory
MsgBox Drive1.Drive
List1.Clear
Call FIND_IT(Start_Where, Find_What, SKIP_THIS)
End Sub


Private Sub FIND_IT(ByVal M_Where As String, ByVal M_What As String, ByVal Skip_What As String)
Dim MY_DIRS() As String
Dim Start As String
Start = Left(Drive1.Drive, 1) & ":\"
Dim MY_COUNT As Integer '
MY_COUNT = 0
ReDim MY_DIRS(1)

If Right(M_Where, 1) <> "\" Then
    M_Where = M_Where & "\"
End If

doiexist = Dir(M_Where & "*.*", vbDirectory)
While doiexist <> ""
    If doiexist <> "." And doiexist <> ".." Then
        If (GetAttr(M_Where & doiexist) And vbDirectory) = vbDirectory Then
            MY_COUNT = MY_COUNT + 1
            ReDim Preserve MY_DIRS(MY_COUNT)
            MY_DIRS(MY_COUNT) = M_Where & doiexist
            Form1.Caption = MY_COUNT
            DoEvents
        End If
    End If
    doiexist = Dir
Wend
If Left(M_Where, Len(Skip_What) + 1) <> Skip_What & "\" Then
    doiexist = Dir(M_Where & M_What, vbNormal)
    While doiexist <> ""
        List1.AddItem M_Where & doiexist
        doiexist = Dir
    Wend
End If
For Each Thing In MY_DIRS
    If Thing <> "" Then
        Call FIND_IT(Thing, M_What, Skip_What)
    End If
Next Thing
End Sub

---

crap , the minute i posted it i saw it , u guys see it too ?
i entered the
Dim Start As String
Start = Left(Drive1.Drive, 1) & ":\"
in the wrong place , it has to go under the command button.
thats a mistake i won't make again

it works now , thx guys , i learned a lot :)

on more thing , how about a msgbox if no file is found ?
i would need a If , Then for that huh

Quote:

---

Originally posted by Dutch

Code:

---

Private Sub Command1_Click()
Dim Find_What As String
Dim Start_Where As String
Dim SKIP_THIS As String
SKIP_THIS = ":\RECYCLED" '''Your Recycle bin
Find_What = "*.mp3"  '''What you want to find
Start_Where = Start  '''Your initial directory
MsgBox Drive1.Drive
List1.Clear
Call FIND_IT(Start_Where, Find_What, SKIP_THIS)
End Sub

---

---

Change the Above to this:

VB Code:

Private Sub Command1_Click()
Dim Find_What As String
Dim Start_Where As String
Dim SKIP_THIS As String
dim start as string 
SKIP_THIS = ":\RECYCLED" '''Your Recycle bin
Find_What = "*.mp3"  '''What you want to find
start = left(drive1.drive, 1) & ":\" 
Start_Where = start 
MsgBox Drive1.Drive
List1.Clear
Call FIND_IT(Start_Where, Find_What, SKIP_THIS)
End Sub

Next, get rid of:

VB Code:

Dim Start As String
Start = Left(Drive1.Drive, 1) & ":\"

out of the FIND_IT sub. {Comment it out, delete it, whatever}

Try it and tell us what happens.


{You've altered SKIP_THIS, It won't work. We're going to have
to fix that. Do you have ant recycle bins on anything other than the c drive?}

-Lou

Heh, took longer than expected. Glad you saw it!
Still, SKIP_THIS needs fixing.

-Lou

like i said , it works now :) but thnks for all your work .

could u help me with a MsgBox in case a mp3 isn't found ?

You could try this:

VB Code:

Private Sub Command1_Click()
Dim Find_What As String
Dim Start_Where As String
Dim SKIP_THIS As String
dim start as string 
SKIP_THIS = ":\RECYCLED" '''Your Recycle bin
Find_What = "*.mp3"  '''What you want to find
start = left(drive1.drive, 1) & ":\" 
Start_Where = start 
MsgBox Drive1.Drive
List1.Clear
Call FIND_IT(Start_Where, Find_What, SKIP_THIS)
if List1.Listcount = 0 then
MsgBox "File(s) Not Found! Try Again Later!"
End If ''''OOPS, Forgot this! Just added in an Edit Post!
End Sub

It should work, unless Command1_Click ends before FIND_IT finishes.

BUT, if that happens, We can tweek it with an end of sub public
variable.


BTW, Again, the Recycle check won't work, the way you've changed it.

-Lou