CommonControls (Replacement of the MS common controls)

The Type Mismatch errors don't seem to be happening in the demo project. I should also clarify it's only an issue in the IDE. It's never given that error or crashed while running, either from VB or compiled.

If I had to guess, the 'type mismatch' is related to the fact that OLEGuids.IPerPropertyBrowsingVB and OLEGuids.IPerPropertyBrowsing are both being used- and if it's me only... I'll look for something not explicitly typed to OLEGuids but I also have olelib.IPerPropertyBrowsing that has a different set of methods. However it's not in use anywhere and everything in your project is explicitly typed as OLEGuids.IPer.. so not sure how such a conflict would arise. Why these three all have a different set of methods is bothersome...

Code:

---

Private Sub ReplaceIPPB(ByVal This As OLEGuids.IPerPropertyBrowsing)
If VTableSubclassPPB Is Nothing Then Set VTableSubclassPPB = New VTableSubclass
If VTableSubclassPPB.RefCount = 0 Then
  VTableSubclassPPB.Subclass ObjPtr(This), VTableIndexPPBGetDisplayString, VTAbleIndexPPBGetPredefinedValue, _
    AddressOf IPPB_GetDisplayString, 0, _



Private Function IPPB_GetDisplayString(ByVal This As Object, ByVal DispID As Long, ByVal lpDisplayName As Long) As Long
Dim ShadowIPerPropertyBrowsingVB As OLEGuids.IPerPropertyBrowsingVB

[..]
Set ShadowIPerPropertyBrowsingVB = This 'type mistmatch

---

Quote:

---

Originally Posted by [email protected]

This article seems to provide the reasons for the crash when closing the program...

http://www.vbaccelerator.com/home/VB...wn/article.asp

But I don't like the sol'n... Paul

---

The solution is already implemented into the controls. ("LoadLibrary("shell32.dll")", etc.)
The InitVisualStyle method is located in VisualStyles.bas.

I had this problem also once and the reason was by one specific control. Maybe you can trial and error and look if it still crashes when you remove the controls except one and so on... So you run-trough all controls and trace the source of the problem.

Thanks, the only time it happens for my existing project (10+ years old) was 2 days ago when we included the VBCCR11.OCX. And we only use the TreeView from this OCX, on 1 form, of over 5 dozen forms. The crash occurs at an End statement. The situation is that we must use the VBCCR11.OCX TreeView to provide access to the 100's of program we have in the QMC Program Suite. See QMC.net. Thanks so much, Paul

FYI: The new MS supplied ComCtl32/TreeView does not work any more with the functionality we and many others need (and as seen on many forums) and is not compatible with any past releases (since 1997). Right now it is only the TreeView they have changed making this a complete MS Mess. With the way they do it provides no work around. You cannot put the required ComCtl32 in the System32 or W[/B][/B]OW folders and over write the new MS ComCtl32 since it affects IE and other programs. And when the old ComCtl32 is placed in rhe APP.PATH it will not register (programs still use the new new ComCtl32). Please help...

It is not recommended at all to use the End statement. Does it crash when you make a 'clean' close of your App?

Don't know what a "clean-close" is...? P

Quote:

---

Originally Posted by [email protected]

Don't know what a "clean-close" is...? P

---

Close the App by closing all Forms for instance instead of an End statement.

Did and it works great now... What about the Node Click Event, does it exist for the TreeView with your Controls? Thanks, so much. (How can I repay you for this? You are invaluable for sure!!!)

Quote:

---

Originally Posted by [email protected]

What about the Node Click Event, does it exist for the TreeView with your Controls?

---

Yes, of course.

Can you give me a sample code for the sub? I cannot find any click event under the object browser folder library for your control... Thanks, Paul

Do you know a VB consultant that can help us move to your controls? We have to get rid of MS dependencies or die... Paul

Quote:

---

Originally Posted by [email protected]

Can you give me a sample code for the sub? I cannot find any click event under the object browser folder library for your control...

---

Can you see the NodeClick event in the Demo project?

Attachment 127215

What demo, all I have found are 2 versions of the OCX? I am using VBCCR11.OCX which is a zip. The only demo I have found is for a MDI ToolBar... Can you please tell me wher the TreView DEMO is? Thanks, Paul

But anyway, I get 4 events in my program with your Control: DragDrop, DragOver, GotFocus, and LostFocus. That's It, No Mas. Nothing of what you show... ??? Re, Paul

On the first page the first post is a attachment "ComCtlsDemo.rar.zip". (On the bottom of the post)

Thanks, checking it out. Paul

Hey Krool, does your TreeView have events for the adding and removal of nodes ?

Krool knows for sure, but using the followong seems to work:

Set nodX = tvQMCProgram.Nodes.Add(, , "Data Mining", "Data Mining Programs", 1, 2)

'Sub Folder Data Screener
Set nodX = tvQMCProgram.Nodes.Add("Data Mining", tvwChild, "DS", "Data Screening", 1, 2)

'QMCDLLs
MyName = "DataScreener DLL Test"
Set nodX = tvQMCProgram.Nodes.Add("DS", tvwChild, MyName, MyName, 3)

However, I cant seem to get the icons to load from a ImageList...

Paul

PS: I also have the VB5 Comctl32.OCX loaded with Krool's in the same project... P

Quote:

---

Originally Posted by Niya

Hey Krool, does your TreeView have events for the adding and removal of nodes ?

---

I could create a event in response to TVN_DELETEITEM. However, there is no notification when a node is being added...

I am thinking the:

Function HitTest(X As Single, Y As Single) As TvwNode

And the Selected Item (Node) should work within the above FNC. I will try over the weekend... Paul

Quote:

---

Originally Posted by Krool

I could create a event in response to TVN_DELETEITEM. However, there is no notification when a node is being added...

---

Oh, if you did, I just wanted to know what messages you intercepted. I have an inherited TreeView in .Net where I added events for the addition and deletion of nodes but its not perfect. There was no real direct message for these events so I had to get a bit clever but the solution has a couple nuances.

The VBCCR11.ListView control, while doing a drag operation throws "Run-time error '0'" intermittently and causes the application to crash.


Attachment 127301

Any insight on potential causes for this issue would help.

Quote:

---

Originally Posted by vb6rocks

The VBCCR11.ListView control, while doing a drag operation throws "Run-time error '0'" intermittently and causes the application to crash.


Attachment 127301

Any insight on potential causes for this issue would help.

---

Please provide your code. Does this also happen when using the StdEXE-ListView?

Quote:

---

Originally Posted by Krool

Please provide your code. Does this also happen when using the StdEXE-ListView?

---

No, the original control (MSComctlLib.ListView) that was replaced did not have this issue.

I've attached the event handlers and properties. I did observe that when the run-time error happens, it does not hit the trace message at the beginning of OLEStartDrag event handler. It seems like something is happening even before that. When I debug, the application crashes after this error and I get a memory reference exception.
Attachment 127335

Quote:

---

Originally Posted by vb6rocks

No, the original control (MSComctlLib.ListView) that was replaced did not have this issue.

I've attached the event handlers and properties. I did observe that when the run-time error happens, it does not hit the trace message at the beginning of OLEStartDrag event handler. It seems like something is happening even before that. When I debug, the application crashes after this error and I get a memory reference exception.

---

In my tests the OLEStartDrag event fires w/o any run-time error.. (W2K, WinXP and Win7 tested)

By StdEXE-ListView I did not mean the MSComctlLib.ListView, rather I mean my ListView control. (non-OCX, can be found in the Demo project) Can you test if there is the same issue?
Do you also use the latest VBCCR11.OCX version? (revision number)

Quote:

---

Originally Posted by Krool

In my tests the OLEStartDrag event fires w/o any run-time error.. (W2K, WinXP and Win7 tested)

By StdEXE-ListView I did not mean the MSComctlLib.ListView, rather I mean my ListView control. (non-OCX, can be found in the Demo project) Can you test if there is the same issue?
Do you also use the latest VBCCR11.OCX version? (revision number)

---

I've not been able to reproduce the issue in the Demo project. However, as you can see, the implementations are different in both cases. It's not clear what is causing the issue.

I was able to reproduce the run-time error on the latest version of VBCCR11.OCX (Revision 32).

Quote:

---

Originally Posted by vb6rocks

I've not been able to reproduce the issue in the Demo project. However, as you can see, the implementations are different in both cases. It's not clear what is causing the issue.

I was able to reproduce the run-time error on the latest version of VBCCR11.OCX (Revision 32).

---

Additionally, I was able to identify that the following line (in red) in VBCCR11 is what is causing the run-time error (Overflow):

Private Sub UserControl_OLEStartDrag(Data As DataObject, AllowedEffects As Long)
If ListViewDragIndex > 0 Then
If ListViewHandle <> 0 Then
Dim P(0 To 1) As POINTAPI, RC As RECT
GetCursorPos P(0)
ScreenToClient ListViewHandle, P(0)
SendMessage ListViewHandle, LVM_GETITEMPOSITION, ListViewDragIndex - 1, ByVal VarPtr(P(1))
SendMessage ListViewHandle, LVM_GETVIEWRECT, 0, ByVal VarPtr(RC)
ListViewDragOffsetY = (P(1).Y - P(0).Y) + RC.Top
ListViewDragOffsetX = (P(1).X - P(0).X) + RC.Left
End If
If PropOLEDragMode = vbOLEDragAutomatic Then
Dim Text As String
Text = Me.FListItemText(ListViewDragIndex, 0)
Data.SetData StrToVar(Text & vbNullChar), CF_UNICODETEXT
Data.SetData StrToVar(Text), vbCFText
AllowedEffects = vbDropEffectMove Or vbDropEffectCopy
End If
End If
RaiseEvent OLEStartDrag(Data, AllowedEffects)
If AllowedEffects = vbDropEffectNone Then ListViewDragIndex = 0
End Sub

Quote:

---

Originally Posted by vb6rocks

Additionally, I was able to identify that the following line (in red) in VBCCR11 is what is causing the run-time error (Overflow):

Private Sub UserControl_OLEStartDrag(Data As DataObject, AllowedEffects As Long)
If ListViewDragIndex > 0 Then
If ListViewHandle <> 0 Then
Dim P(0 To 1) As POINTAPI, RC As RECT
GetCursorPos P(0)
ScreenToClient ListViewHandle, P(0)
SendMessage ListViewHandle, LVM_GETITEMPOSITION, ListViewDragIndex - 1, ByVal VarPtr(P(1))
SendMessage ListViewHandle, LVM_GETVIEWRECT, 0, ByVal VarPtr(RC)
ListViewDragOffsetY = (P(1).Y - P(0).Y) + RC.Top
ListViewDragOffsetX = (P(1).X - P(0).X) + RC.Left
End If
If PropOLEDragMode = vbOLEDragAutomatic Then
Dim Text As String
Text = Me.FListItemText(ListViewDragIndex, 0)
Data.SetData StrToVar(Text & vbNullChar), CF_UNICODETEXT
Data.SetData StrToVar(Text), vbCFText
AllowedEffects = vbDropEffectMove Or vbDropEffectCopy
End If
End If
RaiseEvent OLEStartDrag(Data, AllowedEffects)
If AllowedEffects = vbDropEffectNone Then ListViewDragIndex = 0
End Sub

---

Another difference when compared to the demo is that in our case we are doing a drag and drop on controls that are in different forms. (The demo project has both the controls in the same form.)

We are using your library extensively for Unicode support and it has been very beneficial so far.

Update: We were able to identify the root cause of the run-time error. It was caused by one of the long variables (RC.Top/ RC.Left) getting set to it's max value (2147483647) and the addition operation caused an Overflow exception.

Quote:

---

Originally Posted by vb6rocks

Additionally, I was able to identify that the following line (in red) in VBCCR11 is what is causing the run-time error (Overflow):

Private Sub UserControl_OLEStartDrag(Data As DataObject, AllowedEffects As Long)
If ListViewDragIndex > 0 Then
If ListViewHandle <> 0 Then
Dim P(0 To 1) As POINTAPI, RC As RECT
GetCursorPos P(0)
ScreenToClient ListViewHandle, P(0)
SendMessage ListViewHandle, LVM_GETITEMPOSITION, ListViewDragIndex - 1, ByVal VarPtr(P(1))
SendMessage ListViewHandle, LVM_GETVIEWRECT, 0, ByVal VarPtr(RC)
ListViewDragOffsetY = (P(1).Y - P(0).Y) + RC.Top
ListViewDragOffsetX = (P(1).X - P(0).X) + RC.Left
End If
If PropOLEDragMode = vbOLEDragAutomatic Then
Dim Text As String
Text = Me.FListItemText(ListViewDragIndex, 0)
Data.SetData StrToVar(Text & vbNullChar), CF_UNICODETEXT
Data.SetData StrToVar(Text), vbCFText
AllowedEffects = vbDropEffectMove Or vbDropEffectCopy
End If
End If
RaiseEvent OLEStartDrag(Data, AllowedEffects)
If AllowedEffects = vbDropEffectNone Then ListViewDragIndex = 0
End Sub

---

Is the same happening when you use the Std-Exe ListView?
If yes, what are the debug values? Maybe the var type 'Long' for ListViewDragOffsetX/Y is not sufficient..

EDIT: Ok you figured out that the RC.Top / RC.Left values (in fact LVM_GETVIEWRECT) are set to its max value and of course causing an Overflow exception. Try to declare ListViewDragOffsetX/Y as Double instead of Long. Does this solves the issue?

Quote:

---

Originally Posted by Krool

Is the same happening when you use the Std-Exe ListView?
If yes, what are the debug values? Maybe the var type 'Long' for ListViewDragOffsetX/Y is not sufficient..

EDIT: Ok you figured out that the RC.Top / RC.Left values (in fact LVM_GETVIEWRECT) are set to its max value and of course causing an Overflow exception. Try to declare ListViewDragOffsetX/Y as Double instead of Long. Does this solves the issue?

---

Yes, technically, using Double would solve the problem. In our case, we just added a check to see if RC.Top is > max value, if yes, then set ListViewDragOffsetY to max value instead of doing an addition operation. This solved the problem for us. We'll wait for you to provide a fix for your library and in the interim, we'll use this solution, thanks.

Quote:

---

Originally Posted by vb6rocks

We'll wait for you to provide a fix for your library and in the interim, we'll use this solution, thanks.

---

Update released.

Quote:

---

Originally Posted by Krool

Update released.

---

Great, thanks for the quick turnaround!

The textbox has a great Property

Property Code:

AllowOnlyNumbers

would it be possible to add AllowDecimal, and/or how many digits after the Decimal?

Thanks so much for this excellent control. Just wondering if you could add a vertical alignment property to the label and textbox control.

[...]

Quote:

---

Originally Posted by dz32

is this in source control anywhere?

---

The source code for the ActiveX Controls are not public.

But the code for the Std-EXE Controls (located in the ComCtlsDemo project) are public. These are also with the latest features as the ActiveX Control project will be updated rarely. (Until now only two versions; 1.0 and 1.1)
Only bugfixes will be updated to the existing ActiveX Control versions, as this does not break binary compatibility.

[...]

This is a bit off-topic question, but is there a replacement for Frame control because of this problem: Attachment 127711

Quote:

---

Originally Posted by MikiSoft

This is a bit off-topic question, but is there a replacement for Frame control because of this problem: Attachment 127711

---

This project have a replacement of the frame control, 'FrameW'.

I'm so blind... Thanks for the controls, you did an excellent job!