[RESOLVED] Sub within a Sub

Hey there, people.
I have two subs:

Code:

---

Private Sub BindingNavigatorAddNewItem_Click(sender As Object, e As EventArgs) Handles BindingNavigatorAddNewItem.Click

---

and

Code:

---

Private Sub _11registernew_Load(sender As Object, e As EventArgs) Handles MyBase.Load

---

and I need to run the BindingNavigatorAddNewItem_Click sub inside of the _11registernew_Load sub.
All help is appreciated.
Thanks!

Quote:

---

Originally Posted by bruel1999

Hey there, people.
I have two subs:

Code:

---

Private Sub BindingNavigatorAddNewItem_Click(sender As Object, e As EventArgs) Handles BindingNavigatorAddNewItem.Click

---

and

Code:

---

Private Sub _11registernew_Load(sender As Object, e As EventArgs) Handles MyBase.Load

---

and I need to run the BindingNavigatorAddNewItem_Click sub inside of the _11registernew_Load sub.
All help is appreciated.
Thanks!

---

Just put:

vb.net Code:

BindingNavigatorAddNewItem.PerformClick()

in the Form Load event :)

Code:

---

Private Sub _11registernew_Load(sender As Object, e As EventArgs) Handles MyBase.Load
  BindingNavigatorAddNewItem_Click(sender, New EventArgs())

End Sub

---

Quote:

---

Originally Posted by dee-u

Code:

---

Private Sub _11registernew_Load(sender As Object, e As EventArgs) Handles MyBase.Load
  BindingNavigatorAddNewItem_Click(sender, New EventArgs())

End Sub

---

---

Nope. It's very poor form to call an event handler directly. In cases where you want to simulate a button click, calling the appropriate PerformClick method is appropriate. In all other cases, the appropriate action is to take the common code out of either event handler, put it in a method of its own and then call that method from both event handlers.

Also, if you ever do want an EventArgs object, it's proper to use EventArgs.Empty rather than explicitly invoke a constructor.

Besides it's the wrong Sender too... the sender in the Form load would be the form, but the sender of a button click is the button. So to pass the form as the sender to a button click event handler would be very bad. Almost as bad as crossing the streams.

Now, another (and cleaner option in my opinion) is to move the code to a sub... then the load event handler and the form load event handlers would simply call that sub.
-tg

Posting that code even upon seeing the PerformClick suggestion, I expected to get some heat but I guess it is not that bad at all to show another way to skin a cat. It maybe inappropriate / bad but it can also perform the job, or am I wrong? :-) I don't want to derail this thread so off I go.

Quote:

---

Originally Posted by berny22

Just put:

vb.net Code:

BindingNavigatorAddNewItem.PerformClick()

in the Form Load event :)

---

Yes, this is how I have called code with a button from a sub before.

Quote:

---

Originally Posted by dee-u

Posting that code even upon seeing the PerformClick suggestion, I expected to get some heat but I guess it is not that bad at all to show another way to skin a cat. It maybe inappropriate / bad but it can also perform the job, or am I wrong? :-) I don't want to derail this thread so off I go.

---

That code will probably do the job in this particular case but if there are better ways to do it, especially if they are no more trouble, then it's better to provide those ways only or at least indicate that they are better. No point getting someone new into bad habits that they then need to break later. There are certain situations where that code would cause issues too. If there are other options that avoid those issues then they would generally be preferable, especially when someone inexperienced might not understand the cause of the issue and therefore not be able to fix it without further help. Providing more than one way to do things is not necessarily bad but it can be a good way to confuse those less experienced, especially if an option is inferior in some way and that is not pointed out.

Quote:

---

Originally Posted by dee-u

Posting that code even upon seeing the PerformClick suggestion, I expected to get some heat but I guess it is not that bad at all to show another way to skin a cat. It maybe inappropriate / bad but it can also perform the job, or am I wrong? :-) I don't want to derail this thread so off I go.

---

Actually there could have been a lot wrong with it... what if the event handler for the button used sender to determine the button clicked, or some other critical information? Since you passed in form, the event handler would fail when it tries to cast the sender to a button. At that point, it's no good.

-tg

Quote:

---

Originally Posted by berny22

Just put:

vb.net Code:

BindingNavigatorAddNewItem.PerformClick()

in the Form Load event :)

---

Thanks! :)