open file

Code:

---

#include "iostream.h"
#include "fstream.h"
#include "stdafx.h"

int getdir();

int getdir()
{
int i;
ofstream out("C:/Matt/text3.txt");

if(!out) {
                MessageBox(NULL,"Cannot open output file","Error",MB_OK);
                return 1;
}

for(i=0;i<256; i++) out.put((char) i);

out.close();

        return 0;
}

---

im using MVC++ and i get errors. This worked on my old compiler but not MS's. What am I doing wrong here? Thanks

Code:

---

#include "iostream.h"
#include "fstream.h"
#include "stdafx.h"

---

Put iostream.h and fstream.h inside angle-brackets <>. What's in stdafx.h? You shouldn't need it since you're not using MFC.

Code:

---

if(!out)

---

Try if(out.fail()).

Where are the errors?

Usually you use angled brackets for headers like that, and quote headers for headers you make yourself. It makes a difference to the order in which paths are searched for header files. Maybe that's making it go wrong. It's easier to diagnose problems when you have error messages.

Ah well okay Parksie already posted :rolleyes:

Quote:

---

Originally posted by HarryW
Ah well okay Parksie already posted :rolleyes:

---

Hehe sorry :rolleyes:

You realise I'll never forgive you for this. I'm just devastated.

Sure you are :) You'll just have to get me back for it some other time then ;)

here are the errors theres still problems with it.
here are the headers.

#include <iostream.h>
#include <fstream.h>

mywinapp.cpp
C:\MATT\MVC++\MSDEV98\MyProjects\mywinapp\mywinapp.cpp(99) : error C2143: syntax error : missing ';' before '.'
C:\MATT\MVC++\MSDEV98\MyProjects\mywinapp\mywinapp.cpp(99) : error C2143: syntax error : missing ';' before '.'
C:\MATT\MVC++\MSDEV98\MyProjects\mywinapp\mywinapp.cpp(101) : error C2065: 'out' : undeclared identifier
C:\MATT\MVC++\MSDEV98\MyProjects\mywinapp\mywinapp.cpp(101) : error C2228: left of '.fail' must have class/struct/union type
C:\MATT\MVC++\MSDEV98\MyProjects\mywinapp\mywinapp.cpp(106) : error C2228: left of '.put' must have class/struct/union type
C:\MATT\MVC++\MSDEV98\MyProjects\mywinapp\mywinapp.cpp(108) : error C2228: left of '.close' must have class/struct/union type
Error executing cl.exe.